chocolate-doom failed to build from source in Fedora rawhide/f32 https://koji.fedoraproject.org/koji/taskinfo?taskID=41316160 For details on the mass rebuild see: https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild Please fix chocolate-doom at your earliest convenience and set the bug's status to ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks, chocolate-doom will be orphaned. Before branching of Fedora 33, chocolate-doom will be retired, if it still fails to build. For more details on the FTBFS policy, please visit: https://fedoraproject.org/wiki/Fails_to_build_from_source
Created attachment 1658584 [details] build.log file build.log too big, will only attach last 32768 bytes
Created attachment 1658585 [details] root.log file root.log too big, will only attach last 32768 bytes
Created attachment 1658586 [details] state.log
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle. Changing version to 32.
Dear Maintainer, your package has not been built successfully in 32. Action is required from you. If you can fix your package to build, perform a build in koji, and either create an update in bodhi, or close this bug without creating an update, if updating is not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to acknowledge this. Following the latest policy for such packages [2], your package will be orphaned if this bug remains in NEW state more than 8 weeks. A week before the mass branching of Fedora 33 according to the schedule [3], any packages not successfully rebuilt at least on Fedora 31 will be retired regardless of the status of this bug. [1] https://fedoraproject.org/wiki/Updates_Policy [2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/ [3] https://fedoraproject.org/wiki/Releases/33/Schedule
I'm a drive-by contributor who just noticed that chocolate-doom isn't in the Fedora Packages search results. From the build logs, this is the failure: /usr/bin/ld: hexen/libhexen.a(g_game.o):(.bss+0x944): multiple definition of `demoextend'; hexen/libhexen.a(mn_menu.o):(.bss+0x34): first defined here I'm not sure why this is failing now when the sources haven't changed.
Dear Maintainer, your package has an open Fails To Build From Source bug for Fedora 32. Action is required from you. If you can fix your package to build, perform a build in koji, and either create an update in bodhi, or close this bug without creating an update, if updating is not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to acknowledge this. If you have already fixed this issue, please close this Bugzilla report. Following the policy for such packages [2], your package will be orphaned if this bug remains in NEW state more than 8 weeks (that's on 2020-04-02). A week before the mass branching of Fedora 33 according to the schedule [3], any packages not successfully rebuilt at least on Fedora 31 will be retired regardless of the status of this bug. [1] https://fedoraproject.org/wiki/Updates_Policy [2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/ [3] https://fedorapeople.org/groups/schedule/f-33/f-33-key-tasks.html
This problem is caused by the upgrade to GCC 10. The new GCC version defaults to -fno-common, which causes the linker to fail when there are multiple definitions of a global variable. Hexen defines the global demoextend in both src/hexen/g_game.c and src/hexen/mn_menu.c. I'll work on a patch to fix this. It's also possible to explicitly set the -fcommon flag to work around the issue.
I submitted a patch that fixes this to upstream. https://github.com/chocolate-doom/chocolate-doom/pull/1257 What's the best way to make sure that this makes it into Fedora 32? If upstream accepts the patch and cuts a release can we use that version in 32? Or do we need to carry a patch downstream?
My patch was accepted upstream and is now on master.
chocolate-doom-3.0.0-5.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7feeffda7b
FEDORA-2020-7feeffda7b has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.