Bug 1799443 - Change of memory threshold in Workers tab not reflected - only with CU Data Collectors and Refresh workers
Summary: Change of memory threshold in Workers tab not reflected - only with CU Data C...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.11.2
Hardware: Unspecified
OS: Linux
high
high
Target Milestone: GA
: 5.12.0
Assignee: Zita Nemeckova
QA Contact: Pavel Šimovec
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks: 1805845
TreeView+ depends on / blocked
 
Reported: 2020-02-06 17:03 UTC by Pavel Šimovec
Modified: 2020-10-29 17:23 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1805845 (view as bug list)
Environment:
Last Closed: 2020-10-29 17:23:16 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Pavel Šimovec 2020-02-06 17:03:58 UTC
Description of problem:
Memory threshold change of C&U Data Collectors/Refresh Workers in UI does not work.

How reproducible:
Always on 5.11.2 (5.11.2.2.20200130212511_3ed31dc)

Steps to Reproduce:
1. Navigate to Configuration -> Settings -> (appliance) -> Workers
2. Change Refresh worker Memory threshold to 1.1 GB
3. Save the changes
4. Refresh the page

Actual results:
1.
2.
3.
4. Refresh worker memory threshold is 2 GB (previous value)

Expected results:
1.
2.
3.
4. Refresh worker memory threshold is 1.1 GB

Additional info:
Works in 5.10.14 (5.10.14.0.20200107223945_aa73a61)

1.
2.
3.
4. In AS (Advanced settings tab), names according to UI ones are:
UI: C & U Data Collectors  -> AS: ems_metrics_collector_worker
UI: Refresh -> AS: ems_refresh_worker

Action in UI created memory_threshold of ems_refresh_worker,
but memory threshold in :defaults is used and displayed in UI anyways.
In 5.10, change in UI changed the defaults memory_threshold value.
Changing that :defaults:memory_threshold value manually in Advanced Settings triggers the expected change in UI.

Snippet of Advanced Settings:
:ems_refresh_worker:
        :ems_refresh_worker_amazon: {}
        :ems_refresh_worker_amazon_network: {}
        ...
        :defaults:
          :memory_threshold: 2.gigabytes <-- this should be changed
          :nice_delta: 7
          :poll: 10.seconds
          :poll_method: :normal
          :queue_timeout: 120.minutes
          :dequeue_method: :sql
        ...
        :memory_threshold: 1.1.gigabytes <-- new created atribute (bug)

This applies for C & U Data Processors and Refresh on Workers page only, changes of memory thresholds of other Workers work as expected.

Comment 1 Dave Johnson 2020-02-06 19:01:34 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 5 CFME Bot 2020-02-14 09:56:10 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/e27a194038d5f2f53fe0c685d82e036f67c91e65
commit e27a194038d5f2f53fe0c685d82e036f67c91e65
Author:     Zita Nemeckova <znemecko>
AuthorDate: Thu Feb 13 14:40:43 2020 +0000
Commit:     Zita Nemeckova <znemecko>
CommitDate: Thu Feb 13 14:40:43 2020 +0000

    Fix saving of ems_refresh_worker and ems_metrics_collector_worker

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1799443

 app/javascript/components/workers-form/workers-form.jsx | 10 +-
 1 file changed, 7 insertions(+), 3 deletions(-)

Comment 7 dmetzger 2020-10-29 17:23:16 UTC
There will not be a 5.12.0 release of CloudForms AND this issue has been addressed in the 5.11 Errata stream, therefore I'm closing this ticket.


Note You need to log in before you can comment on or make changes to this bug.