Bug 1800533 - python-pingouin fails to build with Python 3.9: imports abc from collections
Summary: python-pingouin fails to build with Python 3.9: imports abc from collections
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Fedora
Classification: Fedora
Component: python-pingouin
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ankur Sinha (FranciscoD)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-02-07 11:32 UTC by Miro Hrončok
Modified: 2020-02-28 09:08 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-02-28 09:08:28 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github raphaelvallat pingouin pull 83 0 None closed Import ABC from collections.abc instead of collections for Python 3.9 compatibility. 2020-02-08 10:37:42 UTC

Description Miro Hrončok 2020-02-07 11:32:49 UTC
python-pingouin fails to build with Python 3.9.0a3:

>           x_is_iter = isinstance(x, collections.Iterable)
E           AttributeError: module 'collections' has no attribute 'Iterable'

See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The abstract base classes in collections.abc no longer are exposed in the regular collections module. This will help create a clearer distinction between the concrete classes and the abstract base classes."


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01223888-python-pingouin/

For all our attempts to build python-pingouin with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-pingouin/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karthikeyan Singaravelan 2020-02-07 18:54:09 UTC
Upstream PR : https://github.com/raphaelvallat/pingouin/pull/83

Comment 2 Ankur Sinha (FranciscoD) 2020-02-08 10:37:42 UTC
(In reply to Karthikeyan Singaravelan from comment #1)
> Upstream PR : https://github.com/raphaelvallat/pingouin/pull/83

Thanks very much, Karthikeyan!

Do you work with scientific/neuroscience software? If you do, would you like to join the SciTech/NeuroFedora SIGs? Lots of roles there, and we're happy to help you pick up the few Fedora specific skills you may need? :)

https://docs.fedoraproject.org/en-US/neurofedora/contributing/

Comment 3 Ben Cotton 2020-02-11 16:36:31 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 4 Miro Hrončok 2020-02-28 09:08:28 UTC
In Python 3.9.0a4 we have managed to revert the change that disables importing abstract base classes (collections.abc) directly form the regular collections module. It was reverted to ease transition for projects that did not yet actually dropped support for Python 2.7. The removal is scheduled for Python 3.10 instead.

We are mass closing all the bug reports about build failures that were caused by this. Expect a new Bugzilla report in case this package fails to build with Python 3.9 for a different reason as well.

In case you haven't done this already, we highly recommend to talk to your upstream and get this fixed anyway, because this will return in Python 3.10 and Python upstream is very unlikely to postpone this once more. In case you've already done that, thank you (this message is mass posted to all the relevant Bugzillas).


Note You need to log in before you can comment on or make changes to this bug.