Spec Name or Url: http://www.enlartenment.com/extras/geoip.spec SRPM Name or Url: http://www.enlartenment.com/extras/geoip-1.3.14-1.src.rpm Description: GeoIP is a C library that enables the user to find the country that any IP address or hostname originates from. It uses a file based database that is accurate as of March 2003. This database simply contains IP blocks as keys, and countries as values. This database should be more complete and accurate than using reverse DNS lookups.
NEEDSWORK Blockers: - Packaging of shared libs is messed up. What you call "superfluous symlinks" is essential. Non-Blockers: - The tarball is named GeoIP, therefore the rpm also should use this name. - Shipping static libs. You should ship shared libraries, instead (--disable-static) - You should append --disable-dependency-tracking to %configure to speed up building.
New spec and URL implementing the above suggestions: http://www.enlartenment.com/extras/GeoIP.spec http://www.enlartenment.com/extras/GeoIP-1.3.14-2.src.rpm Built OK for me in mock (Core 4), rpmlint seems mostly happy (some warnings re: the .so symlinks, but that's about all.)
(In reply to comment #2) > (some warnings re: > the .so symlinks, but that's about all.) This is a blocker, please fix (lib*.so must go to *-devel, lib*.so.* to non-devel) Also arguable: Obsoletes: geoip Provides: geoip This should probably be: Obsoletes: geoip < %{version}-%{release} Provides: geoip = %{version}-%{release} Also missing in the *-devel package: Provides: geoip-devel = %{version}-%{release} Alternatively, you could consider to drop supporting "geoip".
Another round o' SRPMS :-) http://www.enlartenment.com/extras/GeoIP.spec http://www.enlartenment.com/extras/GeoIP-1.3.14-3.src.rpm (In reply to comment #3) > (In reply to comment #2) > > (some warnings re: > > the .so symlinks, but that's about all.) > > This is a blocker, please fix (lib*.so must go to *-devel, lib*.so.* to non-devel) Done. > > > Also arguable: > Obsoletes: geoip > Provides: geoip > > This should probably be: > Obsoletes: geoip < %{version}-%{release} > Provides: geoip = %{version}-%{release} Done, with a similar pairing for -devel to ensure it's handled reasonably cleanly. > Also missing in the *-devel package: > Provides: geoip-devel = %{version}-%{release} > > Alternatively, you could consider to drop supporting "geoip". Doable, but given that both I and Rudolf Kastl have shipped packages as "geoip" in the past I felt it best to go with the above suggestions and give the user a clean upgrade path (working on the principle of least surprise) Michael.
APPROVED
Imported into CVS and a devel branch build kicked off.
Interesting, would something like this be useful to aid in smarter auto-mirror selection for yum?
Probably, I know the PHP devs use it for mirror selection so it's definitely possible. Would you like me to package up the Python bindings too? They're fairly small and would seem very appropriate. (I've got the Apache module submitted and have done the Perl bindings before, but that latter spec needs some *serious* love before I let reviewers rip into it.)
Python bindings would be very appropriate and useful. Apache module sounds useful too, but it should be a separate package. Perl is not too useful for Fedora specifically, but some people might like it.
(In reply to comment #9) > Python bindings would be very appropriate and useful. If these are a packaged as a separate add-on package, yes. Please file separate review request. > Apache module sounds > useful too, but it should be a separate package. Perl is not too useful for > Fedora specifically, but some people might like it. I love this kind of biased missionary statements. Perl might not be much of RH's interest (Yours), but it definitely is in Fedora Project's interest (e.g. mine).
(In reply to comment #10) > (In reply to comment #9) > > Python bindings would be very appropriate and useful. > If these are a packaged as a separate add-on package, yes. > Please file separate review request. Yes, I'll be making seperate requests once I'm satisfied they're sane and fit for Extras consumption. For GeoIP-Python, I'm running a local build of a quick spec built off the python template. It's not a huge package so should not take long to build (and hopefully review) > > Apache module sounds > > useful too, but it should be a separate package. Perl is not too useful for > > Fedora specifically, but some people might like it. > I love this kind of biased missionary statements. Perl might not be much of RH's > interest (Yours), but it definitely is in Fedora Project's interest (e.g. mine). I get the impression Warren was referring to it being of lesser interest to Fedora in the sense of the core package engineers / tools developers et. al - it would see less usage as a significant amount of "innards and internals" code (yum, anaconda etc.) is in Python rather than Perl. I'm sure it's useful to at least some Fedora / Extras users :-P My primary reason for mentioning it (GeoIP perl bindings) was as a nice complement to Extras' AWStats package - the geoip plugin uses it for more accurate country lookups, which I've got working quite nicely over here with minimal effort.
I seem to remember spamassassin could use something like the perl GeoIP bindings
Changing the summary for tracking purposes.