Bug 1801006 - OVN is not adhering to DHCP Broadcast Bit in DHCPDISCOVER and sending only unicast DHCPOFFER
Summary: OVN is not adhering to DHCP Broadcast Bit in DHCPDISCOVER and sending only un...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-networking-ovn
Version: 13.0 (Queens)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Ihar Hrachyshka
QA Contact: Eran Kuris
URL:
Whiteboard:
Depends On:
Blocks: 1811117 1811119 1812038
TreeView+ depends on / blocked
 
Reported: 2020-02-09 23:48 UTC by ldenny
Modified: 2023-09-07 21:47 UTC (History)
7 users (show)

Fixed In Version: ovn2.11-2.11.1-36.el7fdn ovn2.12-2.12.0-36.el7fdn
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1811117 1811119 (view as bug list)
Environment:
Last Closed: 2022-04-29 16:28:44 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker OSP-1389 0 None None None 2021-11-18 14:42:26 UTC

Description ldenny 2020-02-09 23:48:41 UTC
Description of problem:
The customer is attempting to start a Cisco IOS-XE CSR1000V router in a VM on OSP13. This router sends a DHCPREQUEST on an interface at boot. The Neutron subnet is configured for DHCP.

tcpdump at the VM's tap interface on the compute shows a DHCPDISCOVER broadcast exit the VM. "Flags [Broadcast]" is set.

OVN generates a DHCPOFFER, however the destination IP is unicast, back to Neutron's chosen IP address for the VM. It seems that this version of the router software cannot handle this case, and is unable to process the DHCPRESPONSE.

Version-Release number of selected component (if applicable):
RHOSP13, z9, OVN 2.9; update to z10 is planned in the immediate future. 

How reproducible:
Repeatedly. For VMs with more capable IP stacks this has not caused a problem.

Expected results:
1) Specify the IP broadcast address as the destination in all DHCPOFFER cases, or,
2) Adhere to the broadcast bit setting and use broadcast only if the bit is set.

Additional info:
I am not sure an update to z10 will resolve this - I have checked the upstream OVN code and verified that current master branch is still generating OVN logical flows that send unicast responses [1].

[1] https://github.com/ovn-org/ovn/blob/94ed4f6b433c26439d958965ee20497c2b32e4f9/northd/ovn-northd.c#L4256

Comment 2 Ihar Hrachyshka 2020-03-04 02:23:44 UTC
It's clear what's happening here: native DHCP responder doesn't honor the flag.

Fix posted here: https://patchwork.ozlabs.org/patch/1248736/

Comment 3 Ihar Hrachyshka 2020-03-07 02:31:51 UTC
The actual fix belongs to core OVN code. I've created two bugs for each relevant OVN major release:

2.11: https://bugzilla.redhat.com/show_bug.cgi?id=1811119
2.12: https://bugzilla.redhat.com/show_bug.cgi?id=1811117

This original bug is marked as TestOnly and should be validated in conjunction with the bugs listed above.

Comment 5 Lon Hohberger 2021-04-07 14:58:26 UTC
According to our records, this should be resolved by ovn2.11-2.11.1-57.el7fdp.  This build is available now.

Comment 7 Ihar Hrachyshka 2022-04-29 16:28:44 UTC
Closing this since QA will not test it in OSP scope and because the bug fix actually belonged to OVN, not OVN driver, and was already delivered.


Note You need to log in before you can comment on or make changes to this bug.