Bug 1801246 - python-jupyter-console fails to build with Python 3.9: base64.encodestring() was removed
Summary: python-jupyter-console fails to build with Python 3.9: base64.encodestring() ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-jupyter-console
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Elliott Sales de Andrade
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-02-10 14:00 UTC by Miro Hrončok
Modified: 2020-05-27 22:45 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-27 22:45:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2020-02-10 14:00:05 UTC
python-jupyter-console fails to build with Python 3.9.0a3.

======================================================================
ERROR: test_call_pil_by_default (jupyter_console.tests.test_image_handler.ZMQTerminalInteractiveShellTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/jupyter_console-6.1.0/jupyter_console/tests/test_image_handler.py", line 35, in setUp
    self.data = {self.mime: base64.encodestring(self.raw).decode('ascii')}
AttributeError: module 'base64' has no attribute 'encodestring'
======================================================================
ERROR: test_handle_image_PIL (jupyter_console.tests.test_image_handler.ZMQTerminalInteractiveShellTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/jupyter_console-6.1.0/jupyter_console/tests/test_image_handler.py", line 35, in setUp
    self.data = {self.mime: base64.encodestring(self.raw).decode('ascii')}
AttributeError: module 'base64' has no attribute 'encodestring'
======================================================================
ERROR: test_handle_image_callable (jupyter_console.tests.test_image_handler.ZMQTerminalInteractiveShellTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/jupyter_console-6.1.0/jupyter_console/tests/test_image_handler.py", line 35, in setUp
    self.data = {self.mime: base64.encodestring(self.raw).decode('ascii')}
AttributeError: module 'base64' has no attribute 'encodestring'
======================================================================
ERROR: test_handle_image_stream (jupyter_console.tests.test_image_handler.ZMQTerminalInteractiveShellTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/jupyter_console-6.1.0/jupyter_console/tests/test_image_handler.py", line 35, in setUp
    self.data = {self.mime: base64.encodestring(self.raw).decode('ascii')}
AttributeError: module 'base64' has no attribute 'encodestring'
======================================================================
ERROR: test_handle_image_tempfile (jupyter_console.tests.test_image_handler.ZMQTerminalInteractiveShellTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/jupyter_console-6.1.0/jupyter_console/tests/test_image_handler.py", line 35, in setUp
    self.data = {self.mime: base64.encodestring(self.raw).decode('ascii')}
AttributeError: module 'base64' has no attribute 'encodestring'
----------------------------------------------------------------------

See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"base64.encodestring() and base64.decodestring(), aliases deprecated since Python 3.1, have been removed: use base64.encodebytes() and base64.decodebytes() instead."


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01231296-python-jupyter-console/

For all our attempts to build python-jupyter-console with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-jupyter-console/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karthikeyan Singaravelan 2020-02-10 16:36:39 UTC
Upstream PR : https://github.com/jupyter/jupyter_console/pull/200

Comment 2 Ben Cotton 2020-02-11 16:32:39 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 3 Miro Hrončok 2020-05-25 13:02:31 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 4 Elliott Sales de Andrade 2020-05-27 22:45:25 UTC
This is built now:

https://koji.fedoraproject.org/koji/buildinfo?buildID=1512816


Note You need to log in before you can comment on or make changes to this bug.