Bug 1801297 - windows-10 VM memory validation is too low (0.5GiB) as seen from osinfo-db
Summary: windows-10 VM memory validation is too low (0.5GiB) as seen from osinfo-db
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: SSP
Version: 2.2.0
Hardware: Unspecified
OS: Unspecified
urgent
medium
Target Milestone: ---
: 2.3.0
Assignee: Karel Šimon
QA Contact: Ruth Netser
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-10 15:14 UTC by Kedar Bidarkar
Modified: 2020-06-04 07:26 UTC (History)
7 users (show)

Fixed In Version: kubevirt-ssp-operator-container-v2.3.0-19
Doc Type: If docs needed, set a value
Doc Text:
Introduced new windows 10 common template
Clone Of:
Environment:
Last Closed: 2020-05-04 19:10:37 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2020:2011 0 None None None 2020-05-04 19:10:49 UTC

Description Kedar Bidarkar 2020-02-10 15:14:44 UTC
Description of problem:

windows-10 VM memory validation is too low (0.5GiB) as seen from osinfo-db

Version-Release number of selected component (if applicable):

CNV2.2

template.kubevirt.io/version: v0.8.2
name: rhel8-server-tiny-v0.7.0

How reproducible:

Create a Windows 10 VM from the base templates


Steps to Reproduce:
1.
2.
3.

Actual results:

windows-10 VM memory validation is too low (0.5GiB) as seen from osinfo win-10.xml file


Expected results:

The minimum value as per the win-10.xml file.

<resources arch="x86_64">
      <minimum>
        <cpu>1000000000</cpu>
        <n-cpus>1</n-cpus>
        <ram>2147483648</ram>
        <storage>21474836480</storage>
      </minimum>


windows-10 VM memory validation needs to be 2GiB as seen from osinfo win-10.xml file


Probably have a separate template for Windows10 operating system??


Additional info:

Comment 1 Karel Šimon 2020-02-11 13:52:22 UTC
This is caused by fact, that windows template is taking data from win2k12r2 and minimum RAM memory for it is 0.5GiB. And because we have only one template for all windows versions, all windows versions have this value.
Fabian, what should be next steps (divide windows template for each version, or keep it as it is)?

Comment 2 Fabian Deutsch 2020-02-11 20:41:43 UTC
I'd take this bug as the opportunity to create a dedicated/new template for windows 10 with all the relevant defaults.

If all the other windows versions share the same defaults, then we can keep them in one template.

Comment 3 Karel Šimon 2020-02-12 10:23:19 UTC
This PR fixes it: https://github.com/kubevirt/common-templates/pull/128

Comment 4 Ruth Netser 2020-03-18 12:20:48 UTC
win2k12r2 templates are now deprecated (https://github.com/kubevirt/common-templates/pull/125)
There are new templates for Windows 10 (https://github.com/kubevirt/common-templates/pull/128)

Verified:
1. Minimum required memory matches https://gitlab.com/libosinfo/osinfo-db/-/blob/master/data/os/microsoft.com/win-10.xml.in#L126
2. Requested memory resources > minimum required


windows10-desktop-large-v0.7.0
    validations: |
      [
        {
          "name": "minimal-required-memory",
          "path": "jsonpath::.spec.domain.resources.requests.memory",
          "rule": "integer",
          "message": "This VM requires more memory.",
          "min": 2147483648
        }, {
          "name": "windows-virtio-bus",
            requests:
              memory: 8Gi
windows10-desktop-medium-v0.7.0
    validations: |
      [
        {
          "name": "minimal-required-memory",
          "path": "jsonpath::.spec.domain.resources.requests.memory",
          "rule": "integer",
          "message": "This VM requires more memory.",
          "min": 2147483648
        }, {
          "name": "windows-virtio-bus",
            requests:
              memory: 4Gi

Comment 9 Bob Gaydos 2020-04-27 15:59:33 UTC
Ruth, please QE Review the Release Note above and I'll include it in the build.

Thanks

Bob

Comment 11 Ruth Netser 2020-04-28 07:04:08 UTC
Reviewed and approved.

Comment 14 errata-xmlrpc 2020-05-04 19:10:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:2011


Note You need to log in before you can comment on or make changes to this bug.