Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1801321

Summary: Enable virtio-fs on s390x
Product: Red Hat Enterprise Linux Advanced Virtualization Reporter: Cornelia Huck <cohuck>
Component: qemu-kvmAssignee: Virtualization Maintenance <virt-maint>
qemu-kvm sub component: General QA Contact: virt-qe-z
Status: CLOSED DEFERRED Docs Contact:
Severity: high    
Priority: low CC: bugproxy, cohuck, dhildenb, dzheng, hannsj_uhl, jinzhao, juzhang, lcapitulino, qzhang, smitterl, thuth, virt-maint, zhenyzha
Version: 8.2Keywords: FutureFeature, Triaged
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.4   
Hardware: s390x   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-23 07:11:37 UTC Type: Feature Request
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1694164    
Bug Blocks: 1796871, 1857733    

Description Cornelia Huck 2020-02-10 16:17:06 UTC
To provide virtio-fs on s390x as well, the following changes are needed:

- add a virtio-ccw proxy device (analogous to the virtio-pci device)
- allow fd sharing to be configured on targets that do not support numa

This is to reach feature parity between architectures.

Comment 3 IBM Bug Proxy 2020-05-19 09:21:16 UTC
------- Comment From PASIC.com 2020-05-18 06:35 EDT-------
I have patches for:
and
was taken care of by Igor Mammedov.

The outstanding issue that prevents virtio-fs form working is libvhost-user does not do endianness properly. I spoke with Marc about this some time ago, and he showed some willingness to tackle this problem if I remember correctly. I will coordinate myself with Marc.

Comment 4 Cornelia Huck 2020-05-19 09:35:16 UTC
I'm afraid your comment did not come through correctly -- I assume you were saying that you have patches for adding the virtio-ccw proxy and that the fd sharing was taken care of by Igor?

The libvhost-user endianness problem is interesting; fixing this would probably be the last missing part as far as we know?

Comment 5 Hanns-Joachim Uhl 2020-05-19 09:37:04 UTC
(In reply to Cornelia Huck from comment #4)
> I'm afraid your comment did not come through correctly -- I assume you were
> saying that you have patches for adding the virtio-ccw proxy and that the fd
> sharing was taken care of by Igor?
> 
.
... yes, comment #3 has to read:
"
I have patches for:
- add a virtio-ccw proxy device (analogous to the virtio-pci device)
and 
- allow fd sharing to be configured on targets that do not support numa
was taken care of by Igor Mammedov.

The outstanding issue that prevents virtio-fs form working is libvhost-user does not do endianness properly. I spoke with Marc about this some time ago, and he showed some willingness to tackle this problem if I remember correctly. I will coordinate myself with Marc.
"
.
... sorry for the noise ...

Comment 6 IBM Bug Proxy 2020-05-19 11:31:34 UTC
------- Comment From PASIC.com 2020-05-19 07:20 EDT-------
(In reply to comment #6)

Yes.

after s/^-/*/
"""
* add a virtio-ccw proxy device (analogous to the virtio-pci device)
* allow fd sharing to be configured on targets that do not support numa

"""

> The libvhost-user endianness problem is interesting; fixing this would
> probably be the last missing part as far as we know?

Yes. Marc started working on it yesterday. Bluntly all virtioXX_to_cpu() type conversions are simply missing.

>
> (In reply to Cornelia Huck from comment #4)
> > I'm afraid your comment did not come through correctly -- I assume you were
> > saying that you have patches for adding the virtio-ccw proxy and that the fd
> > sharing was taken care of by Igor?
> >
> .
> ... yes, comment #3 has to read:
> "
> I have patches for:
> and
> was taken care of by Igor Mammedov.
>
> The outstanding issue that prevents virtio-fs form working is libvhost-user
> does not do endianness properly. I spoke with Marc about this some time ago,
> and he showed some willingness to tackle this problem if I remember
> correctly. I will coordinate myself with Marc.
> "
> .
> ... sorry for the noise ...

Comment 7 Hanns-Joachim Uhl 2020-05-19 11:43:34 UTC
oops ... the previous comment has to read:
"
(In reply to comment #6)
> ------- Comment From cohuck 2020-05-19 09:35:16 EDT-------
> I'm afraid your comment did not come through correctly -- I assume you were
> saying that you have patches for adding the virtio-ccw proxy and that the fd
> sharing was taken care of by Igor?
>

Yes.


after s/^-/*/
"""
I have patches for:
* add a virtio-ccw proxy device (analogous to the virtio-pci device)
and 
* allow fd sharing to be configured on targets that do not support numa
was taken care of by Igor Mammedov.

The outstanding issue that prevents virtio-fs form working is libvhost-user does not do endianness properly. I spoke with Marc about this some time ago, and he showed some willingness to tackle this problem if I remember correctly. I will coordinate myself with Marc.
"""
 
> The libvhost-user endianness problem is interesting; fixing this would
> probably be the last missing part as far as we know?

Yes. Marc started working on it yesterday. Bluntly all virtioXX_to_cpu() type conversions are simply missing.


> 
> ------- Comment From hannsj_uhl.com 2020-05-19 09:37:04 EDT-------
> (In reply to Cornelia Huck from comment #4)
> > I'm afraid your comment did not come through correctly -- I assume you were
> > saying that you have patches for adding the virtio-ccw proxy and that the fd
> > sharing was taken care of by Igor?
> >
> .
> ... yes, comment #3 has to read:
> "
> I have patches for:
> and
> was taken care of by Igor Mammedov.
> 
> The outstanding issue that prevents virtio-fs form working is libvhost-user
> does not do endianness properly. I spoke with Marc about this some time ago,
> and he showed some willingness to tackle this problem if I remember
> correctly. I will coordinate myself with Marc.
> "
> .
> ... sorry for the noise ...
"
...

Comment 8 IBM Bug Proxy 2020-06-25 10:31:42 UTC
------- Comment From MHartmay.com 2020-06-25 06:20 EDT-------
I sent an RFC to the QEMU mailing list:

https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg08133.html

Comment 9 Thomas Huth 2020-07-23 07:11:37 UTC
We'll likely get this feature via a rebase in RHEL-AV, so I'm closing this ticket now.