Hide Forgot
See https://github.com/openshift/builder/issues/129 Also produced on ocp install in addition to crc build.build.openshift.io/test-1 started Cloning "https://github.com/nginxinc/kubernetes-ingress" ... Commit: 65c0fefd20f88aa3832a56e17c4c4e263f54e1c1 (Ensure clean up in fixtures and fix condition) Author: tellet <tellet.tat@gmail.com> Date: Fri Feb 7 14:35:22 2020 +0100 Replaced Dockerfile FROM image base panic: assignment to entry in nil map goroutine 1 [running]: github.com/openshift/builder/vendor/github.com/openshift/imagebuilder.arg(0xc000152580, 0xc000828670, 0x1, 0x1, 0x0, 0x3375c98, 0x0, 0x0, 0xc0005a0750, 0x22, ...) /go/src/github.com/openshift/builder/vendor/github.com/openshift/imagebuilder/dispatchers.go:557 +0x234 github.com/openshift/builder/vendor/github.com/openshift/imagebuilder.(*Builder).Run(0xc000152580, 0xc000804d00, 0x1f6f3a0, 0x3375c98, 0x0, 0xc00068ee00, 0x10) /go/src/github.com/openshift/builder/vendor/github.com/openshift/imagebuilder/builder.go:324 +0xe5 github.com/openshift/builder/vendor/github.com/openshift/imagebuilder.(*Builder).extractHeadingArgsFromNode(0xc000152580, 0xc000705110, 0xc000781388, 0x14a3ccf) /go/src/github.com/openshift/builder/vendor/github.com/openshift/imagebuilder/builder.go:243 +0x341 github.com/openshift/builder/vendor/github.com/openshift/imagebuilder.NewStages(0xc000705110, 0xc000152580, 0xc0006c01c0, 0x1be4fe0, 0x1, 0x0, 0x1) /go/src/github.com/openshift/builder/vendor/github.com/openshift/imagebuilder/builder.go:201 +0x4d github.com/openshift/builder/pkg/build/builder.replaceImagesFromSource(0xc000705110, 0x0, 0x0, 0x0, 0x0, 0x0) /go/src/github.com/openshift/builder/pkg/build/builder/common.go:451 +0x1a6 github.com/openshift/builder/pkg/build/builder.addBuildParameters(0xc00051dc60, 0x11, 0xc000430000, 0xc000303040, 0x0, 0x0) /go/src/github.com/openshift/builder/pkg/build/builder/common.go:428 +0x35c github.com/openshift/builder/pkg/build/builder.ManageDockerfile(0xc00051dc60, 0x11, 0xc000430000, 0xc000474e80, 0x0) /go/src/github.com/openshift/builder/pkg/build/builder/source.go:123 +0x324 github.com/openshift/builder/pkg/build/builder/cmd.RunManageDockerfile(0x1f21280, 0xc000010020, 0x0, 0x0) /go/src/github.com/openshift/builder/pkg/build/builder/cmd/builder.go:411 +0xd6 main.NewCommandManageDockerfile.func1(0xc000708280, 0xc0007fbcb0, 0x0, 0x1) /go/src/github.com/openshift/builder/cmd/builder.go:118 +0x5c github.com/openshift/builder/vendor/github.com/spf13/cobra.(*Command).execute(0xc000708280, 0xc00000e090, 0x1, 0x1, 0xc000708280, 0xc00000e090) /go/src/github.com/openshift/builder/vendor/github.com/spf13/cobra/command.go:830 +0x2ae github.com/openshift/builder/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc000708280, 0x1b, 0xc000708280, 0x1b) /go/src/github.com/openshift/builder/vendor/github.com/spf13/cobra/command.go:914 +0x2fc github.com/openshift/builder/vendor/github.com/spf13/cobra.(*Command).Execute(...) /go/src/github.com/openshift/builder/vendor/github.com/spf13/cobra/command.go:864 main.main() /go/src/github.com/openshift/builder/cmd/main.go:68 +0x668
Reproduced with a unit test based on the Dockerfile and build config from https://github.com/openshift/builder/issues/129
Have fix in hand (one liner) ... just cleaning up / simplifying the unit test
Note to QE, we have a simplified reproducer: apiVersion: build.openshift.io/v1 kind: BuildConfig metadata: name: sample-build-docker-args-preset spec: source: dockerfile: |- FROM centos ARG foo=centos FROM $foo type: Dockerfile strategy: dockerStrategy: {} type: Docker which results in I0211 22:06:43.140914 1 builder.go:318] Starting Docker build from build config sample-build-docker-args-preset-17 ... F0211 22:06:43.209605 1 helpers.go:114] error: build error: error parsing name "$foo": error parsing image name "$foo": invalid reference format So at least the panic does not occur. Bug https://bugzilla.redhat.com/show_bug.cgi?id=1801875 has been opened against buildah so that we do not get F0211 22:06:43.209605 1 helpers.go:114] error: build error: error parsing name "$foo": error parsing image name "$foo": invalid reference format
Sorry one tweak to Ben's reproducer in #Comment 3 To get the panic, the dockerfile contents should just be ARG foo=centos FROM $foo The `FROM centos` was added to work around the panic in constructing a simple reproducer for https://bugzilla.redhat.com/show_bug.cgi?id=1801875
Thanks Gabe, I can reproduce the bug about Arg problem, and verified in 4.4.0-0.nightly-2020-02-13-192852 Steps: 1. Use bc to create build apiVersion: build.openshift.io/v1 kind: BuildConfig metadata: name: sample-build-docker-args-preset spec: source: dockerfile: |- ARG foo=ab FROM centos type: Dockerfile strategy: dockerStrategy: {} type: Docker 2. Using old cluster version,will have error http://pastebin.test.redhat.com/836101 3. Using the latest version, the error is fixed. [wewang@wangwen ~]$ oc get builds NAME TYPE FROM STATUS STARTED DURATION sample-build-docker-args-preset-1 Docker Dockerfile Complete 8 minutes ago 20s
FYI, About the following 2 scenarios still failed with "error: build error: error parsing name "$foo": error parsing image name "$foo": invalid reference format" in current latest cluster, will test them when https://bugzilla.redhat.com/show_bug.cgi?id=1801875 is fixed. Scenario 1: source: dockerfile: |- ARG foo=centos FROM $foo type: Dockerfile Scenario 2: dockerfile: |- FROM centos ARG foo=centos FROM $foo type: Dockerfile
Already had a bug to track about Comment 7: https://bugzilla.redhat.com/show_bug.cgi?id=1802202
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:0581