Spec URL: https://ankursinha.fedorapeople.org/mediawiki-lastmodified/mediawiki-lastmodified.spec SRPM URL: https://ankursinha.fedorapeople.org/mediawiki-lastmodified/mediawiki-lastmodified-0-0.1.20200210gitbe28231ebcd539fc99775811e5dc6df9064cfa94.fc32.src.rpm Description: The LastModified extension displays text on the page showing the last modified page time. Fedora Account System Username: ankursinha
I will take this review.
The binary package cannot be installed because of this line: Requires: mediawiki = 1.33 Rawhide currently has mediawiki 1.33.1, which does not satisfy this dependency.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ The failure is because this package requires mediawiki version 1.33, but version 1.33.1 is currently in Rawhide. - Remove the first line of %install: "rm -rf $RPM_BUILD_ROOT". See the 3rd bullet item here: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections - Please ask upstream to add a license file (SHOULD) - There have been 8 commits to the repository after the commit chosen for this package (regarding the "latest version" question in the SHOULD section) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. [x]: Package does not own files or directories owned by other packages. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.4.21 starting (python version = 3.7.6)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.21 INFO: Mock Version: 1.4.21 Finish: chroot init INFO: installing package(s): /home/jjames/1801464-mediawiki-lastmodified/results/mediawiki-lastmodified-0-0.1.20200210gitbe28231ebcd539fc99775811e5dc6df9064cfa94.fc32.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 32 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/jjames/1801464-mediawiki-lastmodified/results/mediawiki-lastmodified-0-0.1.20200210gitbe28231ebcd539fc99775811e5dc6df9064cfa94.fc32.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: mediawiki-lastmodified-0-0.1.20200210gitbe28231ebcd539fc99775811e5dc6df9064cfa94.fc32.noarch.rpm mediawiki-lastmodified-0-0.1.20200210gitbe28231ebcd539fc99775811e5dc6df9064cfa94.fc32.src.rpm mediawiki-lastmodified.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Source checksums ---------------- https://github.com/wikimedia/mediawiki-extensions-LastModified/archive/be28231ebcd539fc99775811e5dc6df9064cfa94/mediawiki-lastmodified-be28231.tar.gz : CHECKSUM(SHA256) this package : f8625088f46d7448afaf014e30f2e6a634ea76930612f70a22352848f1c88c24 CHECKSUM(SHA256) upstream package : f8625088f46d7448afaf014e30f2e6a634ea76930612f70a22352848f1c88c24 Requires -------- mediawiki-lastmodified (rpmlib, GLIBC filtered): mediawiki Provides -------- mediawiki-lastmodified: mediawiki-lastmodified Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -b 1801464 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: PHP, Perl, Haskell, R, Python, Ocaml, SugarActivity, Java, fonts, C/C++, Ruby Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for the quick review, Jerry. (In reply to Jerry James from comment #3) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > - Package installs properly. > Note: Installation errors (see attachment) > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ > > The failure is because this package requires mediawiki version 1.33, but > version 1.33.1 is currently in Rawhide. Fixed. I got the Requires wrong. > > - Remove the first line of %install: "rm -rf $RPM_BUILD_ROOT". See the 3rd > bullet item here: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections Removed > > - Please ask upstream to add a license file (SHOULD) I'll do that. They don't include it in the source tree either, so I'll have to sign up for their gerrit instance and so on. > > - There have been 8 commits to the repository after the commit chosen for > this package (regarding the "latest version" question in the SHOULD > section) > Ah, no---the plugin is linked to the mediawiki version. Since rawhide has 1.33, I'm packaging the latest commit in the REL_1_33 branch here: https://github.com/wikimedia/mediawiki-extensions-LastModified/tree/REL1_33 I've noted that in the spec for clarity also. I've also added back the js files. I looked at the mediawiki package, and the extensions it ships do include these. Updated spec/srpm: Spec URL: https://ankursinha.fedorapeople.org/mediawiki-lastmodified/mediawiki-lastmodified.spec SRPM URL: https://ankursinha.fedorapeople.org/mediawiki-lastmodified/mediawiki-lastmodified-0-0.1.20200210gitbe28231ebcd539fc99775811e5dc6df9064cfa94.fc31.src.rpm
I like the new comments. Everything looks good now. This package is APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mediawiki-lastmodified
Built for rawhide, and stable releases. Closing. (Bodhi sometimes hangs when updating bugs for me, so not specifying the bug there for the moment).