Bug 180149 - Review Request: edje: A complex graphical design and layout library
Summary: Review Request: edje: A complex graphical design and layout library
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
(Show other bugs)
Version: rawhide
Hardware: All Linux
medium
medium
Target Milestone: ---
Assignee: Christian Iseli
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Keywords:
Depends On: 180052 180058 180102
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-02-06 10:34 UTC by Ignacio Vazquez-Abrams
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-04-27 17:51:41 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

Description Ignacio Vazquez-Abrams 2006-02-06 10:34:50 UTC
Spec Name or Url: http://fedora.ivazquez.net/files/extras/edje.spec
SRPM Name or Url: http://fedora.ivazquez.net/files/extras/edje-0.5.0.023-1.src.rpm
Description: Edje is a complex graphical design & layout library. Its purpose is to be a sequel to "Ebits" which to date has serviced the needs of Enlightenment development for version 0.17. The original design parameters under which Ebits came about were a lot more restricted than the resulting use of them, thus Edje was born.

Comment 1 Jason Tibbitts 2006-02-06 20:19:22 UTC
Why does bug 180056 (system-config-httpd references obsolete module names) block
this?

Comment 2 Ignacio Vazquez-Abrams 2006-02-07 01:10:15 UTC
Because I'm blind.

Comment 3 Ignacio Vazquez-Abrams 2006-04-18 16:42:22 UTC
Updated.

http://fedora.ivazquez.net/files/extras/edje-0.5.0.026-1.src.rpm

Comment 4 Christian Iseli 2006-04-20 22:02:21 UTC
Good:
- rpmlint is ok
- name ok
- spec name ok
- packaging guidelines met
- license ok
- license matches actual license in package
- license file in %doc
- spec file in American English and legible
- source matches upstream
- builds, installs, runs, and uninstalls cleanly
- BuildRequires ok
- no locale to worry about
- shared libs ok
- -devel package ok
- no relocation to worry about
- no duplicated files
- files perms ok
- clean section ok
- macro useage ok
- package contains code
- no large doc
- %doc is only doc
- builds in mock

My machines here still run FC4, so I didn't check if the code actualy runs...
but I'll trust you on this one.

Why the empty %doc in the devel package ?

I think %{_datadir}/%{name}/ is more explicit than %{_datadir}/%{name}
but that's a matter of taste I guess...

rpmlint says:
E: edje non-executable-script /usr/share/edje/data/template/build_theme.sh 0644
E: edje non-executable-script /usr/share/edje/data/e_logo.sh 0644

W: edje-devel no-documentation

which I think can be ignored.

APPROVED.

Comment 5 Ignacio Vazquez-Abrams 2006-04-27 17:51:41 UTC
Built on FC5 and devel.


Note You need to log in before you can comment on or make changes to this bug.