Spec URL: https://jvanek.fedorapeople.org/tagsoup/tagsoup.spec SRPM URL: https://jvanek.fedorapeople.org/tagsoup/tagsoup-1.2.1-src.zip Description: TagSoup is a SAX-compliant parser written in Java that, instead of parsing well-formed or valid XML, parses HTML as it is found in the wild: nasty and brutish, though quite often far from short. TagSoup is designed for people who have to process this stuff using some semblance of a rational application design. By providing a SAX interface, it allows standard XML tools to be applied to even the worst HTML. Fedora Account System Username: jvanek tagsoup was orphaned three months ago, and retired six weeks ago. This review to put it back is based on latests bits. I will maintain it, as icedtea-web is only one eyed without it
Spec URL: https://jvanek.fedorapeople.org/tagsoup/tagsoup.spec SRPM URL: https://jvanek.fedorapeople.org/tagsoup/tagsoup-1.2.1-18.fc32.src.rpm builds and run fine on f32/master
Self review run at: https://jvanek.fedorapeople.org/tagsoup/self-review/
This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - This seems like a Java package, please install fedora-review-plugin-java to get additional checks - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/tagsoup See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License (v2.0)", "Apache License (v2.0)", "Apache License", "Apache License (v2.0) GPL (v2 or later)". 8 files have unknown license. Detailed output of licensecheck in /home/jvanek/git/tagsoup/master/1802153-tagsoup/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/javadoc/tagsoup(Failed, locale,, set, C, defaulting, to), /usr/share/javadoc/tagsoup/org(Failed, locale,, set, C, defaulting, to), /usr/share/javadoc/tagsoup/org/ccil(Failed, locale,, set, C, defaulting, to), /usr/share/javadoc/tagsoup/org/ccil/cowan(Failed, locale,, set, C, defaulting, to), /usr/share/javadoc/tagsoup/org/ccil/cowan/tagsoup(Failed, locale,, set, C, defaulting, to), /usr/share/javadoc/tagsoup/org/ccil/cowan/tagsoup/class-use(Failed, locale,, set, C, defaulting, to), /usr/share/javadoc/tagsoup/org/ccil/cowan/tagsoup/jaxp(Failed, locale,, set, C, defaulting, to), /usr/share/javadoc/tagsoup/org/ccil/cowan/tagsoup/jaxp/class- use(Failed, locale,, set, C, defaulting, to), /usr/share/licenses/tagsoup-javadoc(Failed, locale,, set, C, defaulting, to), /usr/share/doc/tagsoup(Failed, locale,, set, C, defaulting, to), /usr/share/licenses/tagsoup(Failed, locale,, set, C, defaulting, to) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: tagsoup-1.2.1-18.fc32.noarch.rpm tagsoup-javadoc-1.2.1-18.fc32.noarch.rpm tagsoup-1.2.1-18.fc32.src.rpm tagsoup.noarch: W: file-not-utf8 /usr/share/doc/tagsoup/README 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). tagsoup.noarch: W: invalid-url URL: http://vrici.lojban.org/~cowan/XML/tagsoup/ <urlopen error [Errno -2] Name or service not known> tagsoup.noarch: W: file-not-utf8 /usr/share/doc/tagsoup/README tagsoup-javadoc.noarch: W: invalid-url URL: http://vrici.lojban.org/~cowan/XML/tagsoup/ <urlopen error [Errno -2] Name or service not known> 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Source checksums ---------------- https://repo1.maven.org/maven2/org/ccil/cowan/tagsoup/tagsoup/1.2.1/tagsoup-1.2.1.pom : CHECKSUM(SHA256) this package : 5e3acd4da65e4e443178b3aacaa708e65435916dad16c4fe1e73b5ecfb388a77 CHECKSUM(SHA256) upstream package : 5e3acd4da65e4e443178b3aacaa708e65435916dad16c4fe1e73b5ecfb388a77 http://vrici.lojban.org/~cowan/XML/tagsoup/tagsoup-1.2.1-src.zip : CHECKSUM(SHA256) this package : fe4bb031f2c62461337afe81f8f70df463dc5edb39bd4145c002f6d10a891ece CHECKSUM(SHA256) upstream package : fe4bb031f2c62461337afe81f8f70df463dc5edb39bd4145c002f6d10a891ece Requires -------- tagsoup (rpmlib, GLIBC filtered): java-headless javapackages-filesystem tagsoup-javadoc (rpmlib, GLIBC filtered): javapackages-filesystem jpackage-utils Provides -------- tagsoup: mvn(org.ccil.cowan.tagsoup:tagsoup) mvn(org.ccil.cowan.tagsoup:tagsoup:pom:) tagsoup tagsoup-javadoc: tagsoup-javadoc Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -b 1802153 Buildroot used: fedora-rawhide-x86_64 Active plugins: Java, Generic, Shell-api Disabled plugins: Python, C/C++, Perl, PHP, R, fonts, Ocaml, SugarActivity, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://koji.fedoraproject.org/koji/taskinfo?taskID=41490627