Bug 1802993 (rust-getch) - Review Request: rust-getch - Portable implementation of getch, using _getch on Windows, and termios on Unix
Summary: Review Request: rust-getch - Portable implementation of getch, using _getch o...
Keywords:
Status: CLOSED RAWHIDE
Alias: rust-getch
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Artem
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-14 09:47 UTC by Igor Raits
Modified: 2020-02-18 11:12 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-02-18 11:12:11 UTC
Type: ---
Embargoed:
ego.cordatus: fedora-review+

Attachments (Terms of Use)

Description Igor Raits 2020-02-14 09:47:00 UTC 
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-getch.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-getch-0.2.1-1.fc33.src.rpm
Description:
Portable implementation of getch, using _getch on Windows, and termios on Unix.
Fedora Account System Username: ignatenkobrain
Comment 1 Artem 2020-02-18 10:34:56 UTC 
No license files here. We need to ask upstream to add them into crates.io.
Comment 2 Igor Raits 2020-02-18 10:38:31 UTC 
(In reply to Artem from comment #1)
> No license files here. We need to ask upstream to add them into crates.io.

If you know way of doing that - welcome.

# * Upstream is on pijul

There is basically no way of doing anything with upstream.
Comment 3 Artem 2020-02-18 10:53:22 UTC 
OK, LGTM. :) We can ask upstream by email.

Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

Package approved.
Comment 4 Igor Raits 2020-02-18 10:59:22 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-getch
Note You need to log in before you can comment on or make changes to this bug.