Description of problem:

Deploying overcloud with Instance HA nodes fails at Step 1 of deployment on task [Wait for puppet host configuration to finish].

Here is the failure logs from ansible task:

~~~
fatal: [overcloud-novacomputeiha-0]: FAILED! => {"ansible_job_id": "875698817172.16185", "attempts": 3, "changed": true, "cmd": "set -o pipefail; puppet apply  --modulepath=/etc/puppet/modules:/opt/stack/puppet-modules:/usr/share/openstack-puppet/modules --detailed-exitcodes --summarize --color=false   /var/lib/tripleo-config/puppet_step_config.pp 2>&1 | logger -s -t puppet-user", "delta": "0:00:06.350740", "end": "2020-02-15 12:37:23.924572", "failed_when_result": true, "finished": 1, "msg": "non-zero return code", "rc": 1, "start": "2020-02-15 12:37:17.573832", "stderr": "<13>Feb 15 12:37:17 puppet-user: Warning: The function 'hiera' is deprecated in favor of using 'lookup'. See https://puppet.com/docs/puppet/5.5/deprecated_language.html\\n   (file & line not available)\n<13>Feb 15 12:37:22 puppet-user: Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5\n<13>Feb 15 12:37:22 puppet-user:    (file: /etc/puppet/hiera.yaml)\n<13>Feb 15 12:37:22 puppet-user: Warning: Undefined variable '::deploy_config_name'; \\n   (file & line not available)\n<13>Feb 15 12:37:22 puppet-user: Warning: ModuleLoader: module 'tripleo' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)\n<13>Feb 15 12:37:23 puppet-user: Warning: Unknown variable: '::deployment_type'. (file: /etc/puppet/modules/tripleo/manifests/profile/base/database/mysql/client.pp, line: 89, column: 8)\n<13>Feb 15 12:37:23 puppet-user: Warning: ModuleLoader: module 'pacemaker' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)\n<13>Feb 15 12:37:23 puppet-user: Warning: Unknown variable: '::pacemaker::pcsd_sysconfig'. (file: /etc/puppet/modules/pacemaker/manifests/remote.pp, line: 90, column: 20)\n<13>Feb 15 12:37:23 puppet-user: Warning: ModuleLoader: module 'concat' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)\n<13>Feb 15 12:37:23 puppet-user: Warning: tag is a metaparam; this value will inherit to all contained resources in the tripleo::firewall::rule definition\n<13>Feb 15 12:37:23 puppet-user: Notice: Scope(Class[Tripleo::Firewall::Post]): At this stage, all network traffic is blocked.\n<13>Feb 15 12:37:23 puppet-user: Notice: Compiled catalog for overcloud-novacomputeiha-0.localdomain in environment production in 0.95 seconds\n<13>Feb 15 12:37:23 puppet-user: Error: Validation of File_line[pcsd_bind_addr] failed: path is a required attribute (file: /etc/puppet/modules/pacemaker/manifests/remote.pp, line: 89)", "stderr_lines": ["<13>Feb 15 12:37:17 puppet-user: Warning: The function 'hiera' is deprecated in favor of using 'lookup'. See https://puppet.com/docs/puppet/5.5/deprecated_language.html\\n   (file & line not available)", "<13>Feb 15 12:37:22 puppet-user: Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5", "<13>Feb 15 12:37:22 puppet-user:    (file: /etc/puppet/hiera.yaml)", "<13>Feb 15 12:37:22 puppet-user: Warning: Undefined variable '::deploy_config_name'; \\n   (file & line not available)", "<13>Feb 15 12:37:22 puppet-user: Warning: ModuleLoader: module 'tripleo' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)", "<13>Feb 15 12:37:23 puppet-user: Warning: Unknown variable: '::deployment_type'. (file: /etc/puppet/modules/tripleo/manifests/profile/base/database/mysql/client.pp, line: 89, column: 8)", "<13>Feb 15 12:37:23 puppet-user: Warning: ModuleLoader: module 'pacemaker' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)", "<13>Feb 15 12:37:23 puppet-user: Warning: Unknown variable: '::pacemaker::pcsd_sysconfig'. (file: /etc/puppet/modules/pacemaker/manifests/remote.pp, line: 90, column: 20)", "<13>Feb 15 12:37:23 puppet-user: Warning: ModuleLoader: module 'concat' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)", "<13>Feb 15 12:37:23 puppet-user: Warning: tag is a metaparam; this value will inherit to all contained resources in the tripleo::firewall::rule definition", "<13>Feb 15 12:37:23 puppet-user: Notice: Scope(Class[Tripleo::Firewall::Post]): At this stage, all network traffic is blocked.", "<13>Feb 15 12:37:23 puppet-user: Notice: Compiled catalog for overcloud-novacomputeiha-0.localdomain in environment production in 0.95 seconds", "<13>Feb 15 12:37:23 puppet-user: Error: Validation of File_line[pcsd_bind_addr] failed: path is a required attribute (file: /etc/puppet/modules/pacemaker/manifests/remote.pp, line: 89)"], "stdout": "", "stdout_lines": []}


2020-02-15 07:37:25,127 p=8615 u=mistral |  fatal: [overcloud-novacomputeiha-1]: FAILED! => {"ansible_job_id": "560289393545.16173", "attempts": 3, "changed": true, "cmd": "set -o pipefail; puppet apply  --modulepath=/etc/puppet/modules:/opt/stack/puppet-modules:/usr/share/openstack-puppet/modules --detailed-exitcodes --summarize --color=false   /var/lib/tripleo-config/puppet_step_config.pp 2>&1 | logger -s -t puppet-user", "delta": "0:00:06.625584", "end": "2020-02-15 12:37:24.338205", "failed_when_result": true, "finished": 1, "msg": "non-zero return code", "rc": 1, "start": "2020-02-15 12:37:17.712621", "stderr": "<13>Feb 15 12:37:17 puppet-user: Warning: The function 'hiera' is deprecated in favor of using 'lookup'. See https://puppet.com/docs/puppet/5.5/deprecated_language.html\\n   (file & line not available)\n<13>Feb 15 12:37:23 puppet-user: Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5\n<13>Feb 15 12:37:23 puppet-user:    (file: /etc/puppet/hiera.yaml)\n<13>Feb 15 12:37:23 puppet-user: Warning: Undefined variable '::deploy_config_name'; \\n   (file & line not available)\n<13>Feb 15 12:37:23 puppet-user: Warning: ModuleLoader: module 'tripleo' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)\n<13>Feb 15 12:37:23 puppet-user: Warning: Unknown variable: '::deployment_type'. (file: /etc/puppet/modules/tripleo/manifests/profile/base/database/mysql/client.pp, line: 89, column: 8)\n<13>Feb 15 12:37:23 puppet-user: Warning: ModuleLoader: module 'pacemaker' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)\n<13>Feb 15 12:37:23 puppet-user: Warning: Unknown variable: '::pacemaker::pcsd_sysconfig'. (file: /etc/puppet/modules/pacemaker/manifests/remote.pp, line: 90, column: 20)\n<13>Feb 15 12:37:23 puppet-user: Warning: ModuleLoader: module 'concat' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)\n<13>Feb 15 12:37:24 puppet-user: Warning: tag is a metaparam; this value will inherit to all contained resources in the tripleo::firewall::rule definition\n<13>Feb 15 12:37:24 puppet-user: Notice: Scope(Class[Tripleo::Firewall::Post]): At this stage, all network traffic is blocked.\n<13>Feb 15 12:37:24 puppet-user: Notice: Compiled catalog for overcloud-novacomputeiha-1.localdomain in environment production in 0.96 seconds\n<13>Feb 15 12:37:24 puppet-user: Error: Validation of File_line[pcsd_bind_addr] failed: path is a required attribute (file: /etc/puppet/modules/pacemaker/manifests/remote.pp, line: 89)", "stderr_lines": ["<13>Feb 15 12:37:17 puppet-user: Warning: The function 'hiera' is deprecated in favor of using 'lookup'. See https://puppet.com/docs/puppet/5.5/deprecated_language.html\\n   (file & line not available)", "<13>Feb 15 12:37:23 puppet-user: Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5", "<13>Feb 15 12:37:23 puppet-user:    (file: /etc/puppet/hiera.yaml)", "<13>Feb 15 12:37:23 puppet-user: Warning: Undefined variable '::deploy_config_name'; \\n   (file & line not available)", "<13>Feb 15 12:37:23 puppet-user: Warning: ModuleLoader: module 'tripleo' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)", "<13>Feb 15 12:37:23 puppet-user: Warning: Unknown variable: '::deployment_type'. (file: /etc/puppet/modules/tripleo/manifests/profile/base/database/mysql/client.pp, line: 89, column: 8)", "<13>Feb 15 12:37:23 puppet-user: Warning: ModuleLoader: module 'pacemaker' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)", "<13>Feb 15 12:37:23 puppet-user: Warning: Unknown variable: '::pacemaker::pcsd_sysconfig'. (file: /etc/puppet/modules/pacemaker/manifests/remote.pp, line: 90, column: 20)", "<13>Feb 15 12:37:23 puppet-user: Warning: ModuleLoader: module 'concat' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\\n   (file & line not available)", "<13>Feb 15 12:37:24 puppet-user: Warning: tag is a metaparam; this value will inherit to all contained resources in the tripleo::firewall::rule definition", "<13>Feb 15 12:37:24 puppet-user: Notice: Scope(Class[Tripleo::Firewall::Post]): At this stage, all network traffic is blocked.", "<13>Feb 15 12:37:24 puppet-user: Notice: Compiled catalog for overcloud-novacomputeiha-1.localdomain in environment production in 0.96 seconds", "<13>Feb 15 12:37:24 puppet-user: Error: Validation of File_line[pcsd_bind_addr] failed: path is a required attribute (file: /etc/puppet/modules/pacemaker/manifests/remote.pp, line: 89)"], "stdout": "", "stdout_lines": []}
~~~

The prime error is: puppet-user: Error: Validation of File_line[pcsd_bind_addr] failed: path is a required attribute (file: /etc/puppet/modules/pacemaker/manifests/remote.pp, line: 89)"], "stdout": "", "stdout_lines": []}

Running puppet-apply manually on ComputeIHA nodes does confirm the same.

puppet apply  --modulepath=/etc/puppet/module$:/opt/stack/puppet-modules:/usr/share/openstack-puppet/modules --detailed-exitcodes --summarize --color=false   /var/lib/tripleo-config/puppet_step_config.pp
Warning: The function 'hiera' is deprecated in favor of using 'lookup'. See https://puppet.com/docs/puppet/5.5/deprecated_language.html\n   (file & line not available)
Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5
   (file: /etc/puppet/hiera.yaml)
Warning: Undefined variable '::deploy_config_name'; \n   (file & line not available)
Warning: ModuleLoader: module 'tripleo' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\n   (file & line not available)
Warning: Unknown variable: '::deployment_type'. (file: /usr/share/openstack-puppet/modules/tripleo/manifests/profile/base/database/mysql/client.pp, line: 89, column: 8)
Warning: ModuleLoader: module 'pacemaker' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\n   (file & line not available)
Warning: Unknown variable: '::pacemaker::pcsd_sysconfig'. (file: /usr/share/openstack-puppet/modules/pacemaker/manifests/remote.pp, line: 90, column: 20)
Warning: ModuleLoader: module 'concat' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\n   (file & line not available)
Warning: tag is a metaparam; this value will inherit to all contained resources in the tripleo::firewall::rule definition
Notice: Scope(Class[Tripleo::Firewall::Post]): At this stage, all network traffic is blocked.
Notice: Compiled catalog for overcloud-novacomputeiha-1.localdomain in environment production in 0.65 seconds
Error: Validation of File_line[pcsd_bind_addr] failed: path is a required attribute (file: /usr/share/openstack-puppet/modules/pacemaker/manifests/remote.pp, line: 89)

Looks like an issue with puppet-pacemaker package.

Version-Release number of selected component (if applicable):

rpm -qa |grep -i puppet-triple
puppet-tripleo-11.4.1-0.20200118215809.6f9bf6c.el8ost.noarch
rpm -qa |grep -i puppet-pacemaker
puppet-pacemaker-0.8.1-0.20191218041139.80dcc19.el8ost.noarch


How reproducible:
Deploy overcloud with IHA compute nodes.

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
Deployment should succeed.

Additional info: