Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1804147

Summary:	[ovirt] oVirt API token doesn't get renewed if the session is expired
Product:	OpenShift Container Platform	Reporter:	Roy Golan <rgolan>
Component:	Cloud Compute	Assignee:	Alberto <agarcial>
Status:	CLOSED NOTABUG	QA Contact:	Jianwei Hou <jhou>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.4	CC:	agarcial, jhou
Target Milestone:	---
Target Release:	4.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1803821	Environment:
Last Closed:	2020-02-18 10:51:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1803821
Bug Blocks:

Description Roy Golan 2020-02-18 10:26:20 UTC

+++ This bug was initially created as a clone of Bug #1803821 +++

cluster-api-provider-ovirt creates an api connection to ovirt and caches it. When that
connection is invalid, for example after ovirt restarted its engine and clears the session, then
the controller will not be able to get the status of the VMs, or to create/delete VMs.

There is a Test() method to check the api connection, but it seems like it is not really testing the connection and the auth status.
https://github.com/openshift/cluster-api-provider-ovirt/blob/c29232e3f4ed98e65626e27e82084a499103165e/pkg/cloud/ovirt/machine/actuator.go#L66

The Test() method from the go-ovirt sdk was fixed here https://github.com/oVirt/ovirt-engine-sdk-go/pull/197

The vendored version of go-ovirt needs to be bumped.

Comment 1 Roy Golan 2020-02-18 10:51:13 UTC

cherry pick not needed.