Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1804253

Summary:	Block cluster version update if the cluster contains affinity labels with old behavior enabled
Product:	[oVirt] ovirt-engine	Reporter:	Andrej Krejcir <akrejcir>
Component:	Backend.Core	Assignee:	Lucia Jelinkova <ljelinko>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Polina <pagranat>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.4.0	CC:	ahadas, bugs, mavital, mtessun
Target Milestone:	ovirt-4.4.2	Flags:	pm-rhel: ovirt-4.4+ mtessun: planning_ack+ ahadas: devel_ack+ mavital: testing_ack+
Target Release:	4.4.2.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.4.2.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-09-18 07:12:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Andrej Krejcir 2020-02-18 14:30:52 UTC

Description of problem:

Since cluster version 4.4, the affinity labels no longer support the old behavior. All labels are switched to the new behavior. This change could surprise users, if they still use labels with old behavior and update the cluster version. There is no warning message or information in the log.

The cluster version update should be blocked, or at least a warning can be shown, if the cluster contains affinity labels with enabled old behavior.

As a related change, it may make sense to add a config value that specifies if the old behavior is allowed or not. Currently it is hard-coded to be allowed only for versions up to 4.3.


Version-Release number of selected component (if applicable):
ovirt-engine 4.4


Steps to Reproduce:
1. Have cluster with compatibility version 4.3
2. Add an affinity label with the "Implicit affinity group" enabled.
3. Update the cluster to version 4.4


Actual results:
No indication that the affinity label was updated and now the "Implicit affinity group" is ignored.


Expected results:
Block the cluster version update until the user changes the affinity labels and groups as necessary, and disables the implicit affinity group.
Or at least display a warning message, that the labels will be changed and the affinity will probably not behave as expected.

Comment 1 Ryan Barry 2020-02-19 02:12:15 UTC

Leaving untargeted until we speak to PM, as discussed.

We will eventually want to remove this code, and now is a good time IMO

Comment 2 Martin Tessun 2020-03-06 13:53:30 UTC

(In reply to Ryan Barry from comment #1)
> Leaving untargeted until we speak to PM, as discussed.
> 
> We will eventually want to remove this code, and now is a good time IMO

Even if we remove the code, we still need to check this with existing upgrades. We can of course "simply document" this and have customers checking on their own, but I would prefer having some kind of notification (even if it is within the upgrade logs only) that shows the customer things have changed.

We can avoid some confusion with this.

Comment 3 Polina 2020-08-17 12:03:50 UTC

verified on ovirt-engine-4.4.2.1-0.15.el8ev.noarch

steps:
1. In setup 4.4 create new 4_3 DC, cluster 4_3,  install a host 4.3, create SD , import infra template latest-rhel-guest-image-7.8-infra , create VMs.
2. In Clusters/cluster 4_3/Edit/Affinity Labels create Affinity Labels with the VM and host_4.3 and coose the 'Implicit Affinity Group' option.
3. Then Try to update the Cluter compatibility version from 4.3 to 4.4

Brings "Error while executing action: Cannot edit Cluster. Implicit affinity groups are not supported in cluster version 4.4 and above. Please update/remove affinity labels with the implicit affinity groups."

4. Fix the Affinity Labels removing the implicit option for legacy behavior and try to update the version again - success.

Comment 4 Sandro Bonazzola 2020-09-18 07:12:46 UTC

This bugzilla is included in oVirt 4.4.2 release, published on September 17th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.