Bug 1804268 - ovirt-engine-metrics role fails on ansible-linter
Summary: ovirt-engine-metrics role fails on ansible-linter
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-metrics
Classification: oVirt
Component: Generic
Version: 1.3.0
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ovirt-4.5.0
: 1.5.0
Assignee: Aviv Litman
QA Contact: Guilherme Santos
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-18 15:13 UTC by Liran Rotenberg
Modified: 2022-04-20 06:33 UTC (History)
3 users (show)

Fixed In Version: ovirt-engine-metrics-1.5.0
Clone Of:
Environment:
Last Closed: 2022-04-20 06:33:59 UTC
oVirt Team: Metrics
Embargoed:
sbonazzo: ovirt-4.5+


Attachments (Terms of Use)
related compile log (5.81 KB, text/plain)
2020-02-18 15:13 UTC, Liran Rotenberg
no flags Details
new log (10.79 KB, text/plain)
2020-06-18 12:56 UTC, Liran Rotenberg
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github oVirt ovirt-engine-metrics pull 14 0 None open WIP: Add ansible-lint, and adjust the role accordingly 2022-02-03 09:44:29 UTC
Red Hat Issue Tracker RHV-38027 0 None None None 2021-10-21 13:26:11 UTC

Description Liran Rotenberg 2020-02-18 15:13:11 UTC
Created attachment 1663771 [details]
related compile log

Description of problem:
When having the ovirt repo and trying to compile the compiling failing, making it impossible to run ovirt development environment.
This is caused by ansible-linter which is part of automation/check-patch.packages  

Version-Release number of selected component (if applicable):
ovirt-engine-metrics-1.4.0-0.0.master.20200112124743.git98c2b03.fc29.noarch
python3-ansible-lint-4.1.0-1.fc30.noarch

How reproducible:
100%

Steps to Reproduce:
1. Have a master repo of ovirt
2. Install the ansible-lint (part of automation/check-patch.packages)
3. Run make install-dev ...

Actual results:
Compilation fails

Expected results:
Compilation succeed

Additional info:
Workaround is to remove the python3-ansible-lint.

Comment 1 Martin Perina 2020-03-18 14:17:45 UTC
I don't understand one thing, ansible-linter is executed only against ansible-roles included within ovirt-engine repository, how did it get to check separate ovirt-engine-metrics project?

Comment 2 Liran Rotenberg 2020-03-18 14:29:51 UTC
(In reply to Martin Perina from comment #1)
> I don't understand one thing, ansible-linter is executed only against
> ansible-roles included within ovirt-engine repository, how did it get to
> check separate ovirt-engine-metrics project?

No idea to be honest. I'm not that familiar with it.
I do see the path the linter is checking is not within ovirt-engine which is strange.
My only guess how it's possible is due dependency in pom.xml (maven or under ~/.m2) it also run on other locations - if it makes any sense.
The compilation was made for example with:
$ make install-dev PREFIX=$HOME/ovirt-engine DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=safari" -j8

Comment 3 Martin Necas 2020-06-18 12:09:36 UTC
I was not able to reproduce it. I have installed the ansible-lint and tried your command.
It is really strange that the engine would check the ovirt-engine-metrics.
Could you please try it once again? It is possible that I have missed something.

Comment 4 Liran Rotenberg 2020-06-18 12:56:58 UTC
Created attachment 1697962 [details]
new log

Reproduced on fc30.
ovirt-engine-metrics-1.4.2-0.0.master.20200609165747.git4bcfb4f.fc30.noarch
ovirt-ansible-roles-1.2.3-1.fc30.noarch
python3-ansible-lint-4.1.0-1.fc30.noarch

I ran:
$ make install-dev PREFIX=$HOME/ovirt-engine DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=safari" -j8
on master branch of ovirt-engine.

If it works for other platforms, it might be fc30 specific.

Comment 5 Martin Necas 2020-06-18 13:57:21 UTC
It is possible I'm on el8.

ovirt-engine-metrics-1.4.2-0.0.master.20200609165805.git4bcfb4f.el8.noarch
ovirt-ansible-roles-1.2.3-1.el8.noarch
python3-ansible-lint-4.1.0-2.el8.noarch

Run the same command once again and no issues.

Not sure if I should keep the issue open.

Comment 7 Martin Perina 2020-06-18 15:17:04 UTC
Ahh, it's specific ovirt-engine-metrics role, which is an optional for dev env installation. Moving the bug to Shirly, this needs to be addressed within the role

Comment 8 Sandro Bonazzola 2022-04-20 06:33:59 UTC
This bugzilla is included in oVirt 4.5.0 release, published on April 20th 2022.

Since the problem described in this bug report should be resolved in oVirt 4.5.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.