Bug 1804268
| Summary: | ovirt-engine-metrics role fails on ansible-linter | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine-metrics | Reporter: | Liran Rotenberg <lrotenbe> | ||||||
| Component: | Generic | Assignee: | Aviv Litman <alitman> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Guilherme Santos <gdeolive> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | 1.3.0 | CC: | bugs, gdeolive, mperina | ||||||
| Target Milestone: | ovirt-4.5.0 | Keywords: | CodeChange, ZStream | ||||||
| Target Release: | 1.5.0 | Flags: | sbonazzo:
ovirt-4.5+
|
||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | ovirt-engine-metrics-1.5.0 | Doc Type: | No Doc Update | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2022-04-20 06:33:59 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | Metrics | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
I don't understand one thing, ansible-linter is executed only against ansible-roles included within ovirt-engine repository, how did it get to check separate ovirt-engine-metrics project? (In reply to Martin Perina from comment #1) > I don't understand one thing, ansible-linter is executed only against > ansible-roles included within ovirt-engine repository, how did it get to > check separate ovirt-engine-metrics project? No idea to be honest. I'm not that familiar with it. I do see the path the linter is checking is not within ovirt-engine which is strange. My only guess how it's possible is due dependency in pom.xml (maven or under ~/.m2) it also run on other locations - if it makes any sense. The compilation was made for example with: $ make install-dev PREFIX=$HOME/ovirt-engine DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=safari" -j8 I was not able to reproduce it. I have installed the ansible-lint and tried your command. It is really strange that the engine would check the ovirt-engine-metrics. Could you please try it once again? It is possible that I have missed something. Created attachment 1697962 [details]
new log
Reproduced on fc30.
ovirt-engine-metrics-1.4.2-0.0.master.20200609165747.git4bcfb4f.fc30.noarch
ovirt-ansible-roles-1.2.3-1.fc30.noarch
python3-ansible-lint-4.1.0-1.fc30.noarch
I ran:
$ make install-dev PREFIX=$HOME/ovirt-engine DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="-Dgwt.userAgent=safari" -j8
on master branch of ovirt-engine.
If it works for other platforms, it might be fc30 specific.
It is possible I'm on el8. ovirt-engine-metrics-1.4.2-0.0.master.20200609165805.git4bcfb4f.el8.noarch ovirt-ansible-roles-1.2.3-1.el8.noarch python3-ansible-lint-4.1.0-2.el8.noarch Run the same command once again and no issues. Not sure if I should keep the issue open. Ahh, it's specific ovirt-engine-metrics role, which is an optional for dev env installation. Moving the bug to Shirly, this needs to be addressed within the role This bugzilla is included in oVirt 4.5.0 release, published on April 20th 2022. Since the problem described in this bug report should be resolved in oVirt 4.5.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |
Created attachment 1663771 [details] related compile log Description of problem: When having the ovirt repo and trying to compile the compiling failing, making it impossible to run ovirt development environment. This is caused by ansible-linter which is part of automation/check-patch.packages Version-Release number of selected component (if applicable): ovirt-engine-metrics-1.4.0-0.0.master.20200112124743.git98c2b03.fc29.noarch python3-ansible-lint-4.1.0-1.fc30.noarch How reproducible: 100% Steps to Reproduce: 1. Have a master repo of ovirt 2. Install the ansible-lint (part of automation/check-patch.packages) 3. Run make install-dev ... Actual results: Compilation fails Expected results: Compilation succeed Additional info: Workaround is to remove the python3-ansible-lint.