Created attachment 1664014 [details] ja_JP_text_alignment Description of problem: The text alignment on administration -> configure -> instance type -> add page for ja_JP locale needs to be corrected. On the resource allocation tab, there is option for 'Memory Balloon Device Enabled'. For equivalent ja_JP string, the last character is falling on the new line. Please refer attached screenshot. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Bhushan, can you please attach screenshot for the instance type->add page?
Hi Sharon, The screen-shot is available in the attachments section.
Created attachment 1700129 [details] Screenshot of the Japanese locale
Created attachment 1700130 [details] Screenshot of the English locale
I've simulated the issue but in my case the word wrapping looks a little bit different. Actually, it looks very similar to English locale (see attachments). Although you can see there is quite a lot of space in the dialog, fixing it is not as simple as setting widget's width. The Instance type dialog is the same as the VM edit dialog, only some widgets are hidden. Memory balloon is instance type field, it has the special instance type widget next to it in the VM dialog. To keep all the special instance type widgets aligned in the dialog, the widget's width is restricted. I can see 2 options: 1. Accept the fact that there are many fields, locales, browsers, fonts and that not all fields would be aligned in one line 2. Increase the width of the popup dialog - 30px should be enough for the English locale, it should fix also the author's layout but not my Japanese layout (I needed to increase width by 120px to align it to one line). Note that this could break layout of other wrapped fields in the dialog.
(In reply to Lucia Jelinkova from comment #5) > I can see 2 options: > 1. Accept the fact that there are many fields, locales, browsers, fonts and > that not all fields would be aligned in one line > 2. Increase the width of the popup dialog - 30px should be enough for the > English locale, it should fix also the author's layout but not my Japanese > layout (I needed to increase width by 120px to align it to one line). Note > that this could break layout of other wrapped fields in the dialog. Yeah, I wouldn't go with changing the width of the popup dialog considering the possible implications of that. Would it make any difference for the Japanese translation if we omit the 'Device' part?
(In reply to Arik from comment #6) > (In reply to Lucia Jelinkova from comment #5) > > I can see 2 options: > > 1. Accept the fact that there are many fields, locales, browsers, fonts and > > that not all fields would be aligned in one line > > 2. Increase the width of the popup dialog - 30px should be enough for the > > English locale, it should fix also the author's layout but not my Japanese > > layout (I needed to increase width by 120px to align it to one line). Note > > that this could break layout of other wrapped fields in the dialog. > > Yeah, I wouldn't go with changing the width of the popup dialog considering > the possible implications of that. > > Would it make any difference for the Japanese translation if we omit the > 'Device' part? May be Yuko can answer this part well regarding Japanese translation.
Thanks Bhushan for checking with me. I think it is the best if the width of the dialog can be increased. Otherwise, you might be able to reword it "enable memory ballooning" (instead of just removing the word "device" from the string) The translation is "メモリーバルーニングを有効にする" Could this fit in the space?
We have similar cases like: VirtIO-SCSI Enabled I/O Threads Enabled Multi Queues enabled So I wouldn't rule out "Memory Balloon/Ballooning Enabled" Seems like with that change the translation is more likely to fit into a single line
Please let me know if you would like to change the Japanese translation in Zanata.
Lucia, what do you think about this approach?
I like Memory Ballooning Enabled label because it is consistent with the rest of the page. However, I'll not be able to verify since my fonts display a little bit differently than Bhushan's.
(In reply to Yuko Katabami from comment #10) > Please let me know if you would like to change the Japanese translation in > Zanata. Yes, let's change the Japanese translation in Zanata please
I've applied the change to Japanese translation in Zanata at: https://zanata.phx.ovirt.org/project/view/ovirt-engine Please let me know if there is anything else I can help you.
Created attachment 1718519 [details] Issue is still present, the last character is still falling on the new line Tested on version 4.4.3.5-0.5, the last character is still falling on the new line. Seems like the corrected translation (as per comment 14) is not merged in this version. As per my understanding, the UI available in this version has the string as "メモリーバルーンデバイスを有効にする" whereas the actual translation source has string as "メモリーバルーニングを有効にする".
Created attachment 1718520 [details] string comparison String comparison between version 4.4.3.5-0.5 UI and https://zanata.phx.ovirt.org/project/view/ovirt-engine
Created attachment 1718521 [details] String comparison String comparison between version 4.4.3.5-0.5 UI and https://zanata.phx.ovirt.org/project/view/ovirt-engine
Sharon, who takes care to synchronize the translations from zanata to the build?
(In reply to Arik from comment #18) > Sharon, who takes care to synchronize the translations from zanata to the > build? The UX team takes care of that. Scott, can you please sync the Japanese engine translations as part of https://gerrit.ovirt.org/111239 or do you prefer to update it on a separate patch?
(In reply to Sharon Gratch from comment #19) > (In reply to Arik from comment #18) > > Sharon, who takes care to synchronize the translations from zanata to the > > build? > > The UX team takes care of that. > Scott, can you please sync the Japanese engine translations as part of > https://gerrit.ovirt.org/111239 or do you prefer to update it on a separate > patch? I will update the translation pull on patch 111239 and reference this BZ.
Only the key "memoryBalloonDeviceEnabled" in CommonApplicationConstants_ja_JP.properties has been updated.
Moving back to POST being https://gerrit.ovirt.org/#/c/111239/ still being reviewed and not merged yet.
https://gerrit.ovirt.org/#/c/111239/ is merged
Steps: 1) Open AdminPortal with ja_JP locale 2) Go to Administration -> Configure -> Instance Types -> New -> Resource Allocation 3) Check that the Memory Ballooning Enabled translation isn't falling into a new line Results: The translation for Memory Ballooning Enabled is on one line. Verified in: ovirt-engine-webadmin-portal-4.4.3.8-0.1.el8ev.noarch ovirt-engine-4.4.3.8-0.1.el8ev.noarch firefox-82.0-4.fc31.x86_64
This bugzilla is included in oVirt 4.4.3 release, published on November 10th 2020. Since the problem described in this bug report should be resolved in oVirt 4.4.3 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.