Spec URL: https://jgrulich.fedorapeople.org/plasma-thunderbolt/plasma-thunderbolt.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma-thunderbolt/plasma-thunderbolt-5.18.1-1.fc31.src.rpm Description: Plasma Sytem Settings module and a KDED module to handle authorization of Thunderbolt devices connected to the computer. There's also a shared library (libkbolt) that implements common interface between the modules and the system-wide bolt daemon, which does the actual hard work of talking to the kernel. Fedora Account System Username: jgrulich
This should be everything. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Fix compiler flags. You might want to use %make_build and %make_install See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags - There are license issues. One of the files has a different license, I have attached a report. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/ - Libraries do not follow naming conventions. I think the ones under qt5/plugins are fine, but I don't think that libkbolt is ok. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning - libkbolt should be a subpackage See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_mixed_use_packages - Consider adding readme to %doc See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/kpackage/kcms/kcm_bolt See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License", "GNU General Public License (v2)". 82 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/qt5/plugins/kcms, /usr/lib64/qt5/plugins/kf5/kded [!]: %build honors applicable compiler flags or justifies otherwise. Note: Use %{optflags} [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines Note: See issues section [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. Note: v5.18.2 is available [x]: Package does not include license text files separate from upstream. [?]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: plasma-thunderbolt-5.18.1-1.fc33.x86_64.rpm plasma-thunderbolt-debuginfo-5.18.1-1.fc33.x86_64.rpm plasma-thunderbolt-debugsource-5.18.1-1.fc33.x86_64.rpm plasma-thunderbolt-5.18.1-1.fc33.src.rpm plasma-thunderbolt.x86_64: W: spelling-error %description -l en_US libkbolt -> bobolink plasma-thunderbolt.x86_64: E: invalid-soname /usr/lib64/libkbolt.so libkbolt.so plasma-thunderbolt.x86_64: W: no-documentation plasma-thunderbolt.src: W: spelling-error %description -l en_US libkbolt -> bobolink 4 packages and 0 specfiles checked; 1 errors, 3 warnings. Rpmlint (debuginfo) ------------------- Checking: plasma-thunderbolt-debuginfo-5.18.1-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). plasma-thunderbolt-debuginfo.x86_64: W: invalid-url URL: https://cgit.kde.org/plasma-thunderbolt.git <urlopen error [Errno -2] Name or service not known> plasma-thunderbolt.x86_64: W: spelling-error %description -l en_US libkbolt -> bobolink plasma-thunderbolt.x86_64: W: invalid-url URL: https://cgit.kde.org/plasma-thunderbolt.git <urlopen error [Errno -2] Name or service not known> plasma-thunderbolt.x86_64: E: invalid-soname /usr/lib64/libkbolt.so libkbolt.so plasma-thunderbolt.x86_64: W: no-documentation plasma-thunderbolt-debugsource.x86_64: W: invalid-url URL: https://cgit.kde.org/plasma-thunderbolt.git <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 1 errors, 5 warnings. Unversioned so-files -------------------- plasma-thunderbolt: /usr/lib64/libkbolt.so plasma-thunderbolt: /usr/lib64/qt5/plugins/kcms/kcm_bolt.so plasma-thunderbolt: /usr/lib64/qt5/plugins/kf5/kded/kded_bolt.so Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1804683 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Java, Ocaml, Haskell, PHP, Python, Perl, SugarActivity, fonts, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Created attachment 1667998 [details] license report
- Fix compiler flags. You might want to use %make_build and %make_install See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags → Fixed - There are license issues. One of the files has a different license, I have attached a report. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/ → Fixed - Libraries do not follow naming conventions. I think the ones under qt5/plugins are fine, but I don't think that libkbolt is ok. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning - libkbolt should be a subpackage See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_mixed_use_packages → Won't fix, libkbolt is a QML plugin, it's not meant to be used outside plasma-thunderbolt. - Consider adding readme to %doc See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation → Fixed - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ → Fixed - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. → Won't fix, it's a service file for a KCM module, not for an application, it won't pass the validation - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/kpackage/kcms/kcm_bolt See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files → Fixed
Spec URL: https://jgrulich.fedorapeople.org/plasma-thunderbolt/plasma-thunderbolt.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma-thunderbolt/plasma-thunderbolt-5.18.2-1.fc32.src.rpm
> - Libraries do not follow naming conventions. I think the ones under qt5/plugins are fine, but I don't think that libkbolt is ok. > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning > - libkbolt should be a subpackage > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_mixed_use_packages > > → Won't fix, libkbolt is a QML plugin, it's not meant to be used outside plasma-thunderbolt. Sorry, I didn't notice the "this is not needed" exception for plugins in the guidelines. I tried to find other kcm plugins putting libraries under /usr/lib. I was only able to find kde-connect, which does version it's lib. https://src.fedoraproject.org/rpms/kde-connect/blob/master/f/kde-connect.spec#_161 > - Package installs a %{name}.desktop using desktop-file-install or desktop- > file-validate if there is such a file. > → Won't fix, it's a service file for a KCM module, not for an application, it won't pass the validation metadata.desktop passes validation with desktop-file-validate perfectly fine on my system. Approved. None of these blockers, but I still encourage you to ask upstream to version the lib.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-thunderbolt