Bug 1804766
| Summary: | login.defs man page has incorrect information for login(1) | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Lark Gordon <lagordon> |
| Component: | shadow-utils | Assignee: | Iker Pedrosa <ipedrosa> |
| Status: | CLOSED ERRATA | QA Contact: | shridhar <sgadekar> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 8.4 | CC: | ccheney, dapospis, dlavu, kzak, rdulhani, sgadekar |
| Target Milestone: | rc | Keywords: | Triaged |
| Target Release: | 8.0 | Flags: | pm-rhel:
mirror+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | sync-to-jira qetodo | ||
| Fixed In Version: | shadow-utils-4.6-12.el8 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-05-18 14:59:58 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Well, I think login(1) man page from util-linux is correct and contains only valid information ;-) The problem is login.defs(5) man page where are all very commonly used options. Unfortunately, not all of the options are usable/valid. The config file login.defs is not login(1) specific, it's used by more tools. IMHO it would be enough to add to the beginning of the login.defs(5) man page a warning "This man page is generic and some of the options may be unsupported by currently installed tools. For example see login(1) for login specific options, etc.". After reviewing it my proposal would be to include the following in login.defs description: Please also take into account that this man page is generic and some of the options may be unsupported by currently installed tools. In case of doubt check the section called “CROSS REFERENCES” and the section called “SEE ALSO”. For example see login(1) for login specific options such as LOGIN_STRING. What do you think? It needs to be discussed but my idea is to include the fix proposed in comment 3 in RHEL8.4. Checked with:
shadow-utils-4.6-12
]# rpm -Uvh shadow-utils-4.6-12.el8.x86_64.rpm
Verifying... ################################# [100%]
Preparing... ################################# [100%]
Updating / installing...
1:shadow-utils-2:4.6-12.el8 ################################# [ 50%]
Cleaning up / removing...
2:shadow-utils-2:4.6-11.el8 ################################# [100%]
]# man login.defs
<snip>
Please also take into account that this man page is generic and some of the options may be unsupported by currently installed tools. In case of doubt check the section called “CROSS REFERENCES” and
the section called “SEE ALSO”. For example see login(1) for login specific options such as LOGIN_STRING.
</snip>
Marking verified.
d]# rpm -q shadow-utils
shadow-utils-4.6-12.el8.x86_64
]# man login.defs
<snip>
Please also take into account that this man page is generic and some of the options may be unsupported by currently installed tools. In case of doubt check the section called “CROSS REFERENCES” and
the section called “SEE ALSO”. For example see login(1) for login specific options such as LOGIN_STRING.
The following configuration items are provided:
</snip>
marking verified.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (shadow-utils bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2021:1650 |
Description of problem: The login man page for util-linux references the option "LOGIN_STRING", which is not available in the version of login that we ship. How reproducible: this issue appears in the manpage for RHEL 7 and 8. Additional info: It appears LOGIN_STRING isn't used at all. The login.defs config file, the man page for it, and a login binary come from shadow-utils source. We don't actually ship the login binary that is in shadow-utils source, but we do ship the other files. A login binary also exists in the util-linux source, without the corresponding login.defs or login.defs man page, and that is what we actually ship for the binary. The login binary that is in util-linux does not support LOGIN_STRING at all. You can see where the shadow-utils login version is removed during the build stage so it doesn't ship in the rpm. shadow-utils.spec:rm $RPM_BUILD_ROOT/%{_bindir}/login 'man login', which comes from util-linux, includes the valid login.defs variables so possibly just removing the login.defs man page from shadow-utils would be enough.