Bug 1804768 - Review Request: catatonit - A signal-forwarding process manager for containers
Summary: Review Request: catatonit - A signal-forwarding process manager for containers
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jindrich Novy
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-19 15:20 UTC by Lokesh Mandvekar
Modified: 2020-05-08 04:00 UTC (History)
11 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-05-08 02:44:22 UTC
Type: ---
Embargoed:
jnovy: fedora-review+


Attachments (Terms of Use)

Description Lokesh Mandvekar 2020-02-19 15:20:21 UTC
Spec URL: https://pagure.io/catatonit/blob/master/f/catatonit.spec
SRPM URL: https://pagure.io/catatonit/blob/master/f/SRPMS/catatonit-0.1.4-1.src.rpm

Description:
Catatonit is a /sbin/init program for use within containers. It
forwards (almost) all signals to the spawned child, tears down
the container when the spawned child exits, and otherwise
cleans up other exited processes (zombies).

This is a reimplementation of other container init programs (such as
"tini" or "dumb-init"), but uses modern Linux facilities (such as
signalfd(2)) and has no additional features.

Fedora Account System Username: lsm5

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=41654500

Comment 1 Olivier Samyn 2020-02-19 16:25:25 UTC
Once this is accepted, I suppose a patch to the podman package will be needed to depend on this one.

Comment 2 Daniel Walsh 2020-02-21 15:43:39 UTC
Make sure it is a Recommends not a Requires.

Comment 3 Jindrich Novy 2020-02-27 14:49:09 UTC
Looking at this in the spec:
---
# Make sure we *always* build a static binary. Otherwise we'll break containers
	
# that don't have the necessary shared libs.
	
file ./%{name} | grep 'statically linked'
---

Suggest to provide some human readable message in the build log: Why this has to be statically linked. Then the spec comment is then not required.

FYI: The src.rpm link in the description doesn't work.

Comment 4 Lokesh Mandvekar 2020-04-29 09:29:17 UTC
Spec URL: https://pagure.io/catatonit/blob/master/f/catatonit.spec
SRPM URL: https://pagure.io/catatonit/blob/master/f/SRPMS/catatonit-0.1.5-1.fc32.src.rpm

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43891594

Jindrich, I'll post the SRPM somewhere else if this still doesn't work.

Comment 6 Jindrich Novy 2020-04-29 11:05:57 UTC
LGTM. Thanks Lokesh!

Comment 7 Gwyn Ciesla 2020-04-29 13:28:28 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/catatonit

Comment 8 Fedora Update System 2020-04-29 14:19:17 UTC
FEDORA-2020-f8f80a3c1c has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f8f80a3c1c

Comment 9 Fedora Update System 2020-04-29 14:28:20 UTC
FEDORA-2020-9aeddd91c6 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9aeddd91c6

Comment 10 Fedora Update System 2020-04-30 04:13:35 UTC
FEDORA-2020-f8f80a3c1c has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f8f80a3c1c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f8f80a3c1c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2020-04-30 04:58:52 UTC
FEDORA-2020-9aeddd91c6 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-9aeddd91c6 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9aeddd91c6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2020-05-08 02:44:22 UTC
FEDORA-2020-f8f80a3c1c has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2020-05-08 04:00:16 UTC
FEDORA-2020-9aeddd91c6 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.