Description of problem:

ksh shell invoked as login shell, 'which' command gives error: "-ksh: declare: not found"

Version-Release number of selected component (if applicable):

ksh-20120801-252.el8.x86_64

How reproducible:

Always


Steps to Reproduce:

1. Add new user "test" with default login shell as "ksh"

     # useradd test -s /bin/ksh

2. Switch to user "test"

     # su - test

3. Execute the "which" command with any binary

     $ which less

Actual results:

$ which less
-ksh: declare: not found
/usr/bin/less

Expected results:

$ which less
/usr/bin/less

Additional info:

[1] When switching to "test" user, I observed that "echo $0" shows "-ksh" 

     # su - test
     $ echo $0
     -ksh

[2] Now when checked /etc/profile.d/which2.sh, observed the if loop only checks for "$0" = ksh" and hence else is executed stating "-ksh: declare: not found"

[3] Here is the /etc/profile.d/which2.sh file content:

# cat /etc/profile.d/which2.sh
# Initialization script for bash and sh

if [ "$0" = ksh ] ; then
  alias which='(alias; typeset -f) | /usr/bin/which --tty-only --read-alias --read-functions --show-tilde --show-dot'
else
  alias which='(alias; declare -f) | /usr/bin/which --tty-only --read-alias --read-functions --show-tilde --show-dot'
fi


[4] Now when the above file is modified(changed if condition), getting expected results.

# cat /etc/profile.d/which2.sh
# Initialization script for bash and sh

if [ "$0" = -ksh ] ; then
  alias which='(alias; typeset -f) | /usr/bin/which --tty-only --read-alias --read-functions --show-tilde --show-dot'
else
  alias which='(alias; declare -f) | /usr/bin/which --tty-only --read-alias --read-functions --show-tilde --show-dot'
fi