Spec URL: https://deamn.fedorapeople.org/maven-native.spec SRPM URL: https://deamn.fedorapeople.org/maven-native-1.0-0.17.alpha.8.fc31.src.rpm Description: Maven Native - compile C and C++ source under Maven with compilers such as GCC, MSVC, GCJ etc ... Fedora Account System Username: deamn
Please fix download urls: https://repo1.maven.org/maven2/org/codehaus/mojo/natives/maven-native/1.0-alpha-8/maven-native-1.0-alpha-8-source-release.zip Also there is newer version: https://repo1.maven.org/maven2/org/codehaus/mojo/natives/maven-native/1.0-alpha-9/ In addition, on github is much nwer version. https://github.com/mojohaus/maven-native/releases/tag/maven-native-1.0-alpha-11 Please use https://github.com/mojohaus/maven-native/ as URL and fully qualified url for sources. I would chose the maven repo for them anyway. Maybe split %build's %mvn_build -f -s -- -Dmojo.java.target=1.7 -Dmaven.test.failure.ignore=true to %build ad %check? Fedora review failed for me after build: NoneType: None 02-20 11:21 root DEBUG is_installed: Tested maven-native, result: 1 02-20 11:21 root DEBUG is_installed: Tested maven-native-javadoc, result: 1 02-20 11:21 root DEBUG is_installed: Tested native-maven-plugin, result: 1 02-20 11:21 root DEBUG Exception down the road... Traceback (most recent call last): File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 236, in run self._do_run(outfile) File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 226, in _do_run self._do_report(outfile) File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 99, in _do_report self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile) File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", line 117, in _run_checks self.checks.run_checks(output=output, writedown=not Settings.no_report) File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 382, in run_checks run_check(name) File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 357, in run_check check.run() File "/usr/lib/python3.7/site-packages/FedoraReview/plugins/generic_build.py", line 282, in run output = Mock.install(rpms) File "/usr/lib/python3.7/site-packages/FedoraReview/mock.py", line 496, in install rpms = [p for p in set(packages) if is_not_installed(p)] File "/usr/lib/python3.7/site-packages/FedoraReview/mock.py", line 496, in <listcomp> rpms = [p for p in set(packages) if is_not_installed(p)] File "/usr/lib/python3.7/site-packages/FedoraReview/mock.py", line 487, in is_not_installed if self.is_installed(p): File "/usr/lib/python3.7/site-packages/FedoraReview/mock.py", line 408, in is_installed rc = call(cmd, shell=True) File "/usr/lib64/python3.7/subprocess.py", line 341, in call return p.wait(timeout=timeout) File "/usr/lib64/python3.7/subprocess.py", line 1019, in wait return self._wait(timeout=timeout) File "/usr/lib64/python3.7/subprocess.py", line 1653, in _wait (pid, sts) = self._try_wait(0) File "/usr/lib64/python3.7/subprocess.py", line 1611, in _try_wait (pid, sts) = os.waitpid(self.pid, wait_flags) KeyboardInterrupt 02-20 11:21 root ERROR Exception down the road... (logs in /home/jvanek/.cache/fedora-review.log) 02-20 11:21 root DEBUG Report completed: 95.832 seconds However manual install passed fine, and maual investigation of rpmslooked fine. Please fix what is possible. If fedora-review will remainbroken, I will do it manually.
(In reply to jiri vanek from comment #1) > Please fix download urls: > https://repo1.maven.org/maven2/org/codehaus/mojo/natives/maven-native/1.0- > alpha-8/maven-native-1.0-alpha-8-source-release.zip > Also there is newer version: > https://repo1.maven.org/maven2/org/codehaus/mojo/natives/maven-native/1.0- > alpha-9/ > In addition, on github is much nwer version. > https://github.com/mojohaus/maven-native/releases/tag/maven-native-1.0-alpha- > 11 > > Please use https://github.com/mojohaus/maven-native/ as URL and fully > qualified url for sources. I would chose the maven repo for them anyway. > > Maybe split %build's > %mvn_build -f -s -- -Dmojo.java.target=1.7 > -Dmaven.test.failure.ignore=true > to %build ad %check? > > > Fedora review failed for me after build: > NoneType: None > 02-20 11:21 root DEBUG is_installed: Tested maven-native, result: > 1 > 02-20 11:21 root DEBUG is_installed: Tested maven-native-javadoc, > result: 1 > 02-20 11:21 root DEBUG is_installed: Tested native-maven-plugin, > result: 1 > 02-20 11:21 root DEBUG Exception down the road... > Traceback (most recent call last): > File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", > line 236, in run > self._do_run(outfile) > File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", > line 226, in _do_run > self._do_report(outfile) > File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", > line 99, in _do_report > self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile) > File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py", > line 117, in _run_checks > self.checks.run_checks(output=output, writedown=not Settings.no_report) > File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 382, > in run_checks > run_check(name) > File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 357, > in run_check > check.run() > File > "/usr/lib/python3.7/site-packages/FedoraReview/plugins/generic_build.py", > line 282, in run > output = Mock.install(rpms) > File "/usr/lib/python3.7/site-packages/FedoraReview/mock.py", line 496, in > install > rpms = [p for p in set(packages) if is_not_installed(p)] > File "/usr/lib/python3.7/site-packages/FedoraReview/mock.py", line 496, in > <listcomp> > rpms = [p for p in set(packages) if is_not_installed(p)] > File "/usr/lib/python3.7/site-packages/FedoraReview/mock.py", line 487, in > is_not_installed > if self.is_installed(p): > File "/usr/lib/python3.7/site-packages/FedoraReview/mock.py", line 408, in > is_installed > rc = call(cmd, shell=True) > File "/usr/lib64/python3.7/subprocess.py", line 341, in call > return p.wait(timeout=timeout) > File "/usr/lib64/python3.7/subprocess.py", line 1019, in wait > return self._wait(timeout=timeout) > File "/usr/lib64/python3.7/subprocess.py", line 1653, in _wait > (pid, sts) = self._try_wait(0) > File "/usr/lib64/python3.7/subprocess.py", line 1611, in _try_wait > (pid, sts) = os.waitpid(self.pid, wait_flags) > KeyboardInterrupt > 02-20 11:21 root ERROR Exception down the road... (logs in > /home/jvanek/.cache/fedora-review.log) > 02-20 11:21 root DEBUG Report completed: 95.832 seconds > > > However manual install passed fine, and maual investigation of rpmslooked > fine. > > Please fix what is possible. If fedora-review will remainbroken, I will do > it manually. Please find here the new spec file and SRPM file: Spec URL: https://deamn.fedorapeople.org/maven-native.spec SRPM URL: https://deamn.fedorapeople.org/maven-native-1.0-0.1.alpha.11.fc31.src.rpm > to %build ad %check? could you explain more?
> > to %build ad %check? > could you explain more? From: %mvn_build -f -s -- -Dmojo.java.target=1.7 -Dmaven.test.failure.ignore=true and the trace above it, I'm guessing it is running check during build. So the idea is to skip tests in %build, and execute tests in %check; But i do not insists.
%mvn_install runs tests at the end of the macro, that's how it works. There's no separate way to run the tests. And all Java packages do it like this. So not having a separate %check section is completely normal for maven packages.
Sure. ty,
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/java/maven-native => it is common for all package from this srpm - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/maven-native See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names => package is being resurrected from ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "Unknown or generated", "Apache License (v2.0)". 121 files have unknown license. Detailed output of licensecheck in /tmp/1805043-maven-native/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in maven- native-components , native-maven-plugin [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: maven-native-1.0-0.1.alpha.11.fc32.noarch.rpm maven-native-components-1.0-0.1.alpha.11.fc32.noarch.rpm native-maven-plugin-1.0-0.1.alpha.11.fc32.noarch.rpm maven-native-javadoc-1.0-0.1.alpha.11.fc32.noarch.rpm maven-native-1.0-0.1.alpha.11.fc32.src.rpm maven-native.noarch: W: no-documentation maven-native-components.noarch: W: no-documentation native-maven-plugin.noarch: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). maven-native-javadoc.noarch: W: invalid-url URL: https://github.com/mojohaus/maven-native/ <urlopen error [Errno -2] Name or service not known> maven-native.noarch: W: invalid-url URL: https://github.com/mojohaus/maven-native/ <urlopen error [Errno -2] Name or service not known> maven-native.noarch: W: no-documentation maven-native-components.noarch: W: invalid-url URL: https://github.com/mojohaus/maven-native/ <urlopen error [Errno -2] Name or service not known> maven-native-components.noarch: W: no-documentation native-maven-plugin.noarch: W: invalid-url URL: https://github.com/mojohaus/maven-native/ <urlopen error [Errno -2] Name or service not known> native-maven-plugin.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 7 warnings. Source checksums ---------------- https://repo1.maven.org/maven2/org/codehaus/mojo/natives/maven-native/1.0-alpha-11/maven-native-1.0-alpha-11-source-release.zip : CHECKSUM(SHA256) this package : 80d786485f89ff60fe8935d293e30343861497167d14129d02be1f4159480ee5 CHECKSUM(SHA256) upstream package : 80d786485f89ff60fe8935d293e30343861497167d14129d02be1f4159480ee5 Requires -------- maven-native (rpmlib, GLIBC filtered): java-headless javapackages-filesystem mvn(org.codehaus.plexus:plexus-container-default) mvn(org.codehaus.plexus:plexus-utils) maven-native-components (rpmlib, GLIBC filtered): java-headless javapackages-filesystem mvn(org.codehaus.mojo.natives:maven-native-api) mvn(org.codehaus.plexus:plexus-container-default) mvn(org.codehaus.plexus:plexus-utils) native-maven-plugin (rpmlib, GLIBC filtered): java-headless javapackages-filesystem mvn(org.apache.bcel:bcel) mvn(org.apache.maven:maven-aether-provider) mvn(org.apache.maven:maven-artifact) mvn(org.apache.maven:maven-compat) mvn(org.apache.maven:maven-core) mvn(org.apache.maven:maven-model) mvn(org.apache.maven:maven-plugin-api) mvn(org.codehaus.mojo.natives:maven-native-api) mvn(org.codehaus.mojo.natives:maven-native-bcc) mvn(org.codehaus.mojo.natives:maven-native-generic-c) mvn(org.codehaus.mojo.natives:maven-native-javah) mvn(org.codehaus.mojo.natives:maven-native-manager) mvn(org.codehaus.mojo.natives:maven-native-mingw) mvn(org.codehaus.mojo.natives:maven-native-msvc) mvn(org.codehaus.plexus:plexus-archiver) mvn(org.codehaus.plexus:plexus-utils) maven-native-javadoc (rpmlib, GLIBC filtered): javapackages-filesystem Provides -------- maven-native: maven-native mvn(org.codehaus.mojo.natives:maven-native-api) mvn(org.codehaus.mojo.natives:maven-native-api:pom:) mvn(org.codehaus.mojo.natives:maven-native:pom:) maven-native-components: maven-native-components mvn(org.codehaus.mojo.natives:maven-native-bcc) mvn(org.codehaus.mojo.natives:maven-native-bcc:pom:) mvn(org.codehaus.mojo.natives:maven-native-components:pom:) mvn(org.codehaus.mojo.natives:maven-native-generic-c) mvn(org.codehaus.mojo.natives:maven-native-generic-c:pom:) mvn(org.codehaus.mojo.natives:maven-native-javah) mvn(org.codehaus.mojo.natives:maven-native-javah:pom:) mvn(org.codehaus.mojo.natives:maven-native-manager) mvn(org.codehaus.mojo.natives:maven-native-manager:pom:) mvn(org.codehaus.mojo.natives:maven-native-mingw) mvn(org.codehaus.mojo.natives:maven-native-mingw:pom:) mvn(org.codehaus.mojo.natives:maven-native-msvc) mvn(org.codehaus.mojo.natives:maven-native-msvc:pom:) native-maven-plugin: mvn(org.codehaus.mojo:native-maven-plugin) mvn(org.codehaus.mojo:native-maven-plugin:pom:) native-maven-plugin maven-native-javadoc: maven-native-javadoc Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -b 1805043 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: Python, SugarActivity, R, Perl, C/C++, PHP, Ocaml, Haskell, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH package is approved
I was not checking functionality. We will see soon during openjfx packaging. And fromorphaning, there was no major change anywhere, so it is expected to work.