Bug 180568
| Summary: | typo in spinlock.h? line 407 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 4 | Reporter: | guenter strubinsky <strubinsky> | ||||
| Component: | kernel | Assignee: | Jason Baron <jbaron> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Brian Brock <bbrock> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 4.0 | CC: | Axel.Thimm, fhirtz, herrold, jsmith.fedora, knoel, shuizinga | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | i386 | ||||||
| OS: | Linux | ||||||
| URL: | http://bugs.digium.com/view.php?id=6425 | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | RHSA-2006-0575 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-08-10 22:11:41 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 181409 | ||||||
| Attachments: |
|
||||||
AGreed. looks like a typo. will fix this up for U4. thanks. Okay. Thanks! One quick comment: There's a typo in the fix shown above -- simple replace "rw_lock_t" with "rwlock_t". (The fix above accidentally changes RW__LOCK_UNLOCKED to RW__LOCK_UNLOCK.) I just wanted to make sure that this didn't bite anyone. (I just had to make that change on 22 machines for an Asterisk training class.) Hah! A typo in the correction of a typo! Created attachment 127008 [details]
patch we're planning to inlucde for completeness
Yes, the patch that Jason Baron attached correct :-) committed in stream u3 build 34.10. A test kernel with this patch is available from http://people.redhat.com/~jbaron/rhel4/ Unfortunatly the typo still exists in 2.6.9-34.ELsmp, which happens to be the latest kernel update via RHN for EL4. indeed. -34 is the U3 kernel, and this bug is slated for inclusion in U4. thanks. verified by code inspection pm -39.EL and the build of zaptel gets past where it blew up on this bit of code in -34 An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2006-0575.html |
From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1 Description of problem: spinlock.h line 407: #define DEFINE_RWLOCK(x) rw_lock_t x = RW__LOCK_UNLOCK gives compile error since rw_lock_t isn't defined. However #define DEFINE_RWLOCK(x) rwlock_t x = RW__LOCK_UNLOCK DOES compile because rwlock_t has been defined in lines 203-209 of the same include. Since the difference is an underscore resp. the lack of an underscore in the name I could very well imagine that it's a typo. Version-Release number of selected component (if applicable): 2.6.9-27-* (all) How reproducible: Always Steps to Reproduce: 1.download from asterisk zaptel-1.2.3 2.make 3. See error messages other solution (probbaly) write a simple main() {} program and #include the spinlock.h. I would assume the comilation fails too. Actual Results: compile error datatype assumed int (since not declared) but the value assigned is cast to a (rwlock_t) !!! Expected Results: clean compile. Additional info: