Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240832-gfs-orpheus-classic-fonts/gfs-orpheus-classic-fonts.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240832-gfs-orpheus-classic-fonts/gfs-orpheus-classic-fonts-20161102-1.fc33.src.rpm Description: This rare typeface was first used in the last decade of the 19th century and was offered for use until the 1960s. Its design is characterised by an outstanding subtlety and purity in its letterforms. With almost round counters, a low x-height, a fairly high contrast and a nearly horizontal axis, it is a very elegant and legible typeface that works excellently on small text. GFS Orpheus Classic is a digital reproduction of this brilliant design. It was digitized by George Triantafyllakos based on specimens from Linotype Co. Fedora Account System Username: nim Another GFS font family, to bring the GFS catalog in Fedora to 100% The packaging conforms to https://pagure.io/packaging-committee/issue/935 as approved by FPC on 2020-02-13. It is one of the test packages that were used to refine the new packaging guidelines https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/ The new fonts packaging build chain is now live in koji. For example: https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243 If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25) https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html
Review: This package follows new fonts packaging guidelines. Rpmlint ------- Checking: gfs-orpheus-classic-fonts-20161102-1.fc33.noarch.rpm gfs-orpheus-classic-fonts-doc-20161102-1.fc33.noarch.rpm gfs-orpheus-classic-fonts-20161102-1.fc33.src.rpm gfs-orpheus-classic-fonts.noarch: W: spelling-error %description -l en_US characterised -> characterized, characteristic, characterize gfs-orpheus-classic-fonts.noarch: W: spelling-error %description -l en_US letterforms -> letter forms, letter-forms, letterbombs gfs-orpheus-classic-fonts-doc.noarch: W: summary-not-capitalized C gfs-orpheus-classic-fonts optional documentation files gfs-orpheus-classic-fonts-doc.noarch: E: description-line-too-long C This package provides optional documentation files shipped with gfs-orpheus-classic-fonts. gfs-orpheus-classic-fonts-doc.noarch: E: non-readable /usr/share/doc/gfs-orpheus-classic-fonts-doc/GFS_Orpheus_Classic_Specimen.pdf 640 gfs-orpheus-classic-fonts.src: W: spelling-error %description -l en_US characterised -> characterized, characteristic, characterize gfs-orpheus-classic-fonts.src: W: spelling-error %description -l en_US letterforms -> letter forms, letter-forms, letterbombs 3 packages and 0 specfiles checked; 2 errors, 5 warnings. Source checksums ---------------- http://www.greekfontsociety-gfs.gr/_assets/fonts/GFS_Orpheus_Classic.zip : CHECKSUM(SHA256) this package : 4cae1a7104be63627f04184e690514ca4371dc4e9ab2026694e03a44388b577a CHECKSUM(SHA256) upstream package : 4cae1a7104be63627f04184e690514ca4371dc4e9ab2026694e03a44388b577a Requires -------- gfs-orpheus-classic-fonts (rpmlib, GLIBC filtered): config(gfs-orpheus-classic-fonts) fontpackages-filesystem gfs-orpheus-classic-fonts-doc (rpmlib, GLIBC filtered): Provides -------- gfs-orpheus-classic-fonts: config(gfs-orpheus-classic-fonts) font(gfsorpheusclassic) gfs-orpheus-classic-fonts metainfo() metainfo(org.fedoraproject.gfs-orpheus-classic-fonts.metainfo.xml) gfs-orpheus-classic-fonts-doc: gfs-orpheus-classic-fonts-doc All other things like license, config, metainfo files looks good. Issues: 1) Fix the rpmlint warnings/errors before this package import APPROVED
Ok, I’ll add a blanket defattr to all doc subpackages Fixed the descriptions too Thanks for the review! http://www.greekfontsociety-gfs.gr/typefaces/19th_century
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gfs-orpheus-classic-fonts
Done for F32 & F33. Thanks Parag and Gwyn.