Bug 1805768 - Review Request: production-type-spectral-fonts - An efficient and versatile serif font family
Summary: Review Request: production-type-spectral-fonts - An efficient and versatile s...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-21 14:19 UTC by Nicolas Mailhot
Modified: 2020-03-31 00:16 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-31 00:16:00 UTC
Type: ---
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)

Description Nicolas Mailhot 2020-02-21 14:19:31 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240854-production-type-spectral-fonts/production-type-spectral-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240854-production-type-spectral-fonts/production-type-spectral-fonts-2.003-1.20191208git748733e.fc33.src.rpm

Description: 
Spectral is a versatile serif font family available in seven weights of roman
and italic, with small caps. Spectral offers an efficient, beautiful design
that’s intended primarily for text-rich, screen-first environments and
long-form reading.

Fedora Account System Username: nim



One of the top font families on Google fonts.

The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It makes use of our forge automation:
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 2 Parag AN(पराग) 2020-03-14 18:01:25 UTC
Review:

This package follows new fonts packaging guidelines.

Rpmlint
-------
Checking: production-type-spectral-fonts-2.003-2.20191208git748733e.fc33.noarch.rpm
          production-type-spectral-fonts-2.003-2.20191208git748733e.fc33.src.rpm
production-type-spectral-fonts.noarch: W: incoherent-version-in-changelog 2.003-2 ['2.003-2.20191208git748733e.fc33', '2.003-2.20191208git748733e']
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

ource checksums
----------------
https://github.com/productiontype/Spectral/archive/748733e3761fc7985ca9c473996ed121954debf8/Spectral-748733e3761fc7985ca9c473996ed121954debf8.tar.gz :
  CHECKSUM(SHA256) this package     : 277bc3e064296f23dd89509222d8a1f410e7ecaf3c9140aaf68a68c328cc5d1c
  CHECKSUM(SHA256) upstream package : 277bc3e064296f23dd89509222d8a1f410e7ecaf3c9140aaf68a68c328cc5d1c


Requires
--------
production-type-spectral-fonts (rpmlib, GLIBC filtered):
    config(production-type-spectral-fonts)
    fontpackages-filesystem



Provides
--------
production-type-spectral-fonts:
    config(production-type-spectral-fonts)
    font(spectral)
    font(spectralextrabold)
    font(spectralextralight)
    font(spectrallight)
    font(spectralmedium)
    font(spectralsemibold)
    metainfo()
    metainfo(org.fedoraproject.production-type-spectral-fonts.metainfo.xml)
    production-type-spectral-fonts


Issues:
1) Fix the Changelog rpmlint warning before package import
2) I do not see license file installed under /usr/share/licenses/


APPROVED.

Comment 3 Gwyn Ciesla 2020-03-14 20:01:51 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/production-type-spectral-fonts

Comment 4 Fedora Update System 2020-03-14 21:12:10 UTC
FEDORA-2020-951aef28b2 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-951aef28b2

Comment 5 Fedora Update System 2020-03-15 14:29:46 UTC
production-type-spectral-fonts-2.003-2.20200314git748733e.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d4b3dbbd8b

Comment 6 Fedora Update System 2020-03-16 14:12:00 UTC
production-type-spectral-fonts-2.003-2.20200314git748733e.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-951aef28b2

Comment 7 Fedora Update System 2020-03-31 00:16:00 UTC
FEDORA-2020-951aef28b2 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.