Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240861-sil-annapurna-fonts/sil-annapurna-fonts.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240861-sil-annapurna-fonts/sil-annapurna-fonts-1.204-1.fc33.src.rpm Description: Annapurna SIL is a Unicode-based font family with broad support for writing systems that use the Devanagari script. Inspired by traditional calligraphic forms, the design is intended to be highly readable, reasonably compact, and visually attractive. The Devanagari script is used to write over 170 languages in South Asia. Annapurna SIL supports a full range of these writing systems. Fedora Account System Username: nim One of SIL’s Non-Roman Script Initiative. https://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=Home SIL is a specialist of rare human scripts and contributes its expertise to the Unicode consortium. The objective is to get 100% of SIL’s font catalog in Fedora to improve our i18n coverage. Due to $#@= variations on how SIL publishes its fonts, the spec uses some SIL-specific macros to hide those variations and limit the changes between the specs of SIL fonts. The packaging conforms to https://pagure.io/packaging-committee/issue/935 as approved by FPC on 2020-02-13. It is one of the test packages that were used to refine the new packaging guidelines https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/ The new fonts packaging build chain is now live in koji. For example: https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243 If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25) https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html
Review: Not going for full package review. This package follows new fonts packaging guidelines. Rpmlint ------- Checking: sil-awami-nastaliq-fonts-2.000-1.fc33.noarch.rpm sil-awami-nastaliq-fonts-2.000-1.fc33.src.rpm sil-awami-nastaliq-fonts.noarch: W: no-version-in-last-changelog sil-awami-nastaliq-fonts.src: W: no-version-in-last-changelog 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/silnrsi/font-awami/releases/download/v2.000/AwamiNastaliq-2.000.tar.xz : CHECKSUM(SHA256) this package : 35d3abbdc4756ed73371aadb5907f8d38457da374c9ee380cef771b9141c4b80 CHECKSUM(SHA256) upstream package : 35d3abbdc4756ed73371aadb5907f8d38457da374c9ee380cef771b9141c4b80 Requires -------- sil-awami-nastaliq-fonts (rpmlib, GLIBC filtered): config(sil-awami-nastaliq-fonts) fontpackages-filesystem Provides -------- sil-awami-nastaliq-fonts: config(sil-awami-nastaliq-fonts) font(awaminastaliq) metainfo() metainfo(org.fedoraproject.sil-awami-nastaliq-fonts.metainfo.xml) sil-awami-nastaliq-fonts All other things like license, config, metainfo files looks good. Issues: 1) Please fix rpmlint warning "no-version-in-last-changelog" before import. (Seems missing release number in Changelog) APPROVED.
ah please ignore previous comment. Review: Not going for full package review. This package follows new fonts packaging guidelines. Rpmlint ------- Checking: sil-annapurna-fonts-1.204-1.fc33.noarch.rpm sil-annapurna-fonts-doc-1.204-1.fc33.noarch.rpm sil-annapurna-fonts-1.204-1.fc33.src.rpm sil-annapurna-fonts.noarch: W: spurious-executable-perm /usr/share/doc/sil-annapurna-fonts/AnnapurnaSIL-GraphiteFeatures.odt sil-annapurna-fonts-doc.noarch: W: summary-not-capitalized C sil-annapurna-fonts optional documentation files sil-annapurna-fonts-doc.noarch: E: description-line-too-long C This package provides optional documentation files shipped with sil-annapurna-fonts. sil-annapurna-fonts-doc.noarch: W: spurious-executable-perm /usr/share/doc/sil-annapurna-fonts-doc/AnnapurnaSIL-features.pdf 3 packages and 0 specfiles checked; 1 errors, 3 warnings. Source checksums ---------------- https://github.com/silnrsi/font-annapurna/releases/download/v1.204/AnnapurnaSIL-1.204.tar.xz : CHECKSUM(SHA256) this package : b9c31d4259f5579d8ce677ea161d761b1abc13c220b798a73e9d5d22710237d5 CHECKSUM(SHA256) upstream package : b9c31d4259f5579d8ce677ea161d761b1abc13c220b798a73e9d5d22710237d5 Requires -------- sil-annapurna-fonts (rpmlib, GLIBC filtered): config(sil-annapurna-fonts) fontpackages-filesystem sil-annapurna-fonts-doc (rpmlib, GLIBC filtered): Provides -------- sil-annapurna-fonts: config(sil-annapurna-fonts) font(annapurnasil) metainfo() metainfo(org.fedoraproject.sil-annapurna-fonts.metainfo.xml) sil-annapurna-fonts sil-annapurna-fonts-doc: sil-annapurna-fonts-doc All other things like license, config, metainfo files looks good. Issues: 1) Please fix rpmlint warnings before import. APPROVED.
Fixed the warnings :( If SIL continues committing executable doc I may just dump a generic chmod in all SIL specs. Thanks a lot for the review! https://pagure.io/releng/fedora-scm-requests/issue/22397
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sil-annapurna-fonts
Done for F32 & F33. Thanks Parag and Gwyn.