Bug 1805886 - Review Request: sil-dai-banna-fonts - A font family for rendering New Tai Lue (Xishuangbanna Dai)
Summary: Review Request: sil-dai-banna-fonts - A font family for rendering New Tai Lue...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-21 17:05 UTC by Nicolas Mailhot
Modified: 2020-02-25 20:15 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-02-25 20:15:10 UTC
Type: ---
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)

Description Nicolas Mailhot 2020-02-21 17:05:11 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240946-sil-dai-banna-fonts/sil-dai-banna-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240946-sil-dai-banna-fonts/sil-dai-banna-fonts-2.200-1.fc33.src.rpm

Description:
Dai Banna includes a complete set of New Tai Lue (Xishuangbanna Dai)
consonants, vowels, tones, and digits, along with punctuation and other useful
symbols. A basic set of Latin glyphs, including Arabic numerals, is also
provided.

The New Tai Lue script is used by approximately 300 000 people who speak the
Xishuangbanna Dai language in Yunnan, China.  It is a simplification of the Tai
Tham (Old Tai Lue) script as used for this language for hundreds of years.

The Dai News Department of Xishuangbanna Daily provided valuable advice during
the development of this font family. Xishuangbanna Daily, established in 1957,
is the largest newspaper company in Yunnan, China that publishes in the New Tai
Lue script.

Fedora Account System Username: nim



One of SIL’s Non-Roman Script Initiative font families
https://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=Home

SIL is a specialist of rare human scripts and contributes its expertise to the Unicode consortium. The objective is to get 100% of SIL’s font catalog in Fedora to improve our i18n coverage.

Due to $#@= variations on how SIL publishes its fonts, the spec uses some SIL-specific macros to hide those variations and limit the changes between the specs of SIL fonts.



The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 1 Parag AN(पराग) 2020-02-23 11:41:00 UTC
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
-------
Checking: sil-dai-banna-fonts-2.200-1.fc33.noarch.rpm
          sil-dai-banna-fonts-doc-2.200-1.fc33.noarch.rpm
          sil-dai-banna-fonts-2.200-1.fc33.src.rpm
sil-dai-banna-fonts.noarch: E: summary-too-long C Dai Banna SIL, a font family for rendering New Tai Lue (Xishuangbanna Dai) characters
sil-dai-banna-fonts.noarch: W: spelling-error %description -l en_US Xishuangbanna -> Shijiazhuang
sil-dai-banna-fonts-doc.noarch: W: summary-not-capitalized C sil-dai-banna-fonts optional documentation files
sil-dai-banna-fonts-doc.noarch: E: description-line-too-long C This package provides optional documentation files shipped with sil-dai-banna-fonts.
sil-dai-banna-fonts-doc.noarch: W: spurious-executable-perm /usr/share/doc/sil-dai-banna-fonts-doc/DaiBannaSIL.pdf
sil-dai-banna-fonts-doc.noarch: W: file-not-utf8 /usr/share/doc/sil-dai-banna-fonts-doc/sample.txt
sil-dai-banna-fonts.src: E: summary-too-long C Dai Banna SIL, a font family for rendering New Tai Lue (Xishuangbanna Dai) characters
sil-dai-banna-fonts.src: W: spelling-error %description -l en_US Xishuangbanna -> Shijiazhuang
3 packages and 0 specfiles checked; 3 errors, 5 warnings.

Source checksums
----------------
https://software.sil.org/downloads/r/daibanna/DaiBanna-2.200.zip :
  CHECKSUM(SHA256) this package     : bab67e560484ee9bc041d1e95ae2e36a08ceb9cde6800ef032381fae0700f691
  CHECKSUM(SHA256) upstream package : bab67e560484ee9bc041d1e95ae2e36a08ceb9cde6800ef032381fae0700f691


Requires
--------
sil-dai-banna-fonts (rpmlib, GLIBC filtered):
    config(sil-dai-banna-fonts)
    fontpackages-filesystem

sil-dai-banna-fonts-doc (rpmlib, GLIBC filtered):



Provides
--------
sil-dai-banna-fonts:
    config(sil-dai-banna-fonts)
    font(daibannasilbook)
    font(daibannasillight)
    metainfo()
    metainfo(org.fedoraproject.sil-dai-banna-fonts.metainfo.xml)
    sil-dai-banna-fonts

sil-dai-banna-fonts-doc:
    sil-dai-banna-fonts-doc

All other things like license, config, metainfo files looks good.

Issues:
1) Fix rpmlint issues before import of this package


APPROVED.

Comment 2 Nicolas Mailhot 2020-02-23 14:26:55 UTC
Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22399

Comment 3 Nicolas Mailhot 2020-02-23 14:30:41 UTC
uchardet detects /usr/share/doc/sil-dai-banna-fonts-doc/sample.txt as UTF-8, so something weird is going in rpmlint’s encoding detection

Comment 4 Gwyn Ciesla 2020-02-24 14:31:16 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/sil-dai-banna-fonts

Comment 5 Nicolas Mailhot 2020-02-25 20:15:10 UTC
Done for FC32 and FC33

The FC32 probably missed the deadline and will be available as an update


Note You need to log in before you can comment on or make changes to this bug.