Bug 1805894 - Review Request: sil-ezra-fonts - An Hebrew font family
Summary: Review Request: sil-ezra-fonts - An Hebrew font family
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-21 17:13 UTC by Nicolas Mailhot
Modified: 2020-02-25 00:26 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-02-25 00:26:05 UTC
Type: ---
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)

Description Nicolas Mailhot 2020-02-21 17:13:29 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240867-sil-ezra-fonts/sil-ezra-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240867-sil-ezra-fonts/sil-ezra-fonts-2.51-1.fc33.src.rpm

Description:
The Ezra SIL font families are fashioned after the square letter forms of the
typography of the Biblia Hebraica Stuttgartensia (BHS), a beautiful Old
Testament volume familiar to Biblical Hebrew scholars.

The different font families are available to provide two different styles of
cantillation marks. They were developed together, but there are some
differences in how they display markings. This was done intentionally.

Fedora Account System Username: nim


One of SIL’s Non-Roman Script Initiative font families
https://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=Home

SIL is a specialist of rare human scripts and contributes its expertise to the Unicode consortium. The objective is to get 100% of SIL’s font catalog in Fedora to improve our i18n coverage.

Due to $#@= variations on how SIL publishes its fonts, the spec uses some SIL-specific macros to hide those variations and limit the changes between the specs of SIL fonts.



The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 1 Parag AN(पराग) 2020-02-23 11:42:24 UTC
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
-------
Checking: sil-ezra-sr-fonts-2.51-1.fc33.noarch.rpm
          sil-ezra-fonts-2.51-1.fc33.src.rpm
sil-ezra-sr-fonts.noarch: W: spelling-error %description -l en_US cantillation -> scintillation, cancellation, titillation
sil-ezra-fonts.src: W: spelling-error %description -l en_US cantillation -> scintillation, cancellation, titillation
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source checksums
----------------
https://scripts.sil.org/cms/scripts/render_download.php?format=file&media_id=EzraSIL251.zip&filename=EzraSIL251.zip#/EzraSIL251.zip :
  CHECKSUM(SHA256) this package     : fd2894531aab32ff7d6845e3d0b4c0401c91f64ba637d13624dfc17a3e815831
  CHECKSUM(SHA256) upstream package : fd2894531aab32ff7d6845e3d0b4c0401c91f64ba637d13624dfc17a3e815831


Requires
--------
sil-ezra-sr-fonts (rpmlib, GLIBC filtered):
    config(sil-ezra-sr-fonts)
    fontpackages-filesystem



Provides
--------
sil-ezra-sr-fonts:
    config(sil-ezra-sr-fonts)
    font(ezrasilsr)
    metainfo()
    metainfo(org.fedoraproject.sil-ezra-sr-fonts.metainfo.xml)
    sil-ezra-sr-fonts



All other things like license, config, metainfo files looks good.

APPROVED.

Comment 2 Nicolas Mailhot 2020-02-23 14:53:14 UTC
Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22400

Comment 3 Gwyn Ciesla 2020-02-24 14:31:37 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/sil-ezra-fonts

Comment 4 Nicolas Mailhot 2020-02-25 00:26:05 UTC
Done for F32 & F33. Thanks Parag and Gwyn.


Note You need to log in before you can comment on or make changes to this bug.