Bug 1805900 - Review Request: sil-gentium-plus-compact-fonts - A Latin/Greek/Cyrillic font family
Summary: Review Request: sil-gentium-plus-compact-fonts - A Latin/Greek/Cyrillic font ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-21 17:19 UTC by Nicolas Mailhot
Modified: 2020-02-25 00:12 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-02-25 00:12:37 UTC
Type: ---
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)

Description Nicolas Mailhot 2020-02-21 17:19:03 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240869-sil-gentium-plus-compact-fonts/sil-gentium-plus-compact-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240869-sil-gentium-plus-compact-fonts/sil-gentium-plus-compact-fonts-5.000-1.fc33.src.rpm

Description:
Gentium is a font family designed to enable the diverse ethnic groups around
the world who use the Latin, Cyrillic and Greek scripts to produce readable,
high-quality publications.
Cyrillic-based alphabets.

Gentium was a winner of the TDC2003 Type Design Competition and was exhibited
as part of the bukva:raz! exhibit at the UN Headquarters Main Lobby, 17 Jan –
13 Feb, 2002.

The Gentium Plus Compact font family was derived from Gentium Plus using SIL
TypeTuner, by setting the “Line spacing” feature to “Tight”, and it cannot be
TypeTuned again. It may exhibit some diacritics clipping on screen (but should
print fine).

Fedora Account System Username: nim

Comment 1 Nicolas Mailhot 2020-02-21 17:19:40 UTC
One of SIL’s Non-Roman Script Initiative font families
https://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=Home

SIL is a specialist of rare human scripts and contributes its expertise to the Unicode consortium. The objective is to get 100% of SIL’s font catalog in Fedora to improve our i18n coverage.

Due to $#@= variations on how SIL publishes its fonts, the spec uses some SIL-specific macros to hide those variations and limit the changes between the specs of SIL fonts.



The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 2 Parag AN(पराग) 2020-02-23 07:24:55 UTC
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
-------
Checking: sil-gentium-plus-compact-fonts-5.000-1.fc33.noarch.rpm
          sil-gentium-plus-compact-fonts-5.000-1.fc33.src.rpm
sil-gentium-plus-compact-fonts.noarch: W: spelling-error %description -l en_US bukva -> kabuki
sil-gentium-plus-compact-fonts.noarch: W: spelling-error %description -l en_US raz -> raze, razz, ran
sil-gentium-plus-compact-fonts.src: W: spelling-error %description -l en_US bukva -> kabuki
sil-gentium-plus-compact-fonts.src: W: spelling-error %description -l en_US raz -> raze, razz, ran
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Source checksums
----------------
https://software.sil.org/downloads/r/gentium/GentiumPlusCompact-5.000.zip :
  CHECKSUM(SHA256) this package     : 1d8a4ff03dce90f6002b008a5e37f890c409bc22e4e26561b67f3f3c40991b5c
  CHECKSUM(SHA256) upstream package : 1d8a4ff03dce90f6002b008a5e37f890c409bc22e4e26561b67f3f3c40991b5c


Requires
--------
sil-gentium-plus-compact-fonts (rpmlib, GLIBC filtered):
    config(sil-gentium-plus-compact-fonts)
    fontpackages-filesystem



Provides
--------
sil-gentium-plus-compact-fonts:
    config(sil-gentium-plus-compact-fonts)
    font(gentiumpluscompact)
    metainfo()
    metainfo(org.fedoraproject.sil-gentium-plus-compact-fonts.metainfo.xml)
    sil-gentium-plus-compact-fonts

All other things like license, config, metainfo files looks good.

APPROVED.

Comment 3 Nicolas Mailhot 2020-02-23 07:46:19 UTC
Thanks a lot for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22381

(all the other sil packages are almost identical from a structure POW, if you want to take a look)

Comment 4 Gwyn Ciesla 2020-02-24 14:44:22 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/sil-gentium-plus-compact-fonts

Comment 5 Nicolas Mailhot 2020-02-25 00:12:37 UTC
Done for F32 & F33. Thanks Parag and Gwyn.


Note You need to log in before you can comment on or make changes to this bug.