Bug 1805913 - Review Request: sil-gentium-plus-fonts - A Latin/Greek/Cyrillic font family
Summary: Review Request: sil-gentium-plus-fonts - A Latin/Greek/Cyrillic font family
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-21 17:24 UTC by Nicolas Mailhot
Modified: 2020-02-25 00:10 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-02-25 00:10:57 UTC
Type: ---
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)

Description Nicolas Mailhot 2020-02-21 17:24:55 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240870-sil-gentium-plus-fonts/sil-gentium-plus-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240870-sil-gentium-plus-fonts/sil-gentium-plus-fonts-5.000-1.fc33.src.rpm

Description:
Gentium is a font family designed to enable the diverse ethnic groups around
the world who use the Latin, Cyrillic and Greek scripts to produce readable,
high-quality publications.
Cyrillic-based alphabets.

Gentium was a winner of the TDC2003 Type Design Competition and was exhibited
as part of the bukva:raz! exhibit at the UN Headquarters Main Lobby, 17 Jan –
13 Feb, 2002.

Fedora Account System Username: nim



One of SIL’s Non-Roman Script Initiative font families
https://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=Home

SIL is a specialist of rare human scripts and contributes its expertise to the Unicode consortium. The objective is to get 100% of SIL’s font catalog in Fedora to improve our i18n coverage.

Due to $#@= variations on how SIL publishes its fonts, the spec uses some SIL-specific macros to hide those variations and limit the changes between the specs of SIL fonts.



The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 1 Parag AN(पराग) 2020-02-23 08:14:57 UTC
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
-------
Checking: sil-gentium-plus-fonts-5.000-1.fc33.noarch.rpm
          sil-gentium-plus-fonts-5.000-1.fc33.src.rpm
sil-gentium-plus-fonts.noarch: W: spelling-error %description -l en_US bukva -> kabuki
sil-gentium-plus-fonts.noarch: W: spelling-error %description -l en_US raz -> raze, razz, ran
sil-gentium-plus-fonts.src: W: spelling-error %description -l en_US bukva -> kabuki
sil-gentium-plus-fonts.src: W: spelling-error %description -l en_US raz -> raze, razz, ran
2 packages and 0 specfiles checked; 0 errors, 4 warnings.



Source checksums
----------------
https://software.sil.org/downloads/r/gentium/GentiumPlus-5.000.zip :
  CHECKSUM(SHA256) this package     : 335911f17bd2de4e43742e1d0367cfeff19a90abf7ed604f100a42705042e154
  CHECKSUM(SHA256) upstream package : 335911f17bd2de4e43742e1d0367cfeff19a90abf7ed604f100a42705042e154


Requires
--------
sil-gentium-plus-fonts (rpmlib, GLIBC filtered):
    config(sil-gentium-plus-fonts)
    fontpackages-filesystem



Provides
--------
sil-gentium-plus-fonts:
    config(sil-gentium-plus-fonts)
    font(gentiumplus)
    metainfo()
    metainfo(org.fedoraproject.sil-gentium-plus-fonts.metainfo.xml)
    sil-gentium-plus-fonts

All other things like license, config, metainfo files looks good.

APPROVED.

Comment 2 Nicolas Mailhot 2020-02-23 11:07:10 UTC
Thanks a lot for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22382

Comment 3 Gwyn Ciesla 2020-02-24 14:44:39 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/sil-gentium-plus-fonts

Comment 4 Nicolas Mailhot 2020-02-25 00:10:57 UTC
Done for F32 & F33. Thanks Parag and Gwyn.


Note You need to log in before you can comment on or make changes to this bug.