Bug 1806018 - Review Request: vernnobile-oswald-fonts - A reworked gothic style font family
Summary: Review Request: vernnobile-oswald-fonts - A reworked gothic style font family
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-21 20:10 UTC by Nicolas Mailhot
Modified: 2020-02-25 20:53 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-02-25 20:53:26 UTC
Type: ---
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)

Description Nicolas Mailhot 2020-02-21 20:10:45 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240891-vernnobile-oswald-fonts/vernnobile-oswald-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240891-vernnobile-oswald-fonts/vernnobile-oswald-fonts-4.101-1.20191208git5a5fff2.fc33.src.rpm

Description:
Oswald is a reworking of the classic gothic typeface style historically
represented by designs such as “Alternate Gothic”. The characters of Oswald
have been re-drawn and reformed to better fit the pixel grid of standard
digital screens. Oswald is designed to be used freely across the internet by
web browsers on desktop computers, laptops and mobile devices.

Fedora Account System Username: nim



One of the top font families on Google fonts.

The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It makes use of our forge automation:
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 1 Parag AN(पराग) 2020-02-25 17:02:26 UTC
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
-------
Checking: vernnobile-oswald-fonts-4.101-1.20191208git5a5fff2.fc33.noarch.rpm
          vernnobile-oswald-fonts-4.101-1.20191208git5a5fff2.fc33.src.rpm
vernnobile-oswald-fonts.noarch: W: spelling-error Summary(en_US) gothic -> Gothic, goths
vernnobile-oswald-fonts.noarch: W: spelling-error %description -l en_US gothic -> Gothic, goths
vernnobile-oswald-fonts.noarch: W: spurious-executable-perm /usr/share/doc/vernnobile-oswald-fonts/OFL.txt
vernnobile-oswald-fonts.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/vernnobile-oswald-fonts/OFL.txt
vernnobile-oswald-fonts.src: W: spelling-error Summary(en_US) gothic -> Gothic, goths
vernnobile-oswald-fonts.src: W: spelling-error %description -l en_US gothic -> Gothic, goths
2 packages and 0 specfiles checked; 1 errors, 5 warnings.

Source checksums
----------------
https://github.com/googlefonts/OswaldFont/archive/5a5fff234687674f8531a8537455e626b08b3321/OswaldFont-5a5fff234687674f8531a8537455e626b08b3321.tar.gz :
  CHECKSUM(SHA256) this package     : e6138d3982041ff3429e26e1814229826ad882b78cbb244a504ba19066c25b45
  CHECKSUM(SHA256) upstream package : e6138d3982041ff3429e26e1814229826ad882b78cbb244a504ba19066c25b45


Requires
--------
vernnobile-oswald-fonts (rpmlib, GLIBC filtered):
    config(vernnobile-oswald-fonts)
    fontpackages-filesystem



Provides
--------
vernnobile-oswald-fonts:
    config(vernnobile-oswald-fonts)
    font(oswald)
    font(oswaldextralight)
    font(oswaldlight)
    font(oswaldmedium)
    font(oswaldsemibold)
    metainfo()
    metainfo(org.fedoraproject.vernnobile-oswald-fonts.metainfo.xml)
    vernnobile-oswald-fonts


All other things like license, config, metainfo files looks good.


Issues:
1) Fix the rpmlint warnings/errors before import of this package.

APPROVED.

Comment 2 Nicolas Mailhot 2020-02-25 20:25:47 UTC
Fixed the warnings, thanks for the review!
https://pagure.io/releng/fedora-scm-requests/issue/22531

Comment 3 Gwyn Ciesla 2020-02-25 20:31:02 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/vernnobile-oswald-fonts

Comment 4 Nicolas Mailhot 2020-02-25 20:53:26 UTC
Built for F32 (update) and F33

Thanks Parag and Gwyn


Note You need to log in before you can comment on or make changes to this bug.