Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://raw.githubusercontent.com/skywalkerz0r/golang-github-jingweno-ccat/master/golang-github-jingweno-ccat.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/brandfbb/golang-testing/fedora-31-x86_64/01249266-golang-github-jingweno-ccat/golang-github-jingweno-ccat-1.1.0-1.fc31.src.rpm Description: Colorizing `cat` Fedora Account System Username: brandfbb
For a start: * SRPM URL is invalid. I used [1] instead, but please fix it. * I believe Release tag should be set to "1%{?dist}", not "1%{dist}". * /usr/bin/ccat is already provided by ccrypt in Fedora. [1] https://download.copr.fedorainfracloud.org/results/brandfbb/golang-testing/fedora-32-x86_64/01249266-golang-github-jingweno-ccat/golang-github-jingweno-ccat-1.1.0-1.fc33.src.rpm
Imports in source files refer to "github.com/jingweno/ccat/Godeps/_workspace/". That doesn't seem right and should be fixed, ideally upstream.
This spec file was generated with go2rpm. Please see here[1] for more information. However, I found interesting the fact that we already have a ccat. I need to see how to procedure in this case. Please, check [1] and meanwhile I will see if I will have to give up having this package on fedora. 1 https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/
> This spec file was generated with go2rpm. I'm aware, but that doesn't make any of my points invalid. In fact, go2rpm on my end generates: "Release: 1%{?dist}" > However, I found interesting the fact that we already have a ccat. > I need to see how to procedure in this case. You can rename the binary, or you can convince ccrypt to rename theirs (perhaps they would be ok with it, since AFAICS ccat is just a convenience alias to ccrypt --cat). I don't think there is any other option, as ccat from ccrypt has a completely different purpose, so you can't use alternatives or similar mechanism to deal with the conflict.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
Breno, are you still interested in packaging this?
Hey, I really missed this one. I will review the spec file and send it to you again Nikola. Thanks for the reminder. Life's been busy.
I won't build this package anymore.