Bug 1806339 - In Admin Portal, "Huge Pages (size: amount)" needs to be clarified
Summary: In Admin Portal, "Huge Pages (size: amount)" needs to be clarified
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 4.3.8
Hardware: x86_64
OS: Linux
low
low
Target Milestone: ovirt-4.4.1
: 4.4.1
Assignee: Steven Rosenberg
QA Contact: Polina
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-23 22:47 UTC by Germano Veit Michel
Modified: 2022-07-09 12:49 UTC (History)
7 users (show)

Fixed In Version: rhv-4.4.1-11
Doc Type: Enhancement
Doc Text:
The current release changes the *Huge Pages* label to *Free Huge Pages* so it is easier to understand what the values represent.
Clone Of:
Environment:
Last Closed: 2020-09-23 16:11:04 UTC
oVirt Team: Virt
Target Upstream Version:
Embargoed:
lsvaty: testing_plan_complete-


Attachments (Terms of Use)
Huge Pages Displayed in the Host (3.52 KB, image/png)
2020-06-11 16:36 UTC, Steven Rosenberg
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-37558 0 None None None 2022-07-09 12:49:07 UTC
Red Hat Knowledge Base (Solution) 4851091 0 None None None 2020-02-23 22:55:32 UTC
Red Hat Product Errata RHSA-2020:3807 0 None None None 2020-09-23 16:11:24 UTC
oVirt gerrit 109681 0 master MERGED WebAdmin: Change label to Free Huge Pages 2020-10-13 20:12:55 UTC

Description Germano Veit Michel 2020-02-23 22:47:14 UTC
Description of problem:

In Compute -> Hosts-> host.example.com -> General, the item "Huge Pages (size: amount)" is the amount of free huge-pages on the host.
But the text is not clear, the customer may mistake it to the total number of HPs configured on the host, free or used. 

Would be nice to make it clearer in the UI. Or even better: show both total and free HPs.

Version-Release number of selected component (if applicable):
ovirt-engine-4.3.8.2-0.4.el7.noarch

How reproducible:
100%

Steps to Reproduce:
1. Configure Host with 2 static Huge Pages
2. Reboot
3. Check UI:
   "Huge Pages (size: amount): 1048576: 2"
4. Run VM with 2GB of HPs
5. Check UI
   "Huge Pages (size: amount): 1048576: 0"

Comment 1 Steven Rosenberg 2020-06-11 16:36:44 UTC
Created attachment 1696874 [details]
Huge Pages Displayed in the Host

We currently display the size and amount as per the screen shot. Please clarify what you would like changed. Thank you.

Comment 2 Steven Rosenberg 2020-06-11 16:37:10 UTC
(In reply to Steven Rosenberg from comment #1)
> Created attachment 1696874 [details]
> Huge Pages Displayed in the Host
> 
> We currently display the size and amount as per the screen shot. Please
> clarify what you would like changed. Thank you.

Comment 3 Klaas Demter 2020-06-11 18:49:43 UTC
(In reply to Steven Rosenberg from comment #2)
> (In reply to Steven Rosenberg from comment #1)
> > Created attachment 1696874 [details]
> > Huge Pages Displayed in the Host
> > 
> > We currently display the size and amount as per the screen shot. Please
> > clarify what you would like changed. Thank you.

Hi,
from the naming of the item I was expecting it to be total hugepages on the host, not just the free ones.

What I would really like for it to say something like:
"Huge Pages (size: total amount / free): 1048576: 2 / 2" or something like that.

Greetings
Klaas

Comment 4 Germano Veit Michel 2020-06-11 21:57:15 UTC
(In reply to Steven Rosenberg from comment #1)
> Created attachment 1696874 [details]
> Huge Pages Displayed in the Host
> 
> We currently display the size and amount as per the screen shot. Please
> clarify what you would like changed. Thank you.

As mentioned in comment #0, it is not clear if those numbers are free, used or totals.
And I think it should be also improved, displaying total and free, or total and used.

(In reply to Germano Veit Michel from comment #0)
> But the text is not clear, the customer may mistake it to the total number
> of HPs configured on the host, free or used. 
> 
> Would be nice to make it clearer in the UI. Or even better: show both total
> and free HPs.

Comment 5 Steven Rosenberg 2020-06-15 11:09:54 UTC
(In reply to Germano Veit Michel from comment #4)
> (In reply to Steven Rosenberg from comment #1)
> > Created attachment 1696874 [details]
> > Huge Pages Displayed in the Host
> > 
> > We currently display the size and amount as per the screen shot. Please
> > clarify what you would like changed. Thank you.
> 
> As mentioned in comment #0, it is not clear if those numbers are free, used
> or totals.
> And I think it should be also improved, displaying total and free, or total
> and used.
> 
> (In reply to Germano Veit Michel from comment #0)
> > But the text is not clear, the customer may mistake it to the total number
> > of HPs configured on the host, free or used. 
> > 
> > Would be nice to make it clearer in the UI. Or even better: show both total
> > and free HPs.

I think the code explains it clearly [1], the 2048 is the size in kB and the amount is 0 for that page. The 2048 is the amount of free huge pages of the given size.

So the label does show that for a given page the format is the "size: amount". What format would you like specifically that would be clearer to you? There are two values per page, size and amount. 


[1] https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/HostStatisticalQuery.java#L72-L73

Comment 6 Arik 2020-06-15 16:47:35 UTC
I think we can avoid the confusion about what is currently presented by simply replacing "Huge Pages" with "Free Huge Pages".
As for adding the total huge pages, this should probably be a separate RFE.

Comment 7 Arik 2020-06-18 14:49:00 UTC
(In reply to Arik from comment #6)
> As for adding the total huge pages, this should probably be a separate RFE.

Filed bz 1848579 for that

Comment 8 Klaas Demter 2020-07-08 06:39:54 UTC
@Michal Skrivanek - I am guessing you mean fixed in rhv-4.4.1-11 ?

Comment 9 Polina 2020-07-08 14:32:29 UTC
Verified on ovirt-engine-4.4.1.7-0.3.el8ev.noarch

Before VMs starting on host:
Free Huge Pages (size: amount): 2048: 1024, 1048576: 4

Start VM1(system memory 1024) with HugePages 2048, VM2(system memory 1024) with Hugepages 1048576,  VM3(system memory 3072) with HugePages 1048576 ->
Free Huge Pages (size: amount): 2048: 512, 1048576: 0

Comment 16 errata-xmlrpc 2020-09-23 16:11:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat Virtualization security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3807


Note You need to log in before you can comment on or make changes to this bug.