Bug 1806436 - [SSP] Windows common templates - Windows10 should be removed from windows-server* templates, windows-server* should not have desktop version
Summary: [SSP] Windows common templates - Windows10 should be removed from windows-ser...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: SSP
Version: 2.3.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 2.4.0
Assignee: Andrej Krejcir
QA Contact: Ruth Netser
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-24 08:32 UTC by Ruth Netser
Modified: 2020-07-28 19:09 UTC (History)
7 users (show)

Fixed In Version: kubevirt-ssp-operator-container-v2.4.0-20
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-28 19:09:44 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2020:3194 0 None None None 2020-07-28 19:09:55 UTC

Description Ruth Netser 2020-02-24 08:32:01 UTC
Description of problem:
1. Windows server common templates contain Windows10.
2. There should not be a desktop workload in windows-server* templates

Version-Release number of selected component (if applicable):
CNV 2.3.0

How reproducible:
100%

Steps to Reproduce:
1. Open an Windows server template yaml

$ oc get template -n openshift windows-desktop-large-v0.7.0 -oyaml|less

2. Run $ oc get template -n openshift|grep win

Actual results:
1. Template annotations and labels contain Microsoft Windows 10
2. There are Windows desktop templates for Window server OS

Expected results:
1. Windows10 should be removed from Server templates
2. desktop workload templates should be removed


Additional info:
=======================================================
$ oc get template -n openshift windows-desktop-large-v0.7.0 -oyaml
apiVersion: template.openshift.io/v1
kind: Template
metadata:
  annotations:
    defaults.template.kubevirt.io/disk: rootdisk
    defaults.template.kubevirt.io/network: default
    description: This template can be used to create a VM suitable for Microsoft Windows
      Server 2012 R2 and newer. The template assumes that a PVC is available which
      is providing the necessary Windows disk image.
    iconClass: icon-windows
    name.os.template.kubevirt.io/win2k8: Microsoft Windows Server 2008
    name.os.template.kubevirt.io/win2k8r2: Microsoft Windows Server 2008 R2
    name.os.template.kubevirt.io/win2k12r2: Microsoft Windows Server 2012 R2
    name.os.template.kubevirt.io/win2k16: Microsoft Windows Server 2016
    name.os.template.kubevirt.io/win2k19: Microsoft Windows Server 2019
    name.os.template.kubevirt.io/win10: Microsoft Windows 10
    openshift.io/display-name: Microsoft Windows Server 2012 R2+ VM
    openshift.io/documentation-url: https://github.com/kubevirt/common-templates
    openshift.io/provider-display-name: KubeVirt
    openshift.io/support-url: https://github.com/kubevirt/common-templates/issues
    tags: kubevirt,virtualmachine,windows
    template.kubevirt.io/editable: |
      /objects[0].spec.template.spec.domain.cpu.cores
      /objects[0].spec.template.spec.domain.resources.requests.memory
      /objects[0].spec.template.spec.domain.devices.disks
      /objects[0].spec.template.spec.volumes
      /objects[0].spec.template.spec.networks
    template.kubevirt.io/version: v1alpha1
    template.openshift.io/bindable: "false"
    validations: |
      [
        {
          "name": "minimal-required-memory",
          "path": "jsonpath::.spec.domain.resources.requests.memory",
          "rule": "integer",
          "message": "This VM requires more memory.",
          "min": 536870912
        }, {
          "name": "windows-virtio-bus",
          "path": "jsonpath::.spec.domain.devices.disks[*].disk.bus",
          "rule": "enum",
          "message": "virto disk bus type has better performance, install virtio drivers in VM and change bus type",
          "values": ["virtio"],
          "justWarning": true
        }, {
          "name": "windows-disk-bus",
          "path": "jsonpath::.spec.domain.devices.disks[*].disk.bus",
          "rule": "enum",
          "message": "disk bus has to be either virtio or sata",
          "values": ["virtio", "sata"]
        }
      ]
  creationTimestamp: "2020-02-20T14:47:52Z"
  labels:
    flavor.template.kubevirt.io/large: "true"
    os.template.kubevirt.io/win2k8: "true"
    os.template.kubevirt.io/win2k8r2: "true"
    os.template.kubevirt.io/win2k12r2: "true"
    os.template.kubevirt.io/win2k16: "true"
    os.template.kubevirt.io/win2k19: "true"
    os.template.kubevirt.io/win10: "true"
    template.kubevirt.io/type: base
    template.kubevirt.io/version: v0.9.0
    workload.template.kubevirt.io/desktop: "true"
  name: windows-desktop-large-v0.7.0
  namespace: openshift
  ownerReferences:
  - apiVersion: kubevirt.io/v1
    kind: KubevirtCommonTemplatesBundle
    name: common-templates-kubevirt-hyperconverged
    uid: af520b0a-9f80-498b-99bb-6e54f9f492ed
  resourceVersion: "40244"
  selfLink: /apis/template.openshift.io/v1/namespaces/openshift/templates/windows-desktop-large-v0.7.0
  uid: df9ec178-968f-4219-86c9-7d6c5bd74d2b
objects:
- apiVersion: kubevirt.io/v1alpha3
  kind: VirtualMachine
  metadata:
    labels:
      app: ${NAME}
      vm.kubevirt.io/template: windows-desktop-large
      vm.kubevirt.io/template.revision: "1"
      vm.kubevirt.io/template.version: v0.9.0
    name: ${NAME}
  spec:
    running: false
    template:
      metadata:
        labels:
          kubevirt.io/domain: ${NAME}
          kubevirt.io/size: large
      spec:
        domain:
          clock:
            timer:
              hpet:
                present: false
              hyperv: {}
              pit:
                tickPolicy: delay
              rtc:
                tickPolicy: catchup
            utc: {}
          cpu:
            cores: 1
            sockets: 2
            threads: 1
          devices:
            disks:
            - disk:
                bus: sata
              name: rootdisk
            inputs:
            - bus: usb
              name: tablet
              type: tablet
            interfaces:
            - masquerade: {}
              model: e1000e
              name: default
          features:
            acpi: {}
            apic: {}
            hyperv:
              relaxed: {}
              spinlocks:
                spinlocks: 8191
              vapic: {}
          machine:
            type: pc-q35-rhel8.1.0
          resources:
            requests:
              memory: 8Gi
        evictionStrategy: LiveMigrate
        networks:
        - name: default
          pod: {}
        terminationGracePeriodSeconds: 0
        volumes:
        - name: rootdisk
          persistentVolumeClaim:
            claimName: ${PVCNAME}
parameters:
- description: VM name
  from: windows-[a-z0-9]{6}
  generate: expression
  name: NAME
- description: Name of the PVC with the disk image
  name: PVCNAME
  required: true




=======================================================
$ oc get template -n openshift|grep win
win2k12r2-desktop-large-v0.7.0                  This template can be used to create a VM suitable for Microsoft Windows Serve...   2 (1 blank)       1
win2k12r2-desktop-medium-v0.7.0                 This template can be used to create a VM suitable for Microsoft Windows Serve...   2 (1 blank)       1
win2k12r2-server-large-v0.7.0                   This template can be used to create a VM suitable for Microsoft Windows Serve...   2 (1 blank)       1
win2k12r2-server-medium-v0.7.0                  This template can be used to create a VM suitable for Microsoft Windows Serve...   2 (1 blank)       1
windows-desktop-large-v0.7.0                    This template can be used to create a VM suitable for Microsoft Windows Serve...   2 (1 blank)       1
windows-desktop-medium-v0.7.0                   This template can be used to create a VM suitable for Microsoft Windows Serve...   2 (1 blank)       1
windows-server-large-v0.7.0                     This template can be used to create a VM suitable for Microsoft Windows Serve...   2 (1 blank)       1
windows-server-medium-v0.7.0                    This template can be used to create a VM suitable for Microsoft Windows Serve...   2 (1 blank)       1
windows10-desktop-large-v0.7.0                  This template can be used to create a VM suitable for Microsoft Windows 10. T...   2 (1 blank)       1
windows10-desktop-medium-v0.7.0                 This template can be used to create a VM suitable for Microsoft Windows 10. T...   2 (1 blank)       1




=======================================================

Comment 1 Ruth Netser 2020-03-18 13:17:23 UTC
win10 still appears in windows-server templates under labels:

$ oc get templates -n openshift  windows-server-medium-v0.7.0 -oyaml|grep win10
    os.template.kubevirt.io/win10: "true"

$ oc get templates -n openshift  windows-server-large-v0.7.0 -oyaml|grep win10
    os.template.kubevirt.io/win10: "true"

Comment 3 Karel Šimon 2020-04-02 08:57:10 UTC
fixed by https://github.com/kubevirt/common-templates/pull/139/files

Comment 4 Ruth Netser 2020-06-08 11:01:38 UTC
Verified on kubevirt-ssp-operator-container-v2.4.0-46

Comment 7 errata-xmlrpc 2020-07-28 19:09:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3194


Note You need to log in before you can comment on or make changes to this bug.