Bug 1807010
| Summary: | Mke2fs: cannot parse recent mke2fs.conf file | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Pino Toscano <ptoscano> |
| Component: | augeas | Assignee: | Richard W.M. Jones <rjones> |
| Status: | CLOSED MIGRATED | QA Contact: | YongkuiGuo <yoguo> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 8.1 | CC: | rjones, ymankad, yoguo |
| Target Milestone: | rc | Keywords: | MigratedToJIRA, Regression, Reopened, Triaged |
| Target Release: | --- | Flags: | pm-rhel:
mirror+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-09-22 12:19:41 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Pino Toscano
2020-02-25 13:16:48 UTC
*** Bug 1910838 has been marked as a duplicate of this bug. *** Upstream fix is: c4b529fb4a2f8d88844396e33c17a1d670a44b41 After evaluating this issue, there are no plans to address it further or fix it in an upcoming release. Therefore, it is being closed. If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened. Stupid stupid stale bug process. (In reply to Richard W.M. Jones from comment #3) > Upstream fix is: c4b529fb4a2f8d88844396e33c17a1d670a44b41 Do we know if this fix was included in RHEL9 Beta? (In reply to Klaus Heinrich Kiwi from comment #8) > (In reply to Richard W.M. Jones from comment #3) > > Upstream fix is: c4b529fb4a2f8d88844396e33c17a1d670a44b41 > > Do we know if this fix was included in RHEL9 Beta? It is ... ... but this bug is for RHEL 8 and that does not contain the fix. Hi rjones, I failed to verify this bug with augeas-1.12.0-7.el8 package. Steps: On rhel8.6 host: # rpm -q augeas augeas-1.12.0-7.el8.x86_64 # augtool print /files/etc/mke2fs.conf # augtool print /augeas//error | grep /etc/mke2fs.conf /augeas/files/etc/mke2fs.conf/error = "parse_failed" /augeas/files/etc/mke2fs.conf/error/pos = "384" /augeas/files/etc/mke2fs.conf/error/line = "17" /augeas/files/etc/mke2fs.conf/error/char = "0" /augeas/files/etc/mke2fs.conf/error/lens = "/usr/share/augeas/lenses/dist/mke2fs.aug:187.10-.57:" /augeas/files/etc/mke2fs.conf/error/message = "Get did not match entire input" OK I see - I tested this against the Fedora mke2fs.conf, not the RHEL one.
The RHEL one has additional entries:
@@ -14,6 +14,16 @@
features = has_journal,extent,huge_file,flex_bg,metadata_csum,64bit,dir_nlink,extra_isize
inode_size = 256
}
+ rhel6_ext4 = {
+ features = has_journal,extent,huge_file,flex_bg,uninit_bg,dir_nlink,extra_isize
+ inode_size = 256
+ enable_periodic_fsck = 1
+ default_mntopts = ""
+ }
+ rhel7_ext4 = {
+ features = has_journal,extent,huge_file,flex_bg,uninit_bg,dir_nlink,extra_isize,64bit
+ inode_size = 256
+ }
small = {
blocksize = 1024
inode_size = 128
Elsewhere in the file, default_mntopts is a list, such as:
default_mntopts = acl,user_xattr
This is also what is documented in https://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/tree/misc/mke2fs.conf.in#n3
But in one of the entries above, it's an empty string:
default_mntopts = ""
The hand-written parsing code in e2fsprogs is very difficult to follow. All the examples
seem to indicate the quotes are wrong, but obviously it works in mke2fs. I will have to
ask the e2fsprogs team for their opinion.
I found out by experimentation how this works. default_mntopts is not treated as a list internally, but as a string. If quotes are present then they are removed. So: default_mntopts = "" => parsed as empty string default_mntopts = "abc" => parsed as string "abc" default_mntopts = abc,def => parsed as string "abc,def" The augeas parser is wrong and needs an additional fix. rjones, thanks for the explanation. Well my attempt to fix this has so far failed, so I guess we will have to bump this to the next release. The actual -7 package is still fine. Further discussion on: https://github.com/hercules-team/augeas/pull/661 (In reply to Richard W.M. Jones from comment #17) > Well my attempt to fix this has so far failed, so I guess we will have > to bump this to the next release. The actual -7 package is still fine. > rjones, could you help remove this bug from the erratum? Thanks. After evaluating this issue, there are no plans to address it further or fix it in an upcoming release. Therefore, it is being closed. If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened. Reopen this bug since it is closed automatically by RHEL stale bug policy. Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug. This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there. Due to differences in account names between systems, some fields were not replicated. Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information. To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer. You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like: "Bugzilla Bug" = 1234567 In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information. |