Bug 1807714 - Windows Client does not apply the expected mount-path
Summary: Windows Client does not apply the expected mount-path
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: oc
Version: 3.11.0
Hardware: x86_64
OS: Windows
low
medium
Target Milestone: ---
: 3.11.z
Assignee: Sally
QA Contact: zhou ying
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-27 02:46 UTC by Mark Rooks
Modified: 2023-10-06 19:17 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-20 20:27:58 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 2 Mark Rooks 2020-03-13 00:56:11 UTC
I wasn't able to link the Salesforce ticket to the BZ. I have updated the ticket with a comment piinting to the BZ URL. 

The case no. if you are interested is 02593519

Comment 3 Michal Fojtik 2020-05-19 13:12:48 UTC
This bug hasn't had any engineering activity in the last ~30 days. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

As such, we're marking this bug as "LifecycleStale".

If you have further information on the current state of the bug, please update it and remove the "LifecycleStale" keyword, otherwise this bug will be automatically closed in 7 days. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 4 Mark Rooks 2020-05-20 02:11:18 UTC
I can't say why there hasn't been traction yet, priorities maybe?

I am not aware of any fix being applied for this issue and understand that it remains an issue. 

Sally, can you clarify the position from your viewpoint please?

Comment 5 Michal Fojtik 2020-05-27 00:01:59 UTC
This bug hasn't had any activity 7 days after it was marked as LifecycleStale, so we are closing this bug as WONTFIX. If you consider this bug still valuable, please reopen it or create new bug.

Comment 6 Sally 2020-06-18 14:24:11 UTC
I’m adding UpcomingSprint, because I was occupied by fixing bugs with higher priority/severity, developing new features with higher priority, or developing new features to improve stability at a macro level. I will revisit this bug next sprint.

Comment 7 Sally 2020-07-10 19:40:26 UTC
Again, I’m adding UpcomingSprint, because I was occupied by fixing bugs with higher priority/severity, developing new features with higher priority, or developing new features to improve stability at a macro level. I will revisit this bug next sprint.

Comment 8 Sally 2020-07-30 21:50:00 UTC
Again, I’m adding UpcomingSprint, will set up Windows + 3.11 and address this bug this sprint.

Comment 9 Sally 2020-08-06 15:25:45 UTC
ahah, I see this when comparing golang "path" vs "path/filepath" packages:

from "path" overview:
Package path implements utility routines for manipulating slash-separated paths.

The path package should only be used for paths separated by forward slashes, such as the paths in URLs. This package does not deal with Windows paths with drive letters or backslashes; to manipulate operating system paths, use the path/filepath package.

and "path/filepath" overview:
Package filepath implements utility routines for manipulating filename paths in a way compatible with the target operating system-defined file paths.

The filepath package uses either forward slashes or backslashes, depending on the operating system. To process paths such as URLs that always use forward slashes regardless of the operating system, see the path package.

I see volume.go is indeed using "path" not "path/filepath" I'll update that and that should resolve this issue.

Comment 10 Sally 2020-08-13 01:55:05 UTC
I tested with oc where path->"path/filepath" in set/volume.go and while the mountPath does not have the undesired prefix, it does have a backwards slash, like so:

        volumeMounts:
        - mountPath: \app
          name: test-vol

It looks like we'll have to do some string manipulation to get this correct.  Working on it.

Comment 11 Sally 2020-08-13 02:22:29 UTC
I've confirmed that this is not an issue in oc 4.4.16, 4.5.4, or latest oc built from master.

      volumeMounts:
        - mountPath: /app
          name: test-vol 

"path" rather than "path/filepath" package was chosen deliberately in set/volume.go to result in forward rather than backward slash in container mountPath paths.  Still working on the proper fix for this in 3.11.

Comment 12 Sally 2020-08-13 23:27:47 UTC
I should have done this first, but I tested on an ocp 3.11 cluster and I cannot reproduce this.  

Looking at the dc yaml after the set volume cmd from above, I see this:
         volumeMounts:
          - mountPath: /app
            name: test-vol

# oc version
oc v3.11.265
kubernetes v1.11.0+d4cacc0
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://ip-172-18-15-1.ec2.internal:8443
openshift v3.11.265
kubernetes v1.11.0+d4cacc0

Please try this again to let me know if this is still an issue, otherwise I will be closing this.

Comment 13 Mark Rooks 2020-08-20 06:25:07 UTC
SFDC case has been closed. As you point out the behaviour is different now. I think it is OK to leave for now and see if there are any further reports.


Note You need to log in before you can comment on or make changes to this bug.