Bug 1807717 - Dependency php-lessphp retired in f33 and f32
Summary: Dependency php-lessphp retired in f33 and f32
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: dokuwiki
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Artur Frenszek-Iwicki
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1807063
TreeView+ depends on / blocked
 
Reported: 2020-02-27 03:29 UTC by Shawn Iwinski
Modified: 2020-04-01 16:32 UTC (History)
4 users (show)

Fixed In Version: dokuwiki-20180422b-4.fc32
Clone Of:
Environment:
Last Closed: 2020-04-01 00:17:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Shawn Iwinski 2020-02-27 03:29:51 UTC
Dependency php-lessphp has been retired in f33.

While php-lessphp might have worked for the time being, it is not the correct dependency for this package and the correct dependency is already several patch versions ahead.

php-lessphp is/was the following:
- https://leafo.net/lessphp/
- https://github.com/leafo/lessphp
- https://packagist.org/packages/leafo/lessphp

This package requires the following:
- https://www.maswaba.de/lesserphpdocs/
- https://github.com/MarcusSchwarz/lesserphp
- https://packagist.org/packages/marcusschwarz/lesserphp

Comment 2 Artur Frenszek-Iwicki 2020-03-01 14:56:00 UTC
Shawn, would you perhaps be willing to aid in packaging php-lesserphp? I find converting the package from the Composer to Fedora format a bit confusing.

Comment 4 Shawn Iwinski 2020-03-01 22:01:56 UTC
Note: I just noticed that I retired php-lessphp in f32 as well so you will need to build/deploy this new pkg for f32 as well as f33.

Comment 5 Artur Frenszek-Iwicki 2020-03-02 18:23:29 UTC
Thanks for the spec file, Shawn. I have to shamefully admit that until I started editing your spec, I didn't notice that in the GitHub repo, the "master" and "0.5.4" branches differ quite a lot - the "master" one being way more difficult to package.

I have opened a Review Request for php-marcusschwarz-lesserphp: https://bugzilla.redhat.com/show_bug.cgi?id=1809097

Comment 6 Shawn Iwinski 2020-03-04 23:49:58 UTC
IMO the changes in the master branch make the library a much better "modern" PHP library and make it easier/more-standard of a package :) -- because of the class namespacing.  The harder part is making the updated package as compatible with the older non-standard version as possible.

I updated my gist to include specs for both the 0.5.4 release _and_ for the most recent commit to master (280dc40 on Dec 3, 2019) -- again, feel free to take them, modify them, etc however you deem necessary: https://gist.github.com/siwinski/33ab32c70ab8153f4ed4ebf9f5962057

The 0.5.4-1.20191203git280dc40 spec file builds successfully for all of the following dists:
- f33 (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=42202065
- f32: https://koji.fedoraproject.org/koji/taskinfo?taskID=42202067
- f31: https://koji.fedoraproject.org/koji/taskinfo?taskID=42202068
- f30: https://koji.fedoraproject.org/koji/taskinfo?taskID=42202069

Comment 7 Shawn Iwinski 2020-03-04 23:54:15 UTC
FYI: Unfortunately the license is not correct in the 0.5.4 spec I provided you.  See:

- https://github.com/MarcusSchwarz/lesserphp/blob/v0.5.4/composer.json#L6
- https://github.com/MarcusSchwarz/lesserphp/blob/v0.5.4/LICENSE#L1

I noticed that when creating the updated spec file.  Your review request spec needs to be updated to the correct dual-license as well.

Comment 8 Artur Frenszek-Iwicki 2020-03-05 10:45:26 UTC
Yes, the master branch makes lesserphp much closer to modern PHP standards, but I think that until upstream decides to actually make a new release incorporating those changes, it's better to use v0.5.4, since that's what people get when installing the library from Composer.

Thanks for the info about the License tag, I'll keep that in mind.

Comment 9 Shawn Iwinski 2020-03-06 20:53:26 UTC
> but I think that until upstream decides to actually make a new release incorporating those changes, it's better to use v0.5.4, since that's what people get when installing the library from Composer.

Definitely!  I just provided the "latest" spec for you whenever, and if, you ever need to package that setup :)

Comment 10 Fedora Update System 2020-03-23 11:30:25 UTC
FEDORA-2020-062785ad89 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-062785ad89

Comment 11 Fedora Update System 2020-03-24 01:52:05 UTC
FEDORA-2020-062785ad89 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-062785ad89`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-062785ad89

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2020-04-01 00:17:01 UTC
FEDORA-2020-062785ad89 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2020-04-01 16:32:02 UTC
FEDORA-2020-062785ad89 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.