Spec URL: https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-31-x86_64/01258044-python-gilt/python-gilt.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-31-x86_64/01258044-python-gilt/python-gilt-1.2.1-1.fc31.src.rpm Description: gilt is a GIT layering tool Fedora Account System Username: chedi
This package is a new runtime dependency for the existing python-molecule package.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package is missing Requires so runtime does not work, see NOTES at the end - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ Installs properly only on f32, not on f31 - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782 The package contains globing under %files: see %{python3_sitelib}/* ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "Apache License (v2.0)". 36 files have unknown license. Detailed output of licensecheck in /home/clime/rpkg-util/preproc/copr- build-1258044/review-python-gilt/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.8, /usr/lib/python3.8/site-packages [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-gilt [!]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- In f31, installation does _not_ work: # /usr/bin/dnf --installroot /var/lib/mock/fedora-31-x86_64/root/ --releasever 31 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/clime/rpkg-util/preproc/copr-build-1258044/python3-gilt-1.2.1-1.fc33.noarch.rpm /home/clime/rpkg-util/preproc/copr-build-1258044/python-gilt-doc-1.2.1-1.fc33.noarch.rpm --setopt=tsflags=nocontexts Problem: conflicting requests - nothing provides python(abi) = 3.8 needed by python3-gilt-1.2.1-1.fc33.noarch In f32, installation works: # sudo /usr/bin/dnf --installroot /var/lib/mock/fedora-32-x86_64/root/ --releasever 32 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/clime/rpkg-util/preproc/copr-build-1258044/python3-gilt-1.2.1-1.fc33.noarch.rpm /home/clime/rpkg-util/preproc/copr-build-1258044/python-gilt-doc-1.2.1-1.fc33.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: python-gilt-doc-1.2.1-1.fc33.noarch.rpm python3-gilt-1.2.1-1.fc33.noarch.rpm python-gilt-1.2.1-1.fc33.src.rpm python3-gilt.noarch: W: no-documentation python3-gilt.noarch: W: no-manual-page-for-binary gilt 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://pypi.io/packages/source/p/python-gilt/python-gilt-1.2.1.tar.gz : CHECKSUM(SHA256) this package : e23a45a6905e6bb7aec3ff7652b48309933a6991fad4546d9e793ac7e0513f8a CHECKSUM(SHA256) upstream package : e23a45a6905e6bb7aec3ff7652b48309933a6991fad4546d9e793ac7e0513f8a Requires -------- python-gilt-doc (rpmlib, GLIBC filtered): python3-gilt (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) Provides -------- python-gilt-doc: python-gilt-doc python3-gilt: python-gilt python3-gilt python3.8dist(python-gilt) python3dist(python-gilt) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 + edited by reviewer Command line :/usr/bin/fedora-review --copr-build https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-31-x86_64/01258044-python-gilt --mock-config /etc/mock/fedora-31-x86_64.cfg Buildroot used: fedora-31-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: R, Perl, PHP, C/C++, fonts, SugarActivity, Ocaml, Haskell, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH https://github.com/retr0h/gilt/blob/master/requirements.txt NOTES: Test run: [root@cc422f794155 yum.repos.d]# gilt Traceback (most recent call last): File "/usr/bin/gilt", line 6, in <module> from gilt.shell import main File "/usr/lib/python3.7/site-packages/gilt/__init__.py", line 23, in <module> import pbr.version ModuleNotFoundError: No module named 'pbr' There are also some problems during documentation build if you would like to take a look: WARNING: autodoc: failed to import module 'config' from module 'gilt'; the following exception was raised: No module named 'giturlparse' WARNING: autodoc: failed to import module 'git' from module 'gilt'; the following exception was raised: No module named 'sh' WARNING: autodoc: failed to import module 'util' from module 'gilt'; the following exception was raised: No module named 'sh'
Please mainly see issues at the beginning of the review. There is no %check but if you believe it is not necessary I am ok with it.
@clime7, Thank you very much for the time you took to review this package. I updated the spec and srpms to include the missing requirements (they were already installed in the chroot from another project) here are the new files: https://chedi.fedorapeople.org/python-gilt.spec https://chedi.fedorapeople.org/python-gilt-1.2.1-1.fc31.src.rpm Unfortunately there is a requirement to the other package I'm trying to get accepted: https://bugzilla.redhat.com/show_bug.cgi?id=1808023 So this one will be on hold until the other one is in (I may be I should have waited for that one first) if you want to test it anyway here is the srpm https://chedi.fedorapeople.org/python-git-url-parse-1.2.2-1.fc31.src.rpm PS: I didn't add a %check section as the upstream uses tox and it still needs some work (I'm planning to have another go at it over time)
Hello! it looks good but could you, please, build the new version of the package in copr? Also, please the newest version of python-git-url-parse from https://bugzilla.redhat.com/show_bug.cgi?id=1808023 I would like to try installation and check if it gilt will work. Do you plan to release only for f32 or for f31 and f30 too?
@clime7 I've rebuilt them for f30, f31 f32 and f33: https://copr.fedorainfracloud.org/coprs/chedi/python-packages/build/1297178/ https://copr.fedorainfracloud.org/coprs/chedi/python-packages/build/1297175/ everything seems to be ok, here is the pasta: --> Install (F30) mock -r fedora-30-x86_64 install \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-30-x86_64/01297175-python-git-url-parse/python3-git-url-parse-1.2.2-1.fc30.noarch.rpm \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-30-x86_64/01297175-python-git-url-parse/python-git-url-parse-doc-1.2.2-1.fc30.noarch.rpm \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-30-x86_64/01297178-python-gilt/python3-gilt-1.2.1-1.fc30.noarch.rpm \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-30-x86_64/01297178-python-gilt/python-gilt-doc-1.2.1-1.fc30.noarch.rpm --> Install (F31) mock -r fedora-31-x86_64 install \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-31-x86_64/01297175-python-git-url-parse/python3-git-url-parse-1.2.2-1.fc31.noarch.rpm \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-31-x86_64/01297175-python-git-url-parse/python-git-url-parse-doc-1.2.2-1.fc31.noarch.rpm \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-31-x86_64/01297178-python-gilt/python3-gilt-1.2.1-1.fc31.noarch.rpm \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-31-x86_64/01297178-python-gilt/python-gilt-doc-1.2.1-1.fc31.noarch.rpm --> Install (F32) mock -r fedora-32-x86_64 install \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-32-x86_64/01297175-python-git-url-parse/python3-git-url-parse-1.2.2-1.fc32.noarch.rpm \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-32-x86_64/01297175-python-git-url-parse/python-git-url-parse-doc-1.2.2-1.fc32.noarch.rpm \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-32-x86_64/01297178-python-gilt/python3-gilt-1.2.1-1.fc32.noarch.rpm \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-32-x86_64/01297178-python-gilt/python-gilt-doc-1.2.1-1.fc32.noarch.rpm --> Install (F33) mock -r fedora-33-x86_64 install \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-rawhide-x86_64/01297175-python-git-url-parse/python3-git-url-parse-1.2.2-1.fc33.noarch.rpm \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-rawhide-x86_64/01297175-python-git-url-parse/python-git-url-parse-doc-1.2.2-1.fc33.noarch.rpm \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-rawhide-x86_64/01297178-python-gilt/python3-gilt-1.2.1-1.fc33.noarch.rpm \ https://download.copr.fedorainfracloud.org/results/chedi/python-packages/fedora-rawhide-x86_64/01297178-python-gilt/python-gilt-doc-1.2.1-1.fc33.noarch.rpm
Great, gonna try it now immediately!
Ok works. PACKAGE APPROVED! P.S.: it would be nice to add man pages for the gilt command-line tool in the future :).
Btw. if you can take https://bugzilla.redhat.com/show_bug.cgi?id=1810902 I can take https://bugzilla.redhat.com/show_bug.cgi?id=1808023. Let me know, please.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-gilt