spec: https://svgames.pl/fedora/python-whois-0.9.6-1.spec srpm: https://svgames.pl/fedora/python-whois-0.9.6-1.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=41968446 Description: A Python wrapper for Linux "whois" command with simple interface to access parsed WHOIS data for a given domain. Fedora Account System Username: suve
- %{?python_enable_dependency_generator} is enabled by default - The "URL:" line contains a tailing whitespace - README file is missing, not shipped in %doc - According to the setup.py file is there a testsuite. - "Summary: %{Summary}" should be "Summary: %{summary}" Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: python-whois-0.9.6-1.spec should be python-whois.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "do What The Fuck you want to Public License (v2)". 9 files have unknown license. Detailed output of licensecheck in /home/fab/Documents/repos/reviews/1807979-python- whois-0.9.6-1/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: python3-whois (summary) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-whois-0.9.6-1.fc32.noarch.rpm python-whois-0.9.6-1.fc32.src.rpm python3-whois.noarch: W: unexpanded-macro Summary(C) %{Summary} python3-whois.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). python3-whois.noarch: W: unexpanded-macro Summary(C) %{Summary} python3-whois.noarch: W: invalid-url URL: https://github.com/DannyCork/python-whois/ <urlopen error [Errno -2] Name or service not known> python3-whois.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Source checksums ---------------- https://files.pythonhosted.org/packages/source/w/whois/whois-0.9.6.tar.gz : CHECKSUM(SHA256) this package : 8a6f0b2cc3a8ef599d88cc9259e8c2616b25861b26d69bfdeddc8ccfae690b66 CHECKSUM(SHA256) upstream package : 8a6f0b2cc3a8ef599d88cc9259e8c2616b25861b26d69bfdeddc8ccfae690b66 Requires -------- python3-whois (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-whois: python3-whois python3.8dist(whois) python3dist(whois) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1807979 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: PHP, fonts, Haskell, Perl, SugarActivity, Ocaml, R, Java, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
> According to the setup.py file is there a testsuite. Yes there is, but the test suite works by making WHOIS calls, which are going to fail in koji, since the builders run without outernet access. The rest of the issues pointed out in the comment have been fixed. spec: https://svgames.pl/fedora/python-whois-0.9.6-2.spec srpm: https://svgames.pl/fedora/python-whois-0.9.6-2.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=41973641
python-whois-0.9.6-1.spec should be python-whois.spec
I prefer to keep the spec files versioned during the review process so people can compare the changes if they need to. The number goes away when importing to dist-git.
The versioning is done inside the spec file, trackable by the changelog and is shown in the SRPM. I guess that's my point of view. Anyways, as the SRPM contains a spec file that matches the Guidelines, package APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-whois
FEDORA-2020-47f0552977 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-47f0552977
FEDORA-2020-54b1fb50c1 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-54b1fb50c1
python-whois-0.9.6-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-47f0552977
python-whois-0.9.6-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-54b1fb50c1
python-whois-0.9.6-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
python-whois-0.9.6-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
FEDORA-2020-809c4ef393 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-809c4ef393 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-809c4ef393 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-809c4ef393 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.