Bug 1809008 - Review Request: perl-Long-Jump - Mechanism for returning to a specific point from a deeply nested stack
Summary: Review Request: perl-Long-Jump - Mechanism for returning to a specific point ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1808555
TreeView+ depends on / blocked
 
Reported: 2020-03-02 09:29 UTC by Petr Pisar
Modified: 2020-03-06 14:19 UTC (History)
2 users (show)

Fixed In Version: perl-Long-Jump-0.000001-1.fc33
Clone Of:
Environment:
Last Closed: 2020-03-06 14:19:18 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2020-03-02 09:29:09 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Long-Jump/perl-Long-Jump.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Long-Jump/perl-Long-Jump-0.000001-1.fc33.src.rpm
Description:
This Perl module essentially provides a multi-level return. You can mark
a spot with setjump() and then unwind the stack back to that point from any
nested stack frame by name using longjump(). You can also provide a list of
return values. It is safer than C language jump in that it only lets you
escape frames by going up the stack, you cannot jump in other ways.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-03-05 12:44:23 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Long-Jump-0.000001-1.fc33.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Importer)
      1 perl(:MODULE_COMPAT_5.30.1)
      1 perl(strict)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Long-Jump-0.000001-1.fc33.noarch.rpm | sort | uniq -c
      1 perl(Long::Jump) = 0.000001
      1 perl-Long-Jump = 0.000001-1.fc33
Binary provides are Ok.

$ rpmlint ./perl-Long-Jump*
perl-Long-Jump.noarch: W: spelling-error %description -l en_US setjump -> set jump, set-jump, strumpet
perl-Long-Jump.noarch: W: spelling-error %description -l en_US longjump -> long jump, long-jump, polonium
perl-Long-Jump.src: W: spelling-error %description -l en_US setjump -> set jump, set-jump, strumpet
perl-Long-Jump.src: W: spelling-error %description -l en_US longjump -> long jump, long-jump, polonium
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is ok

Resolution:
Approved

Comment 3 Gwyn Ciesla 2020-03-06 14:01:03 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Long-Jump

Comment 4 Petr Pisar 2020-03-06 14:19:18 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.