Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1809211

Summary: Wrong restic images after upgrade
Product: OpenShift Container Platform Reporter: Sergio <sregidor>
Component: Migration ToolingAssignee: Pranav Gaikwad <pgaikwad>
Status: CLOSED ERRATA QA Contact: Sergio <sregidor>
Severity: high Docs Contact:
Priority: medium    
Version: 4.3.0CC: chezhang, dymurray, rpattath, whu, xjiang
Target Milestone: ---   
Target Release: 4.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1809271 (view as bug list) Environment:
Last Closed: 2020-05-28 11:06:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1809271    

Description Sergio 2020-03-02 15:27:40 UTC
Description of problem:
After upgrading from 1.0.1 to 1.1.1 restic pods still point to the old version's image.


Version-Release number of selected component (if applicable):
CAM 1.1.1

How reproducible:
Always

Steps to Reproduce:
1. Deploy CAM 1.0.1
2. Upgrade to CAM 1.1.1


Actual results:
Restic pods still point to the 1.0.1 image, while the other pods are using the new 1.1.1 image.


$ oc get pod restic-x2d7v -o yaml | grep image
    image: registry.redhat.io/rhcam-1-0/openshift-migration-velero-rhel8@sha256:d4423442db8618e4c96faadd96b053572ecf278f07461c8f8709af8094e8a5da
    imagePullPolicy: Always
  imagePullSecrets:
    image: registry.redhat.io/rhcam-1-0/openshift-migration-velero-rhel8@sha256:d4423442db8618e4c96faadd96b053572ecf278f07461c8f8709af8094e8a5da
    imageID: registry.redhat.io/rhcam-1-0/openshift-migration-velero-rhel8@sha256:d4423442db8618e4c96faadd96b053572ecf278f07461c8f8709af8094e8a5da


$ oc get pod velero-5ccc958449-4cxkh -o yaml |grep image
    image: registry.redhat.io/rhcam-1-1/openshift-migration-velero-rhel8@sha256:db2997115d8a0767d61038e14f48170dc53d3c54b977184e7ecb37ead2f131da



Expected results:
All pods should be using 1.1.1 image



Additional info:
The restic daemonset uses OnDelete update strategy:

  templateGeneration: 2
  updateStrategy:
    type: OnDelete

Comment 1 Dylan Murray 2020-03-02 18:26:09 UTC
For all Restic daemonsets that we are creating for lets set `updateStrategy` to rollingUpdate to counter the fact that the v1beta1 daemonsets set the default updateStrategy to onDelete.

Comment 3 Pranav Gaikwad 2020-04-01 18:38:57 UTC
Fixed with : https://github.com/konveyor/mig-operator/pull/249

Needs cherry-pick

Comment 7 Sergio 2020-05-11 15:23:26 UTC
Verified using CAM 1.2 stage

Restic pods were upgraded too.

$ oc get pods
NAME                                    READY   STATUS        RESTARTS   AGE
migration-controller-575b8cbf8d-tpjt7   2/2     Running       0          39s
migration-operator-67cf6c488-vp7hv      2/2     Running       0          2m22s
migration-ui-7658c877b9-fjd7s           1/1     Terminating   0          63m
migration-ui-fb9478878-mj46n            1/1     Running       0          32s
restic-hj4ms                            1/1     Running       0          39s
restic-kjvjz                            1/1     Running       0          23s
restic-sm9wd                            1/1     Running       0          54s
velero-68c5d86ccc-c6w6q                 1/1     Running       0          66s


Verified that the strategy was rollingupgrade 

$ oc get ds restic -o yaml | grep -i strategy -A 3
  updateStrategy:
    rollingUpdate:
      maxUnavailable: 1
    type: RollingUpdate

Comment 9 errata-xmlrpc 2020-05-28 11:06:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:2328