Bug 1809262 - Review Request: rtl-wmbus - Software defined receiver for wireless M-Bus with RTL-SDR
Summary: Review Request: rtl-wmbus - Software defined receiver for wireless M-Bus with...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1809261
Blocks: 1809263
TreeView+ depends on / blocked
 
Reported: 2020-03-02 18:04 UTC by Damian Wrobel
Modified: 2020-04-02 00:31 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-04-02 00:31:21 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Damian Wrobel 2020-03-02 18:04:52 UTC
Spec URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/rtl-wmbus.spec
SRPM URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/rtl-wmbus-0-2.20191213git6a04c45.fc31.src.rpm
Description: rtl-wmbus is a software defined receiver for Wireless-M-Bus.
It is written in plain C and uses RTL-SDR to interface with RTL2832-based
hardware.

Wireless-M-Bus is the wireless version of M-Bus
("Meter-Bus", http://www.m-bus.com), which is an European standard for
remote reading of smart meters.

The primary purpose of rtl-wmbus is experimenting with digital signal
processing and software radio.

rtl-wmbus can be used on resource constrained devices such as Raspberry Pi Zero
or Raspberry PI B+ overclocked to 1GHz. Any Android based tablet will do
the same too.

rtl-wmbus provides:
  - filtering
  - FSK demodulating
  - clock recovering
  - mode T1 and mode C1 packet decoding

Fedora Account System Username: dwrobel

COPR build: https://copr.fedorainfracloud.org/coprs/dwrobel/rtl-wmbus/

Comment 1 Robert-André Mauchin 🐧 2020-03-21 22:02:24 UTC
 - Split the LICENSE from the README.md:

sed -e '0,/^  License/d' README.md > LICENSE

 - The changelog entries have incorrect version-release:

%changelog
* Tue Mar 03 2020 Damian Wrobel <dwrobel.pl> - 0-3.20191213git6a04c45
- Use %%set_build_flags

* Mon Mar 02 2020 Damian Wrobel <dwrobel.pl> - 0-2.20191213git6a04c45
- Add upstream reference to patch.

* Fri Feb 28 2020 Damian Wrobel <dwrobel.pl> - 0-1.20191213git6a04c45
- Initial RPM release.

 - %forgemeta             -v

Remove -v before importing in Koji, it can cause issues with fedpkg.


Package approved. Please fix the aforementioned issue before import.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 2-clause "Simplified" License". 25
     files have unknown license. Detailed output of licensecheck in
     /home/bob/packaging/review/rtl-wmbus/review-rtl-wmbus/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rtl-wmbus-0-3.20191213git6a04c45.fc33.x86_64.rpm
          rtl-wmbus-debuginfo-0-3.20191213git6a04c45.fc33.x86_64.rpm
          rtl-wmbus-debugsource-0-3.20191213git6a04c45.fc33.x86_64.rpm
          rtl-wmbus-0-3.20191213git6a04c45.fc33.src.rpm
rtl-wmbus.x86_64: W: incoherent-version-in-changelog 0.20191213-3 ['0-3.20191213git6a04c45.fc33', '0-3.20191213git6a04c45']
rtl-wmbus.x86_64: W: no-manual-page-for-binary rtl_wmbus
rtl-wmbus.src: W: patch-not-applied Patch0: %{name}-Allow-to-redefine-CFLAGS-LDFLAGS-and-OUTPUT-director.patch
rtl-wmbus.src: E: specfile-error Setting %{forgeurl0} = https://github.com/xaelsouth/rtl-wmbus
rtl-wmbus.src: E: specfile-error Setting %{commit0} = 6a04c4548245c4f6adaad6348ee4d2deef825d63
rtl-wmbus.src: E: specfile-error Setting %{version0} = 0
rtl-wmbus.src: E: specfile-error Setting %{date0} = 20191213
rtl-wmbus.src: E: specfile-error Setting %{forgeurl} = https://github.com/xaelsouth/rtl-wmbus
rtl-wmbus.src: E: specfile-error Setting %{fileref} = 6a04c4548245c4f6adaad6348ee4d2deef825d63
rtl-wmbus.src: E: specfile-error Setting %{ref} = 6a04c4548245c4f6adaad6348ee4d2deef825d63
rtl-wmbus.src: E: specfile-error Setting %{archiveext} = tar.gz
rtl-wmbus.src: E: specfile-error Setting %{archiveurl} = https://github.com/xaelsouth/rtl-wmbus/archive/6a04c4548245c4f6adaad6348ee4d2deef825d63/%{archivename}.tar.gz
rtl-wmbus.src: E: specfile-error Setting %{archivename} = %{repo}-6a04c4548245c4f6adaad6348ee4d2deef825d63
rtl-wmbus.src: E: specfile-error Setting %{scm} = git
rtl-wmbus.src: E: specfile-error Setting %{topdir} = %{repo}-6a04c4548245c4f6adaad6348ee4d2deef825d63
rtl-wmbus.src: E: specfile-error Setting %{repo} = rtl-wmbus
rtl-wmbus.src: E: specfile-error Setting %{forgesource} = https://github.com/xaelsouth/rtl-wmbus/archive/6a04c4548245c4f6adaad6348ee4d2deef825d63/rtl-wmbus-6a04c4548245c4f6adaad6348ee4d2deef825d63.tar.gz
rtl-wmbus.src: E: specfile-error Setting %{forgesetupargs} = -n %{extractdir}
rtl-wmbus.src: E: specfile-error Setting %{extractdir} = rtl-wmbus-6a04c4548245c4f6adaad6348ee4d2deef825d63
rtl-wmbus.src: E: specfile-error Setting %{distprefix} = .20191213git6a04c45
rtl-wmbus.src: E: specfile-error Setting %{forgesource0} = https://github.com/xaelsouth/rtl-wmbus/archive/6a04c4548245c4f6adaad6348ee4d2deef825d63/rtl-wmbus-6a04c4548245c4f6adaad6348ee4d2deef825d63.tar.gz
rtl-wmbus.src: E: specfile-error Setting %{forgesetupargs0} = -n rtl-wmbus-6a04c4548245c4f6adaad6348ee4d2deef825d63
rtl-wmbus.src: E: specfile-error Setting %{archivename0} = rtl-wmbus-6a04c4548245c4f6adaad6348ee4d2deef825d63
rtl-wmbus.src: E: specfile-error Setting %{archiveext0} = tar.gz
rtl-wmbus.src: E: specfile-error Setting %{archiveurl0} = https://github.com/xaelsouth/rtl-wmbus/archive/6a04c4548245c4f6adaad6348ee4d2deef825d63/rtl-wmbus-6a04c4548245c4f6adaad6348ee4d2deef825d63.tar.gz
rtl-wmbus.src: E: specfile-error Setting %{topdir0} = rtl-wmbus-6a04c4548245c4f6adaad6348ee4d2deef825d63
rtl-wmbus.src: E: specfile-error Setting %{extractdir0} = rtl-wmbus-6a04c4548245c4f6adaad6348ee4d2deef825d63
rtl-wmbus.src: E: specfile-error Setting %{repo0} = rtl-wmbus
rtl-wmbus.src: E: specfile-error Setting %{scm0} = git
rtl-wmbus.src: E: specfile-error Setting %{distprefix0} = .20191213git6a04c45
4 packages and 0 specfiles checked; 27 errors, 3 warnings.

Comment 2 Damian Wrobel 2020-03-23 17:18:45 UTC
(In reply to Robert-André Mauchin from comment #1)
>  - Split the LICENSE from the README.md:
Fixed

>- The changelog entries have incorrect version-release:
Fixed

>  - %forgemeta             -v
Fixed.

Thank you very much for the review.

Comment 3 Gwyn Ciesla 2020-03-23 18:03:22 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rtl-wmbus

Comment 4 Fedora Update System 2020-03-24 18:48:24 UTC
FEDORA-2020-b24468740a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b24468740a

Comment 5 Fedora Update System 2020-03-25 12:03:06 UTC
FEDORA-2020-b24468740a has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-b24468740a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b24468740a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2020-04-02 00:31:21 UTC
FEDORA-2020-b24468740a has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.