Spec URL: http://dl.kwizart.net/review/algobox.spec SRPM URL: http://dl.kwizart.net/review/algobox-1.0.3-1.fc31.src.rpm Description: Algorithmic software Fedora Account System Username: kwizart Koji scratch build: f33: https://koji.fedoraproject.org/koji/taskinfo?taskID=42147261 epel8: (unrelated failure with gcc) https://koji.fedoraproject.org/koji/taskinfo?taskID=42146955
># Because qtwebengine is not always available ># Look at qt5_qtwebengine_arches RPM macro >ExclusiveArch: %{ix86} x86_64 %{arm} aarch64 mips mipsel mips64el Add a BuildRequires: for the "qt5-srpm-macros" package and use the "%{qt5_qtwebengine_arches}" macro here.
Thx for looking into it. Do you have an already working example of this in the fedora collection ? Because I expect that when the buildrequires list is computed (at make src.rpm time), the macro isn't yet available, so will be empty. Maybe dynamics buildrequires can help with that ?
There are other packages in Fedora with similar issues, e.g. stuff written in Pascal: those packages have a BuildRequires for "fpc-srpm-macros" and "ExclusiveArch: %{fpc_arches}" to limit them to architectures supported by the Free Pascal Compiler. If it works for that macro, I don't see a reason why it wouldn't work here.
Okay, I got it. Switched to ExclusiveArch: %{qt5_qtwebengine_arches} Since redhat-rpm-config is in the default for srpm-build group and it has a dependency on qt5-srpm-macros (along others macros only packages), the macro can be expanded as appropriate. Is there any others review comment ?
- Add the docs present in utilities %doc utilities/AUTHORS utilities/CHANGELOG.txt - Use %{qt5_qtwebengine_arches} as mentioned before. Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v2 or later)", "GPL (v2)", "GNU Lesser General Public License". 166 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/algobox/review-algobox/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: algobox (description) [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: algobox-1.0.3-1.fc33.x86_64.rpm algobox-debuginfo-1.0.3-1.fc33.x86_64.rpm algobox-debugsource-1.0.3-1.fc33.x86_64.rpm algobox-1.0.3-1.fc33.src.rpm algobox.x86_64: I: enchant-dictionary-not-found fr algobox.x86_64: W: unexpanded-macro %description -l C %description algobox.x86_64: W: spelling-error %description -l en_US un -> UN, nu, in algobox.x86_64: W: spelling-error %description -l en_US logiciel -> geologic, ecologic, logic algobox.x86_64: W: spelling-error %description -l en_US d'initiation -> initiation, initialization algobox.x86_64: W: spelling-error %description -l en_US à -> e, s, i algobox.x86_64: W: spelling-error %description -l en_US l'algorithmique -> algorithmic algobox.x86_64: W: spelling-error %description -l en_US au -> Au, a, u algobox.x86_64: W: spelling-error %description -l en_US niveau -> univalve algobox.x86_64: W: spelling-error %description -l en_US lycée -> lyceum algobox.x86_64: W: unexpanded-macro %description -l fr %description algobox.x86_64: W: no-documentation algobox.x86_64: E: incorrect-fsf-address /usr/share/algobox/COPYING algobox.x86_64: W: no-manual-page-for-binary algobox algobox.src: W: unexpanded-macro %description -l C %description algobox.src: W: spelling-error %description -l en_US un -> UN, nu, in algobox.src: W: spelling-error %description -l en_US logiciel -> geologic, ecologic, logic algobox.src: W: spelling-error %description -l en_US d'initiation -> initiation, initialization algobox.src: W: spelling-error %description -l en_US à -> e, s, i algobox.src: W: spelling-error %description -l en_US l'algorithmique -> algorithmic algobox.src: W: spelling-error %description -l en_US au -> Au, a, u algobox.src: W: spelling-error %description -l en_US niveau -> univalve algobox.src: W: spelling-error %description -l en_US lycée -> lyceum algobox.src: W: unexpanded-macro %description -l fr %description 4 packages and 0 specfiles checked; 1 errors, 22 warnings.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/algobox
Package imported. Thanks for the review and comments.