Bug 1809820 - GCP UPI cluster cluster name regex check does not support '.' in cluster name
Summary: GCP UPI cluster cluster name regex check does not support '.' in cluster name
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 4.2.z
Hardware: Unspecified
OS: Linux
unspecified
high
Target Milestone: ---
: 4.5.0
Assignee: Jeremiah Stuever
QA Contact: Yang Yang
URL:
Whiteboard:
Depends On:
Blocks: 1811153
TreeView+ depends on / blocked
 
Reported: 2020-03-03 23:10 UTC by Antonio Escalera
Modified: 2023-09-07 22:11 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1811153 (view as bug list)
Environment:
Last Closed: 2020-07-13 17:17:56 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift installer pull 3239 0 None closed Bug 1809820: gcp/platform: Allow periods in the cluster name. 2021-01-17 08:26:30 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:18:17 UTC

Description Antonio Escalera 2020-03-03 23:10:24 UTC
Description of problem:

UPI in GCP does not support clusters with '.' in the name

Version-Release number of the following components:

4.3.2

How reproducible:

100%

Steps to Reproduce:

1. Create `install-config.yaml` with cluster name field containing anything including a '.'

Actual results:

`FATAL failed to fetch Master Machines: failed to load asset "Install Config": invalid "install-config.yaml" file: metadata.name: Invalid value: "gcpusc1-h.sbx.xpaas": GCP requires cluster name to match regular expression (?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)`

Expected results:

Cluster manifest files are created successfully

Comment 1 Abhinav Dahiya 2020-03-03 23:58:43 UTC
(In reply to Antonio Escalera from comment #0)
> Description of problem:
> 
> UPI in GCP does not support clusters with '.' in the name
> 
> Version-Release number of the following components:
> 
> 4.3.2
> 
> How reproducible:
> 
> 100%
> 
> Steps to Reproduce:
> 
> 1. Create `install-config.yaml` with cluster name field containing anything
> including a '.'
> 
> Actual results:
> 
> `FATAL failed to fetch Master Machines: failed to load asset "Install
> Config": invalid "install-config.yaml" file: metadata.name: Invalid value:
> "gcpusc1-h.sbx.xpaas": GCP requires cluster name to match regular expression
> (?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)`


I think the error message is clear that we do not support a cluster name with `.` for GCP. I'm not sure what's the bug here?

> 
> Expected results:
> 
> Cluster manifest files are created successfully

Comment 2 Antonio Escalera 2020-03-04 16:20:14 UTC
The bug is not supporting cluster name with '.' for GCP.

That's inconvenient for customers and is supported on every other platform I've attempted.

The answer "We/the openshift installer don't support cluster names with '.' for GCP" isn't something I can go back to a customer with.
I'll at least need to know why it isn't supported.

Why aren't clusters with '.' supported?
What changes will need to be made to support this?

Comment 3 Antonio Escalera 2020-03-04 16:22:56 UTC
(In reply to Abhinav Dahiya from comment #1)
> (In reply to Antonio Escalera from comment #0)
> > Description of problem:
> > 
> > UPI in GCP does not support clusters with '.' in the name
> > 
> > Version-Release number of the following components:
> > 
> > 4.3.2
> > 
> > How reproducible:
> > 
> > 100%
> > 
> > Steps to Reproduce:
> > 
> > 1. Create `install-config.yaml` with cluster name field containing anything
> > including a '.'
> > 
> > Actual results:
> > 
> > `FATAL failed to fetch Master Machines: failed to load asset "Install
> > Config": invalid "install-config.yaml" file: metadata.name: Invalid value:
> > "gcpusc1-h.sbx.xpaas": GCP requires cluster name to match regular expression
> > (?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)`
> 
> 
> I think the error message is clear that we do not support a cluster name
> with `.` for GCP. I'm not sure what's the bug here?
> 
> > 
> > Expected results:
> > 
> > Cluster manifest files are created successfully


The bug is not supporting cluster name with '.' for GCP.

That's inconvenient for customers and is supported on every other platform I've attempted.

The answer "We/the openshift installer don't support cluster names with '.' for GCP" isn't something I can go back to a customer with.
I'll at least need to know why it isn't supported.

Why aren't clusters with '.' supported?
What changes will need to be made to support this?

Comment 4 Antonio Escalera 2020-03-04 16:31:01 UTC
Here is the validation check:
https://github.com/openshift/installer/blob/master/pkg/types/gcp/validation/platform.go#L76-L85

Comment 10 Yang Yang 2020-03-10 07:39:42 UTC
Verified with 4.5.0-0.nightly-2020-03-10-031811

GCP UPI install with cluster name yy.cn passed. From QE perspective, '.' is supported in cluster name hence moving it to verified state.

Comment 14 errata-xmlrpc 2020-07-13 17:17:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.