Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1810153

Summary: fix leaking device state in files in /run/NetworkManager/devices
Product: Red Hat Enterprise Linux 8 Reporter: Thomas Haller <thaller>
Component: NetworkManagerAssignee: Thomas Haller <thaller>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.2CC: acardace, atragler, bgalvani, lmiksik, lrintel, rkhan, sukulkar, thaller, till, vbenes
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: NetworkManager-1.22.8-4.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-28 16:54:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Thomas Haller 2020-03-04 15:56:55 UTC
NetworkManager writes the device state to /run/NetworkManager/devices.

The filename of these devices, is the ifindex. That is good, because the ifindex uniquely identifies the file at an time (yes, in practice the ifindex can be repeated, but that is no problem here). Also, the data in /run is only relevant for the current boot -- just like the ifindex.

But NetworkManager would only cleanup stale files when quitting. Usually NetworkManager service is not stopped (except during shutdown/reboot). So, in practice, these files pile up until reboot.

When creating (and deleting) a large number of software devices, this becomes a problem.

Imagine docker/podman that creates veth devices for each container.


Fix that by pruning stale files (from time to time).

Comment 2 Thomas Haller 2020-03-04 16:10:10 UTC
reproducer:


```

Create() {
  printf "#%05d: create device \"test\"\n" "$1"
  ip link delete test &>/dev/null
  ip link add test type bridge
  ip addr add 192.168.193.166/24 dev test
  ip link set test up
  sleep 1
}

Create_n() {
  for i in $(seq 1 "$1"); do
    Create "$i"
  done
}

Create_n 100

```

At the end, look at 

  $ ls -la /run/NetworkManager/devices/


also, while it's running, look at

  $ watch 'ip link show dev test; ls -la /run/NetworkManager/devices/'

Comment 8 Vladimir Benes 2020-03-20 14:38:57 UTC
Test case 'clean_device_state_files' added.

Comment 10 errata-xmlrpc 2020-04-28 16:54:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1847