Description of problem: I am reviewing bug 1804529. The spec file contains this: %install rm -rf $RPM_BUILD_ROOT %make_install but fedora-review produced this: [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Version-Release number of selected component (if applicable): fedora-review-0.7.5-1.fc31.noarch How reproducible: Always Steps to Reproduce: 1. Create a spec file with an %install section as shown above 2. Run fedora-review on it Actual results: The test passes. Expected results: The test should fail. Additional info:
In /usr/share/fedora-review/plugins/generic.py, line 230: regex = r"rm\s+\-[rf][rf]\s+(@buildroot@|$RPM_BUILD_ROOT)[^/]" the $ should be escaped; i.e., regex = r"rm\s+\-[rf][rf]\s+(@buildroot@|\$RPM_BUILD_ROOT)[^/]"
This message is a reminder that Fedora 31 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '31'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 31 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
I submitted a pull request to make the change in comment 1, and it was merged, but there has been no new release of fedora-review since. Please, can we have another release? Several bugs have been fixed in master. It would be good to get the fixes into the hands of package reviewers.
FEDORA-2020-20c4ebf164 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-20c4ebf164
FEDORA-2020-af607360e8 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-af607360e8
FEDORA-2020-219835ab79 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-219835ab79
FEDORA-2020-20c4ebf164 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-20c4ebf164` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-20c4ebf164 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-219835ab79 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-219835ab79` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-219835ab79 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-af607360e8 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-af607360e8` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-af607360e8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-219835ab79 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-af607360e8 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-20c4ebf164 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.