Spec URL: https://petersen.fedorapeople.org/reviews/hello/hello.spec SRPM URL: https://petersen.fedorapeople.org/reviews/hello/hello-2.10-1.fc32.src.rpm Description: The GNU Hello program produces a familiar, friendly greeting. Yes, this is another implementation of the classic program that prints âHello, world!â when you run it. However, unlike the minimal version often seen, GNU Hello processes its argument list to modify its behavior, supports greetings in many languages, and so on. The primary purpose of GNU Hello is to demonstrate how to write other programs that do these things; it serves as a model for GNU coding standards and GNU maintainer practices. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=42240531
Spec URL: https://petersen.fedorapeople.org/reviews/hello/hello.spec SRPM URL: https://petersen.fedorapeople.org/reviews/hello/hello-2.10-2.fc32.src.rpm add gpgverify of source
This package was retired in 2012 (see bug 821762). The original review was bug 476936 (2009). A fork is here: https://src.fedoraproject.org/fork/petersen/rpms/hello https://koji.fedoraproject.org/koji/taskinfo?taskID=42240809
> URL: http://www.gnu.org/software/hello/ https please. Even GNU supports that nowadays. make %{?_smp_mflags} → %make_build make install DESTDIR=$RPM_BUILD_ROOT → %make_install
$RPM_BUILD_ROOT → %buildroot to make things more modern.
- If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text Also: Requires: info seems suspicious.
Thank you, Zbigniew, sorry for the delay. I think I have fixed all the issues you pointed out: (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > > URL: http://www.gnu.org/software/hello/ > > https please. Even GNU supports that nowadays. :-) > make %{?_smp_mflags} → %make_build > make install DESTDIR=$RPM_BUILD_ROOT → %make_install (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > $RPM_BUILD_ROOT → %buildroot to make things more modern. Done (In reply to Zbigniew Jędrzejewski-Szmek from comment #5) > Note: License file COPYING is not marked as %license Oops, good catch > Also: Requires: info seems suspicious. How about Recommends? https://src.fedoraproject.org/fork/petersen/rpms/hello/c/1317b3590753f0eea349c0a266fb51fa4a5e0d70
(In reply to Jens Petersen from comment #6) > https://src.fedoraproject.org/fork/petersen/rpms/hello/c/ > 1317b3590753f0eea349c0a266fb51fa4a5e0d70 Okay, now with a release bump: https://src.fedoraproject.org/fork/petersen/rpms/hello/c/4ff214be2e5e0b252e2d42e3ea81baf04183e5cd
Looks all good now. Package is RE-APPROVED.
Spec URL: https://petersen.fedorapeople.org/reviews/hello/hello.spec SRPM URL: https://petersen.fedorapeople.org/reviews/hello/hello-2.10-3.fc32.src.rpm Thanks! I meant to post links too Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=42946656
I requested unretirement to releng in https://pagure.io/releng/issue/9377
FEDORA-2020-f0bfd67c52 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f0bfd67c52
FEDORA-2020-48b58104ed has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-48b58104ed
FEDORA-2020-0348f28a44 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0348f28a44
FEDORA-2020-f0bfd67c52 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f0bfd67c52 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f0bfd67c52 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-48b58104ed has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-48b58104ed \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-48b58104ed See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-0348f28a44 has been pushed to the Fedora 30 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-0348f28a44 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0348f28a44 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-48b58104ed has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-0348f28a44 has been pushed to the Fedora 30 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-f0bfd67c52 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.