Bug 1811182 - Review Request: golang-github-aliyun-ossutil - Alibaba Cloud (Aliyun) Object Storage Service (OSS) CLI
Summary: Review Request: golang-github-aliyun-ossutil - Alibaba Cloud (Aliyun) Object ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1811179 1811180 1811181
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-03-06 18:52 UTC by Brandon Perkins
Modified: 2020-08-03 20:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-03 20:45:08 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Brandon Perkins 2020-03-06 18:52:23 UTC
Spec URL: https://raw.githubusercontent.com/bdperkin/aliyun/master/SPECS/golang-github-aliyun-ossutil.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/aliyun/srpm-builds/01291487/golang-github-aliyun-ossutil-1.6.10-1.fc31.src.rpm
Description: 
A user friendly command line tool to access AliCloud OSS.
Fedora Account System Username: bdperkin
Note: These are my first packages and I need a sponsor.
Successful copr build: https://copr.fedorainfracloud.org/coprs/bdperkin/aliyun/build/01291487/

Comment 1 Brandon Perkins 2020-03-10 12:47:33 UTC
Spec URL: https://raw.githubusercontent.com/bdperkin/aliyun/master/SPECS/golang-github-aliyun-ossutil.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/aliyun/srpm-builds/01293812/golang-github-aliyun-ossutil-1.6.10-2.fc31.src.rpm
Successful copr build: https://copr.fedorainfracloud.org/coprs/bdperkin/aliyun/build/01293812/
Changelog:
* Fri Mar 06 2020 Brandon Perkins <bperkins> - 1.6.10-2
- Add man page

* Wed Mar 04 2020 Brandon Perkins <bperkins> - 1.6.10-1
- Update to version 1.6.10

* Fri Nov 22 2019 Brandon Perkins <bperkins> - 1.6.9-1
- Initial package

Comment 2 Robert-André Mauchin 🐧 2020-03-24 21:35:11 UTC
 - Don't gzip yourself, it is handled by rpm:

gzip %{gobuilddir}/share/man/man1/ossutil.1


 - Source is 404, add the tag to correctly d/l it:

# https://github.com/aliyun/ossutil
%global goipath         github.com/aliyun/ossutil
Version:                1.6.10
%global tag             1.6.10


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Comment 3 Brandon Perkins 2020-07-30 16:28:28 UTC
Spec URL: https://raw.githubusercontent.com/bdperkin/aliyun/master/SPECS/golang-github-aliyun-ossutil.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/803/48200803/golang-github-aliyun-ossutil-1.6.18-2.fc33.src.rpm

Changes are not complete, so not requesting fedora-review+ flag yet.

Changes:
- Enable check stage
- Add version tag
- Remove explicit gzip of man page
- Update to version 1.6.18 (#1811182)
- Explicitly harden package
- Remove golang(github.com/satori/go.uuid)
  (commit=b2ce2384e17bbe0c6d34077efa39dbab3e09123b) BuildRequires
- Fix man page generation
- Clean changelog

Blocking Issue/Question: Tests are enabled now, however, they seem to require credentials to run.  How should this be dealt with?

Comment 4 Brandon Perkins 2020-07-31 19:17:12 UTC
Spec URL: https://raw.githubusercontent.com/bdperkin/aliyun/master/SPECS/golang-github-aliyun-ossutil.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/4805/48294805/golang-github-aliyun-ossutil-1.6.18-2.fc33.src.rpm

I found the answer to my question in: https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_running_the_unit_tests_gocheck

The tests that require credentials have been disabled in the %gocheck line.

Changes are complete, requesting review.

Changes:
- Enable check stage
- Disable 'lib' tests due to need for credentials
- Add version tag
- Remove explicit gzip of man page

Comment 5 Robert-André Mauchin 🐧 2020-08-02 23:00:12 UTC
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 6 Gwyn Ciesla 2020-08-03 13:14:48 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-aliyun-ossutil

Comment 7 Brandon Perkins 2020-08-03 20:45:08 UTC
CLOSED. In Rawhide (f33).


Note You need to log in before you can comment on or make changes to this bug.