Bug 1811409 - Review Request: python-mdx_gh_links - Python-Markdown Github-Links Extension
Summary: Review Request: python-mdx_gh_links - Python-Markdown Github-Links Extension
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1811410
TreeView+ depends on / blocked
 
Reported: 2020-03-08 12:40 UTC by Robin Lee
Modified: 2020-03-26 01:19 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-26 01:19:51 UTC
Type: ---
Embargoed:
jamatos: fedora-review+


Attachments (Terms of Use)

Description Robin Lee 2020-03-08 12:40:53 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01298188-python-mdx_gh_links/python-mdx_gh_links.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/cheeselee/review/fedora-rawhide-x86_64/01298188-python-mdx_gh_links/python-mdx_gh_links-0.2-1.fc33.src.rpm
Description: This package provides an extension to Python-Markdown which adds support for
shorthand links to GitHub users, repositories, issues and commits.
Fedora Account System Username: cheeselee

Comment 1 José Matos 2020-03-14 21:38:24 UTC
I know that this minor and cosmetic but I would suggest to rename in the spec

srcname -> pypiname

It is clear and then it clearly hints at the difference between the project name and the pypi name.


Other than the license is correct and appropriated, the spec files is simple and well written and fedora-review has no complains.
So the package is approved.

Comment 2 Gwyn Ciesla 2020-03-16 13:35:36 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mdx_gh_links

Comment 3 Fedora Update System 2020-03-18 06:50:03 UTC
FEDORA-2020-0cbc374ab3 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0cbc374ab3

Comment 4 Fedora Update System 2020-03-26 01:19:51 UTC
FEDORA-2020-0cbc374ab3 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.